GNU bug report logs - #9802
23.3; missing key binding for rmail-summary-by-senders in Rmail [PATCH]

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9802 in the body.
You can then email your comments to 9802 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mark Lillibridge <mark.lillibridge <at> hp.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.3;
	missing key binding for rmail-summary-by-senders in Rmail [PATCH]
Date: Wed, 19 Oct 2011 20:04:15 -0700

Compare the key bindings in Rmail summary mode:

C-M-f		rmail-summary-by-senders
C-M-h		rmail-summary
C-M-l		rmail-summary-by-labels
C-M-n		rmail-summary-next-labeled-message
C-M-p		rmail-summary-previous-labeled-message
C-M-r		rmail-summary-by-recipients
C-M-s		rmail-summary-by-regexp
C-M-t		rmail-summary-by-topic

to those of Rmail mode:

C-M-h		rmail-summary
C-M-l		rmail-summary-by-labels
C-M-n		rmail-next-labeled-message
C-M-p		rmail-previous-labeled-message
C-M-r		rmail-summary-by-recipients
C-M-s		rmail-summary-by-regexp
C-M-t		rmail-summary-by-topic

You'll notice that a binding for C-M-f to rmail-summary-by-senders
(added recently) is missing from Rmail mode.

(C-M-f is normally bound to forward-sexp, which is not very useful in
Rmail mode.)


A simple patch to fix this is:

ts-rhel5 [128]% ( setenv LC_ALL C ; setenv TZ UTC0 ; diff -Naur original-rmail.el rmail.el )
--- original-rmail.el   2011-02-23 23:23:08.000000000 +0000
+++ rmail.el    2011-10-20 02:51:29.845136000 +0000
@@ -1018,6 +1018,7 @@
     (define-key map "\e\C-l" 'rmail-summary-by-labels)
     (define-key map "\e\C-r" 'rmail-summary-by-recipients)
     (define-key map "\e\C-s" 'rmail-summary-by-regexp)
+    (define-key map "\e\C-f" 'rmail-summary-by-senders)
     (define-key map "\e\C-t" 'rmail-summary-by-topic)
     (define-key map "m"      'rmail-mail)
     (define-key map "\em"    'rmail-retry-failure)

- Mark
PS, rmail-summary-by-senders does not appear to be documented in the
documentation for rmail-summary-mode or rmail-mode; you may want to fix
that as well.

Message #10 received at 9802-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: mark.lillibridge <at> hp.com
Cc: 9802-done <at> debbugs.gnu.org
Subject: Re: bug#9802: 23.3;
	missing key binding for rmail-summary-by-senders in Rmail [PATCH]
Date: Thu, 27 Oct 2011 22:50:43 -0400

> You'll notice that a binding for C-M-f to rmail-summary-by-senders
> (added recently) is missing from Rmail mode.
[...]
> A simple patch to fix this is:

Thanks, installed,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.