GNU bug report logs - #9750
24.0.90; Windows binary distribution build fails with 24.0.90 Pretest

Previous Next

Full log

View this message in rfc822 format

From: Christoph Scholtes <cschol2112 <at> googlemail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Glenn Morris <rgm <at> gnu.org>, Eli Zaretskii <eliz <at> gnu.org>, 9750 <at> debbugs.gnu.org, Jason Rumney <jasonr <at> gnu.org>
Subject: bug#9750: 24.0.90; Windows binary distribution build fails with 24.0.90 Pretest
Date: Sat, 04 Feb 2012 16:23:00 -0700

On 10/18/2011 9:47 AM, Stefan Monnier wrote:
>> It seems this change was made over a year ago, but a few months later
>> make-dist was changed to explicitly exclude this file. The question mark
>> on the end of the comment seems to indicate that the author of the
>> change wasn't sure at the time if it was the right thing to do.
>
> Please just move the file to `nt', and rework the first few sentences to
> make it clear in which context it is meant to be used.

Here is a proposed change to make the intent of the README.W32 file 
clearer if it comes in the Emacs sources distribution. The change to 
make-dist includes the file again in the source tarball. The fact that 
it does not right now is a major pain when trying to automate building 
the distribution from a source tarball.

Christoph

=== modified file 'nt/README.W32'
--- nt/README.W32	2012-01-26 21:37:32 +0000
+++ nt/README.W32	2012-02-04 23:19:02 +0000
@@ -3,9 +3,15 @@

 			   Emacs for Windows

-  This README file describes how to set up and run a precompiled
-  version of GNU Emacs for Windows.  This distribution can be found on
-  the ftp.gnu.org server and its mirrors:
+  This README.W32 file describes how to set up and run a precompiled
+  version of GNU Emacs for Windows.
+
+  Please note that if you have received this file as part of the Emacs
+  source distribution see the included README file on how to compile
+  Emacs for Windows.
+
+  This distribution can be found on the ftp.gnu.org server and its
+  mirrors:

 	ftp://ftp.gnu.org/gnu/emacs/windows/


=== modified file 'make-dist'
--- make-dist	2012-01-19 07:21:25 +0000
+++ make-dist	2012-02-04 23:16:36 +0000
@@ -398,13 +398,12 @@
 (cd m4
  ln *.m4 ../${tempdir}/m4)

-## Exclude README.W32 because it is specific to pre-built binaries(?).
 echo "Making links to \`nt'"
 (cd nt
  ln emacs.manifest emacs.rc emacsclient.rc config.nt ../${tempdir}/nt
  ln emacs-src.tags nmake.defs gmake.defs subdirs.el ../${tempdir}/nt
  ln [a-z]*.bat [a-z]*.[ch] ../${tempdir}/nt
- ln ChangeLog INSTALL README makefile.w32-in ../${tempdir}/nt)
+ ln ChangeLog INSTALL README README.W32 makefile.w32-in ../${tempdir}/nt)

 echo "Making links to \`nt/inc' and its subdirectories"
 for f in `find nt/inc -type f -name '[a-z]*.h'`; do

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.