GNU bug report logs - #9750
24.0.90; Windows binary distribution build fails with 24.0.90 Pretest

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9750 in the body.
You can then email your comments to 9750 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christoph Scholtes <cschol2112 <at> googlemail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.90; Windows binary distribution build fails with 24.0.90 Pretest
Date: Thu, 13 Oct 2011 21:22:46 -0600

The automated Windows binary distribution build fails with the 24.0.90
Pretest because the `mingw32-make dist' target cannot find README.W32.

There is a comment in `make dist':
## Exclude README.W32 because it is specific to pre-built binaries(?).

I am not sure what this comment means, or why README.W32 would be
excluded from the tarball. README.W32 needs to be included in the
tarball for `mingw32-make dist' to work.


In GNU Emacs 24.0.90.1 (i386-mingw-nt6.1.7601)
 of 2011-10-13 on MARVIN
Windowing system distributor `Microsoft Corp.', version 6.1.7601
configured using `configure --with-gcc (4.6) --no-opt --cflags -I"C:/Program Files (x86)/GnuWin32/include" -ID:/devel/emacs/libXpm-3.5.8/include -ID:/devel/emacs/libXpm-3.5.8/src -ID:/devel/emacs/gnutls-2.10.5-x86/include --ldflags -LD:/devel/emacs/gnutls-2.10.5-x86/lib'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default enable-multibyte-characters: t

Major mode: Shell-script

Minor modes in effect:
  shell-dirtrack-mode: t
  my-keys-minor-mode: t
  erc-autojoin-mode: t
  erc-track-mode: t
  erc-match-mode: t
  erc-pcomplete-mode: t
  erc-stamp-mode: t
  recentf-mode: t
  desktop-save-mode: t
  autopair-mode: t
  autopair-global-mode: t
  yas/global-mode: t
  global-auto-revert-mode: t
  delete-selection-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t

Recent input:
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<down> <down> <down> <down> <down> <down> <down> <left> 
<left> <left> <left> <left> C-s C-a C-s C-s C-s <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down-mouse-1> <mouse-1> C-x k <return> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
C-v C-v C-v C-v M-v M-v M-v M-v <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> R E A D M E . W 3 2 SPC C-x C-s <down-mouse-1> 
<mouse-1> <down-mouse-1> <mouse-1> <up> <up> <up> <up> 
<up> <up> C-a C-SPC C-SPC C-n M-w C-p <down-mouse-1> 
<mouse-1> M-x r e p o r t <tab> <return>

Recent messages:
Mark saved where search started [2 times]
Saving file d:/devel/emacs/emacs-bzr/trunk/make-dist...
Wrote d:/devel/emacs/emacs-bzr/trunk/make-dist
Mark set
Mark activated
call-interactively: End of buffer [5 times]

Load-path shadows:
None found.

Features:
(shadow sort gnus-cite mail-extr gnus-msg gnus-art mm-uu mml2015
epg-config mm-view mml-smime smime dig mailcap emacsbug multi-isearch
vc-bzr sh-script executable dired-aux make-mode tramp tramp-compat
auth-source eieio password-cache shell tramp-loaddefs paredit
my-zenburn-theme erc-join erc-track erc-match erc-pcomplete erc-stamp
erc-goodies erc erc-backend erc-compat thingatpt ispell bookmark+
bookmark+-key dired-x dired bookmark+-1 nnir gnus-sum nnoo gnus-group
gnus-undo nnmail mail-source gnus-start gnus-spec gnus-int gnus-range
message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode
mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils
mailheader gnus-win gnus gnus-ems nnheader gnus-util mail-utils mm-util
mail-prsvr bookmark+-bmu help-mode view bookmark+-lit pp+ bookmark+-mac
bookmark pp recentf tree-widget wid-edit midnight desktop ibuffer
uniquify autopair google-c-style cc-styles cc-align cc-engine cc-vars
cc-defs browse-kill-ring+ browse-kill-ring second-sel ido yasnippet
dropdown-list derived edmacro kmacro assoc cl org-habit org-agenda org
byte-opt warnings bytecomp byte-compile cconv macroexp ob-emacs-lisp
ob-tangle ob-ref ob-lob ob-table org-footnote org-src ob-comint ob-keys
ob ob-eval org-pcomplete pcomplete comint ring org-list org-faces
org-compat org-entities org-macs noutline outline easy-mmode regexp-opt
cal-menu easymenu calendar cal-loaddefs org-install server advice
help-fns advice-preload debbugs-autoloads package tabulated-list
autorevert delsel time-date tooltip ediff-hook vc-hooks lisp-float-type
mwheel dos-w32 disp-table ls-lisp w32-win w32-vars tool-bar dnd fontset
image fringe lisp-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev minibuffer button faces cus-face files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process multi-tty emacs)

Message #8 received at 9750 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Christoph Scholtes <cschol2112 <at> googlemail.com>
Cc: 9750 <at> debbugs.gnu.org
Subject: Re: bug#9750: 24.0.90;
	Windows binary distribution build fails with 24.0.90 Pretest
Date: Tue, 18 Oct 2011 03:39:10 -0400

Christoph Scholtes wrote:

> The automated Windows binary distribution build fails with the 24.0.90
> Pretest because the `mingw32-make dist' target cannot find README.W32.
>
> There is a comment in `make dist':
> ## Exclude README.W32 because it is specific to pre-built binaries(?).

AIUI, README.W32 has information specific to the pre-built binaries
provided on ftp.gnu.org. Eg it starts:

  This README file describes how to set up and run a precompiled
  version of GNU Emacs for Windows.  This distribution can be found on
  the ftp.gnu.org server and its mirrors:

So it's inappropriate to include it in the source tarfile because it
contains information that is incorrect/irrelevant for people building
from source.

> README.W32 needs to be included in the
> tarball for `mingw32-make dist' to work.

But you're saying that you want to start from a source tarfile and make
a binary tarfile? I don't know how to reconcile these two.

Message #11 received at 9750 <at> debbugs.gnu.org (full text, mbox):

From: Jason Rumney <jasonr <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Christoph Scholtes <cschol2112 <at> googlemail.com>, 9750 <at> debbugs.gnu.org
Subject: Re: bug#9750: 24.0.90;
	Windows binary distribution build fails with 24.0.90 Pretest
Date: Tue, 18 Oct 2011 22:18:41 +0800

Glenn Morris <rgm <at> gnu.org> writes:

>> README.W32 needs to be included in the
>> tarball for `mingw32-make dist' to work.
>
> But you're saying that you want to start from a source tarfile and make
> a binary tarfile? I don't know how to reconcile these two.

It used to be necessary to have a checkout of the admin directory to
build Windows binaries, as the scripts that built the tarballs/zip files
were also located in the admin directory. Now that the scripts have been
converted to makefile rules, the README.W32 file is the only required
file left there, so it might make more sense to move it to the nt
subdirectory now.

Message #14 received at 9750 <at> debbugs.gnu.org (full text, mbox):

From: Jason Rumney <jasonr <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Christoph Scholtes <cschol2112 <at> googlemail.com>, 9750 <at> debbugs.gnu.org
Subject: Re: bug#9750: 24.0.90;
	Windows binary distribution build fails with 24.0.90 Pretest
Date: Tue, 18 Oct 2011 22:34:20 +0800

Jason Rumney <jasonr <at> gnu.org> writes:

> Glenn Morris <rgm <at> gnu.org> writes:
>
>>> README.W32 needs to be included in the
>>> tarball for `mingw32-make dist' to work.
>>
>> But you're saying that you want to start from a source tarfile and make
>> a binary tarfile? I don't know how to reconcile these two.
>
> It used to be necessary to have a checkout of the admin directory to
> build Windows binaries, as the scripts that built the tarballs/zip files
> were also located in the admin directory. Now that the scripts have been
> converted to makefile rules, the README.W32 file is the only required
> file left there, so it might make more sense to move it to the nt
> subdirectory now.

It seems this change was made over a year ago, but a few months later
make-dist was changed to explicitly exclude this file. The question mark
on the end of the comment seems to indicate that the author of the
change wasn't sure at the time if it was the right thing to do.

Message #17 received at 9750 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Jason Rumney <jasonr <at> gnu.org>
Cc: Christoph Scholtes <cschol2112 <at> googlemail.com>, Glenn Morris <rgm <at> gnu.org>,
	9750 <at> debbugs.gnu.org
Subject: Re: bug#9750: 24.0.90;
	Windows binary distribution build fails with 24.0.90 Pretest
Date: Tue, 18 Oct 2011 11:47:07 -0400

> It seems this change was made over a year ago, but a few months later
> make-dist was changed to explicitly exclude this file. The question mark
> on the end of the comment seems to indicate that the author of the
> change wasn't sure at the time if it was the right thing to do.

Please just move the file to `nt', and rework the first few sentences to
make it clear in which context it is meant to be used.


        Stefan

Message #20 received at 9750 <at> debbugs.gnu.org (full text, mbox):

From: Christoph Scholtes <cschol2112 <at> googlemail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 9750 <at> debbugs.gnu.org
Subject: Re: bug#9750: 24.0.90; Windows binary distribution build fails with
	24.0.90 Pretest
Date: Tue, 18 Oct 2011 19:01:58 -0600

On 10/18/2011 1:39 AM, Glenn Morris wrote:

> AIUI, README.W32 has information specific to the pre-built binaries
> provided on ftp.gnu.org. Eg it starts:
>
>    This README file describes how to set up and run a precompiled
>    version of GNU Emacs for Windows.  This distribution can be found on
>    the ftp.gnu.org server and its mirrors:
>
> So it's inappropriate to include it in the source tarfile because it
> contains information that is incorrect/irrelevant for people building
> from source.

For people building on GNU/Linux maybe, but since the Windows binary 
distributions are built from the source tarball, it is very much 
relevant (for some users).

> But you're saying that you want to start from a source tarfile and make
> a binary tarfile? I don't know how to reconcile these two.

Yes, start from a source tarfile and make a binary zipfile using the 
`mingw32-make dist' target I wrote for Windows. (As a side note, I 
probably should change the name of the target to `dist-w32' or 
`bin-dist' to not confuse it with `make-dist'). The target is mainly 
used by Sean to build the weekly builds and should also be used to 
consistently build the Windows Emacs releases in an automated fashion 
from the source tarballs.

Christoph

Message #23 received at 9750 <at> debbugs.gnu.org (full text, mbox):

From: Christoph Scholtes <cschol2112 <at> googlemail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Glenn Morris <rgm <at> gnu.org>, 9750 <at> debbugs.gnu.org,
	Jason Rumney <jasonr <at> gnu.org>
Subject: Re: bug#9750: 24.0.90; Windows binary distribution build fails with
	24.0.90 Pretest
Date: Tue, 18 Oct 2011 19:15:23 -0600

On 10/18/2011 9:47 AM, Stefan Monnier wrote:
>> It seems this change was made over a year ago, but a few months later
>> make-dist was changed to explicitly exclude this file. The question mark
>> on the end of the comment seems to indicate that the author of the
>> change wasn't sure at the time if it was the right thing to do.
>
> Please just move the file to `nt', and rework the first few sentences to
> make it clear in which context it is meant to be used.

It was already moved to `nt' as part of the `dist' rule I added 
(r100882). It just needs to be linked in `make-dist' to be included in 
the source tarball.

I am not sure how to change README.W32 to reflect its use case though.

Message #26 received at 9750 <at> debbugs.gnu.org (full text, mbox):

From: Christoph Scholtes <cschol2112 <at> googlemail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Glenn Morris <rgm <at> gnu.org>, Eli Zaretskii <eliz <at> gnu.org>,
	9750 <at> debbugs.gnu.org, Jason Rumney <jasonr <at> gnu.org>
Subject: Re: bug#9750: 24.0.90; Windows binary distribution build fails with
	24.0.90 Pretest
Date: Sat, 04 Feb 2012 16:23:00 -0700

On 10/18/2011 9:47 AM, Stefan Monnier wrote:
>> It seems this change was made over a year ago, but a few months later
>> make-dist was changed to explicitly exclude this file. The question mark
>> on the end of the comment seems to indicate that the author of the
>> change wasn't sure at the time if it was the right thing to do.
>
> Please just move the file to `nt', and rework the first few sentences to
> make it clear in which context it is meant to be used.

Here is a proposed change to make the intent of the README.W32 file 
clearer if it comes in the Emacs sources distribution. The change to 
make-dist includes the file again in the source tarball. The fact that 
it does not right now is a major pain when trying to automate building 
the distribution from a source tarball.

Christoph

=== modified file 'nt/README.W32'
--- nt/README.W32	2012-01-26 21:37:32 +0000
+++ nt/README.W32	2012-02-04 23:19:02 +0000
@@ -3,9 +3,15 @@

 			   Emacs for Windows

-  This README file describes how to set up and run a precompiled
-  version of GNU Emacs for Windows.  This distribution can be found on
-  the ftp.gnu.org server and its mirrors:
+  This README.W32 file describes how to set up and run a precompiled
+  version of GNU Emacs for Windows.
+
+  Please note that if you have received this file as part of the Emacs
+  source distribution see the included README file on how to compile
+  Emacs for Windows.
+
+  This distribution can be found on the ftp.gnu.org server and its
+  mirrors:

 	ftp://ftp.gnu.org/gnu/emacs/windows/


=== modified file 'make-dist'
--- make-dist	2012-01-19 07:21:25 +0000
+++ make-dist	2012-02-04 23:16:36 +0000
@@ -398,13 +398,12 @@
 (cd m4
  ln *.m4 ../${tempdir}/m4)

-## Exclude README.W32 because it is specific to pre-built binaries(?).
 echo "Making links to \`nt'"
 (cd nt
  ln emacs.manifest emacs.rc emacsclient.rc config.nt ../${tempdir}/nt
  ln emacs-src.tags nmake.defs gmake.defs subdirs.el ../${tempdir}/nt
  ln [a-z]*.bat [a-z]*.[ch] ../${tempdir}/nt
- ln ChangeLog INSTALL README makefile.w32-in ../${tempdir}/nt)
+ ln ChangeLog INSTALL README README.W32 makefile.w32-in ../${tempdir}/nt)

 echo "Making links to \`nt/inc' and its subdirectories"
 for f in `find nt/inc -type f -name '[a-z]*.h'`; do

Message #29 received at 9750 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Christoph Scholtes <cschol2112 <at> googlemail.com>
Cc: rgm <at> gnu.org, 9750 <at> debbugs.gnu.org, monnier <at> IRO.UMontreal.CA, jasonr <at> gnu.org
Subject: Re: bug#9750: 24.0.90;
	Windows binary distribution build fails with 24.0.90 Pretest
Date: Sun, 05 Feb 2012 18:45:42 +0200

> Date: Sat, 04 Feb 2012 16:23:00 -0700
> From: Christoph Scholtes <cschol2112 <at> googlemail.com>
> CC: Jason Rumney <jasonr <at> gnu.org>, Glenn Morris <rgm <at> gnu.org>, 
>  9750 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
> 
>   			   Emacs for Windows
> 
> -  This README file describes how to set up and run a precompiled
> -  version of GNU Emacs for Windows.  This distribution can be found on
> -  the ftp.gnu.org server and its mirrors:
> +  This README.W32 file describes how to set up and run a precompiled
> +  version of GNU Emacs for Windows.
> +
> +  Please note that if you have received this file as part of the Emacs
> +  source distribution see the included README file on how to compile
> +  Emacs for Windows.

Suggest a minor rewording and reordering:

  This README.W32 file describes how to set up and run a precompiled
  distribution of GNU Emacs for Windows.  You can find the precompiled
  distribution on the ftp.gnu.org server and its mirrors:

   	ftp://ftp.gnu.org/gnu/emacs/windows/

  Information on how to compile Emacs from sources on Windows is in
  the files README and INSTALL in this directory.  If you received
  this file as part of the Emacs source distribution, please read
  those 2 files and not this one.

Message #32 received at 9750 <at> debbugs.gnu.org (full text, mbox):

From: Christoph Scholtes <cschol2112 <at> googlemail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rgm <at> gnu.org, 9750 <at> debbugs.gnu.org, monnier <at> IRO.UMontreal.CA, jasonr <at> gnu.org
Subject: Re: bug#9750: 24.0.90;
	Windows binary distribution build fails with 24.0.90 Pretest
Date: Sun, 05 Feb 2012 11:18:55 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

> Suggest a minor rewording and reordering:
>
>   This README.W32 file describes how to set up and run a precompiled
>   distribution of GNU Emacs for Windows.  You can find the precompiled
>   distribution on the ftp.gnu.org server and its mirrors:
>
>    	ftp://ftp.gnu.org/gnu/emacs/windows/
>
>   Information on how to compile Emacs from sources on Windows is in
>   the files README and INSTALL in this directory.  If you received
>   this file as part of the Emacs source distribution, please read
>   those 2 files and not this one.

Thanks. I will incorporate this.

Message #37 received at 9750-done <at> debbugs.gnu.org (full text, mbox):

From: Christoph Scholtes <cschol2112 <at> googlemail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rgm <at> gnu.org, 9750-done <at> debbugs.gnu.org, monnier <at> IRO.UMontreal.CA,
	jasonr <at> gnu.org
Subject: Re: bug#9750: 24.0.90;
	Windows binary distribution build fails with 24.0.90 Pretest
Date: Sun, 05 Feb 2012 14:01:21 -0700

Fixed in Emacs trunk r107123.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.