GNU bug report logs - #9714
[PATCH] maint: remove vestigial de-ANSI-fication support

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Subject: bug#9714: closed (Re: bug#9714: [PATCH] maint: remove vestigial
 de-ANSI-fication support)
Date: Mon, 10 Oct 2011 12:59:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#9714: [PATCH] maint: remove vestigial de-ANSI-fication support

which was filed against the coreutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 9714 <at> debbugs.gnu.org.

-- 
9714: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9714
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 9714-done <at> debbugs.gnu.org
Subject: Re: bug#9714: [PATCH] maint: remove vestigial de-ANSI-fication support
Date: Mon, 10 Oct 2011 14:58:10 +0200

Stefano Lattarini wrote:
> The support for automatic de-ANSI-fication has been deprecated in
> automake 1.11.2, and will be removed altogether in automake 1.12.
> Also, coreutils does not use the `ansi2knr' option since at least
> 2003-03-14 (commit b9fa45f2b01d0e395b7ddd845ebabb9528cf3f12 "remove
> ansi2knr junk", and a few preceding commits).
>
> * /m4/jm-macros.m4 (gl_CHECK_ALL_TYPES): Don't require
> `AM_C_PROTOTYPES' anymore.  This is required to avoid a (mostly
> spurious) warning from automake.
> ---
>  m4/jm-macros.m4 |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/m4/jm-macros.m4 b/m4/jm-macros.m4
> index 58b000d..40ff3e1 100644
> --- a/m4/jm-macros.m4
> +++ b/m4/jm-macros.m4
> @@ -193,11 +193,6 @@ AC_DEFUN([gl_CHECK_ALL_HEADERS],
>  # This macro must be invoked before any tests that run the compiler.
>  AC_DEFUN([gl_CHECK_ALL_TYPES],
>  [
> -  dnl This test must precede tests of compiler characteristics like
> -  dnl that for the inline keyword, since it may change the degree to
> -  dnl which the compiler supports such features.
> -  AC_REQUIRE([AM_C_PROTOTYPES])

Thanks.
I did that a week or so ago:

  http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=88873501cff9ed9

[Message part 3 (message/rfc822, inline)]

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: bug-coreutils <at> gnu.org
Cc: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Subject: [PATCH] maint: remove vestigial de-ANSI-fication support
Date: Mon, 10 Oct 2011 14:38:34 +0200

The support for automatic de-ANSI-fication has been deprecated in
automake 1.11.2, and will be removed altogether in automake 1.12.
Also, coreutils does not use the `ansi2knr' option since at least
2003-03-14 (commit b9fa45f2b01d0e395b7ddd845ebabb9528cf3f12 "remove
ansi2knr junk", and a few preceding commits).

* /m4/jm-macros.m4 (gl_CHECK_ALL_TYPES): Don't require
`AM_C_PROTOTYPES' anymore.  This is required to avoid a (mostly
spurious) warning from automake.
---
 m4/jm-macros.m4 |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/m4/jm-macros.m4 b/m4/jm-macros.m4
index 58b000d..40ff3e1 100644
--- a/m4/jm-macros.m4
+++ b/m4/jm-macros.m4
@@ -193,11 +193,6 @@ AC_DEFUN([gl_CHECK_ALL_HEADERS],
 # This macro must be invoked before any tests that run the compiler.
 AC_DEFUN([gl_CHECK_ALL_TYPES],
 [
-  dnl This test must precede tests of compiler characteristics like
-  dnl that for the inline keyword, since it may change the degree to
-  dnl which the compiler supports such features.
-  AC_REQUIRE([AM_C_PROTOTYPES])
-
   dnl Checks for typedefs, structures, and compiler characteristics.
   AC_REQUIRE([gl_BIGENDIAN])
   AC_REQUIRE([AC_C_VOLATILE])
-- 
1.7.2.3

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.