GNU bug report logs - #9714
[PATCH] maint: remove vestigial de-ANSI-fication support

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 9714 in the body.
You can then email your comments to 9714 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: bug-coreutils <at> gnu.org
Cc: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Subject: [PATCH] maint: remove vestigial de-ANSI-fication support
Date: Mon, 10 Oct 2011 14:38:34 +0200

The support for automatic de-ANSI-fication has been deprecated in
automake 1.11.2, and will be removed altogether in automake 1.12.
Also, coreutils does not use the `ansi2knr' option since at least
2003-03-14 (commit b9fa45f2b01d0e395b7ddd845ebabb9528cf3f12 "remove
ansi2knr junk", and a few preceding commits).

* /m4/jm-macros.m4 (gl_CHECK_ALL_TYPES): Don't require
`AM_C_PROTOTYPES' anymore.  This is required to avoid a (mostly
spurious) warning from automake.
---
 m4/jm-macros.m4 |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/m4/jm-macros.m4 b/m4/jm-macros.m4
index 58b000d..40ff3e1 100644
--- a/m4/jm-macros.m4
+++ b/m4/jm-macros.m4
@@ -193,11 +193,6 @@ AC_DEFUN([gl_CHECK_ALL_HEADERS],
 # This macro must be invoked before any tests that run the compiler.
 AC_DEFUN([gl_CHECK_ALL_TYPES],
 [
-  dnl This test must precede tests of compiler characteristics like
-  dnl that for the inline keyword, since it may change the degree to
-  dnl which the compiler supports such features.
-  AC_REQUIRE([AM_C_PROTOTYPES])
-
   dnl Checks for typedefs, structures, and compiler characteristics.
   AC_REQUIRE([gl_BIGENDIAN])
   AC_REQUIRE([AC_C_VOLATILE])
-- 
1.7.2.3

Message #10 received at 9714-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 9714-done <at> debbugs.gnu.org
Subject: Re: bug#9714: [PATCH] maint: remove vestigial de-ANSI-fication support
Date: Mon, 10 Oct 2011 14:58:10 +0200

Stefano Lattarini wrote:
> The support for automatic de-ANSI-fication has been deprecated in
> automake 1.11.2, and will be removed altogether in automake 1.12.
> Also, coreutils does not use the `ansi2knr' option since at least
> 2003-03-14 (commit b9fa45f2b01d0e395b7ddd845ebabb9528cf3f12 "remove
> ansi2knr junk", and a few preceding commits).
>
> * /m4/jm-macros.m4 (gl_CHECK_ALL_TYPES): Don't require
> `AM_C_PROTOTYPES' anymore.  This is required to avoid a (mostly
> spurious) warning from automake.
> ---
>  m4/jm-macros.m4 |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/m4/jm-macros.m4 b/m4/jm-macros.m4
> index 58b000d..40ff3e1 100644
> --- a/m4/jm-macros.m4
> +++ b/m4/jm-macros.m4
> @@ -193,11 +193,6 @@ AC_DEFUN([gl_CHECK_ALL_HEADERS],
>  # This macro must be invoked before any tests that run the compiler.
>  AC_DEFUN([gl_CHECK_ALL_TYPES],
>  [
> -  dnl This test must precede tests of compiler characteristics like
> -  dnl that for the inline keyword, since it may change the degree to
> -  dnl which the compiler supports such features.
> -  AC_REQUIRE([AM_C_PROTOTYPES])

Thanks.
I did that a week or so ago:

  http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=88873501cff9ed9

Message #11 received at 9714-done <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 9714-done <at> debbugs.gnu.org
Subject: Re: bug#9714: [PATCH] maint: remove vestigial de-ANSI-fication support
Date: Mon, 10 Oct 2011 15:20:29 +0200

On Monday 10 October 2011, Jim Meyering wrote:
> Stefano Lattarini wrote:
> > The support for automatic de-ANSI-fication has been deprecated in
> > automake 1.11.2, and will be removed altogether in automake 1.12.
> > Also, coreutils does not use the `ansi2knr' option since at least
> > 2003-03-14 (commit b9fa45f2b01d0e395b7ddd845ebabb9528cf3f12 "remove
> > ansi2knr junk", and a few preceding commits).
>
> Thanks.
> I did that a week or so ago:
> 
>   http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=88873501cff9ed9
>
So I had just forgot to pull, hmpf :-(

Sorry for the noise, and thanks,
  Stefano 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.