GNU bug report logs - #917
Too heavy consing in MULE file saving?

Previous Next

Package: emacs;

Reported by: rms <at> gnu.org

Date: Sun, 7 Sep 2008 17:50:03 UTC

Severity: normal

Merged with 960, 961

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 917 in the body.
You can then email your comments to 917 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#917; Package emacs. Full text and rfc822 format available.

Acknowledgement sent to rms <at> gnu.org:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Richard M. Stallman" <rms <at> gnu.org>
To: emacs-pretest-bug <at> gnu.org
Subject: Too heavy consing in MULE file saving?
Date: Sun, 07 Sep 2008 13:40:00 -0400
I have gc-cons-threshold at 400000, which is the default.
In Rmail, if I type d u C-x C-s, it causes a GC at the end
of saving.  I can do this over and over and it GCs every time.

I think this indicates a bug; namely, that something is doing too much
consing.

My Rmail file is around 10 meg, and has 471 messages.
But I don't see why that should matter for C-x C-s.

Just to explore, I visited another 10meg file in Fundamental mode
and got the same behavior.  I went to the end and type 1 DEL C-x C-s.
It gc's each time.

Then I tried visiting it with find-file-literally.
That way, I could type 1 DEL C-x C-s and it would save without gc.

So I think something concerned with Mule is doing too much consing.




Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#917; Package emacs. Full text and rfc822 format available.

Acknowledgement sent to Eli Zaretskii <eliz <at> gnu.org>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text and rfc822 format available.

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: rms <at> gnu.org, 917 <at> debbugs.gnu.org
Cc: emacs-pretest-bug <at> gnu.org
Subject: Re: bug#917: Too heavy consing in MULE file saving?
Date: Sun, 07 Sep 2008 22:01:14 +0300
> From: "Richard M. Stallman" <rms <at> gnu.org>
> Date: Sun, 07 Sep 2008 13:40:00 -0400
> Cc: 
> 
> My Rmail file is around 10 meg, and has 471 messages.
> But I don't see why that should matter for C-x C-s.
> 
> Just to explore, I visited another 10meg file in Fundamental mode
> and got the same behavior.  I went to the end and type 1 DEL C-x C-s.
> It gc's each time.
> 
> Then I tried visiting it with find-file-literally.
> That way, I could type 1 DEL C-x C-s and it would save without gc.
> 
> So I think something concerned with Mule is doing too much consing.

I'm not surprised: saving a file visited non-literally causes its
contents to be encoded, which generally means we wipe out the text and
replace it with its encoded representation.  That this conses _a_lot_,
especially for large files, does not come as a surprise to me.
Perhaps I'm missing something, though.




Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#917; Package emacs. Full text and rfc822 format available.

Acknowledgement sent to Eli Zaretskii <eliz <at> gnu.org>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text and rfc822 format available.

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#917; Package emacs. Full text and rfc822 format available.

Acknowledgement sent to rms <at> gnu.org:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text and rfc822 format available.

Message #20 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Richard M. Stallman" <rms <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>, 917 <at> debbugs.gnu.org
Cc: 917 <at> debbugs.gnu.org, bug-submit-list <at> donarmstrong.com,
        emacs-pretest-bug <at> gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#917: Too heavy consing in MULE file saving?
Date: Mon, 08 Sep 2008 05:22:27 -0400
    I'm not surprised: saving a file visited non-literally causes its
    contents to be encoded, which generally means we wipe out the text and
    replace it with its encoded representation.  That this conses _a_lot_,
    especially for large files, does not come as a surprise to me.

It seems to be a recent change, so I think it is worth investigating
whether something just increased the amount of consing done by encoding.
It would be worth optimizing this.






Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#917; Package emacs. Full text and rfc822 format available.

Acknowledgement sent to rms <at> gnu.org:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text and rfc822 format available.

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#917; Package emacs. Full text and rfc822 format available.

Acknowledgement sent to rms <at> gnu.org:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text and rfc822 format available.

Merged 917 960 961. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> emacsbugs.donarmstrong.com. (Thu, 11 Sep 2008 16:15:04 GMT) Full text and rfc822 format available.

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#917; Package emacs. (Sat, 11 Apr 2009 07:55:04 GMT) Full text and rfc822 format available.

Message #35 received at control <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: control <at> debbugs.gnu.org
Subject: close 1382
Date: Thu, 24 Jun 2010 14:23:29 -0400
severity 135 minor
tags 710 + moreinfo unreproducible
close 756
tags 844 + moreinfo unreproducible
close 917
close 1000
tags 1125 + moreinfo unreproducible
close 1159
severity 1238 wishlist
close 1247
close 1381
close 1382
tags 1708 + moreinfo unreproducible
close 1993
severity 2024 wishlist
close 2236
severity 2299 wishlist
tags 2394 + moreinfo unreproducible
severity 2507 minor
close 2583
tags 2690 + moreinfo unreproducible
tags 2812 + moreinfo unreproducible
tags 2843 + moreinfo unreproducible
tags 2870 + moreinfo unreproducible
tags 2877 + moreinfo unreproducible
close 3032
close 3273
close 3349
close 4046
close 4358
close 4591
close 4656
thanks




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 23 Jul 2010 11:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 14 years and 333 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.