GNU bug report logs - #8785
24.0.50; progress-reporter shows percentage with no space

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#8785: closed (24.0.50; progress-reporter shows percentage
 with no space)
Date: Thu, 02 Jun 2011 14:35:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 02 Jun 2011 11:34:47 -0300
with message-id <jwv62oogv5k.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#8785: 24.0.50; progress-reporter shows percentage with no space
has caused the GNU bug report #8785,
regarding 24.0.50; progress-reporter shows percentage with no space
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
8785: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8785
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; progress-reporter shows percentage with no space
Date: Thu, 02 Jun 2011 19:36:48 +0900

When I send a big mail using smtpmail, I get:

Sending email
Sending email12%
Sending email85%
Sending email87%
Sending email90%
Sending email92%
Sending email95%
Sending email97%
Sending emaildone

SPC is needed between text and percentage, I think.  Is what
should be fixed `progress-reporter-do-update', or should every
program that uses `make-progress-reporter' add SPC to the first
argument?

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 8785-done <at> debbugs.gnu.org
Subject: Re: bug#8785: 24.0.50;
	progress-reporter shows percentage with no space
Date: Thu, 02 Jun 2011 11:34:47 -0300

>> should be fixed `progress-reporter-do-update', or should every
>> program that uses `make-progress-reporter' add SPC to the first
>> argument?

> I'd tend to say "better fix it in make-progress-reporter", but it might
> be too late to change it.

I felt optimistic, so I'm going to install the patch below (as soon as
bzr.sv.gnu.org comes back to life),


        Stefan


=== modified file 'lisp/subr.el'
--- lisp/subr.el	2011-06-01 14:19:45 +0000
+++ lisp/subr.el	2011-06-02 14:31:56 +0000
@@ -3702,6 +3702,8 @@
 `float-time' is not present, time is not tracked at all.  If the
 OS is not capable of measuring fractions of seconds, this
 parameter is effectively rounded up."
+  (when (string-match "[[:alnum:]]\\'" message)
+    (setq message (concat message "...")))
   (unless min-time
     (setq min-time 0.2))
   (let ((reporter

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.