GNU bug report logs - #8785
24.0.50; progress-reporter shows percentage with no space

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8785 in the body.
You can then email your comments to 8785 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; progress-reporter shows percentage with no space
Date: Thu, 02 Jun 2011 19:36:48 +0900

When I send a big mail using smtpmail, I get:

Sending email
Sending email12%
Sending email85%
Sending email87%
Sending email90%
Sending email92%
Sending email95%
Sending email97%
Sending emaildone

SPC is needed between text and percentage, I think.  Is what
should be fixed `progress-reporter-do-update', or should every
program that uses `make-progress-reporter' add SPC to the first
argument?

Message #8 received at 8785 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 8785 <at> debbugs.gnu.org
Subject: Re: bug#8785: 24.0.50;
	progress-reporter shows percentage with no space
Date: Thu, 02 Jun 2011 09:38:15 -0300

> When I send a big mail using smtpmail, I get:
> Sending email
> Sending email12%
> Sending email85%
> Sending email87%
> Sending email90%
> Sending email92%
> Sending email95%
> Sending email97%
> Sending emaildone

> SPC is needed between text and percentage, I think.  Is what

Actually it's a " ... " that's missing.

> should be fixed `progress-reporter-do-update', or should every
> program that uses `make-progress-reporter' add SPC to the first
> argument?

I'd tend to say "better fix it in make-progress-reporter", but it might
be too late to change it.


        Stefan

Message #13 received at 8785-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 8785-done <at> debbugs.gnu.org
Subject: Re: bug#8785: 24.0.50;
	progress-reporter shows percentage with no space
Date: Thu, 02 Jun 2011 11:34:47 -0300

>> should be fixed `progress-reporter-do-update', or should every
>> program that uses `make-progress-reporter' add SPC to the first
>> argument?

> I'd tend to say "better fix it in make-progress-reporter", but it might
> be too late to change it.

I felt optimistic, so I'm going to install the patch below (as soon as
bzr.sv.gnu.org comes back to life),


        Stefan


=== modified file 'lisp/subr.el'
--- lisp/subr.el	2011-06-01 14:19:45 +0000
+++ lisp/subr.el	2011-06-02 14:31:56 +0000
@@ -3702,6 +3702,8 @@
 `float-time' is not present, time is not tracked at all.  If the
 OS is not capable of measuring fractions of seconds, this
 parameter is effectively rounded up."
+  (when (string-match "[[:alnum:]]\\'" message)
+    (setq message (concat message "...")))
   (unless min-time
     (setq min-time 0.2))
   (let ((reporter

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.