GNU bug report logs - #8753
unable to build VALA project out-of-tree

Previous Next

Full log

Message #31 received at 8753 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Ryan Lortie <desrt <at> desrt.ca>
Cc: 8753 <at> debbugs.gnu.org, automake-patches <at> gnu.org
Subject: Re: bug#8753: unable to build VALA project out-of-tree
Date: Sun, 08 Jan 2012 12:54:58 +0100

[Message part 1 (text/plain, inline)]

On 01/07/2012 07:21 AM, Ryan Lortie wrote:
> hi,
>
Hi Ryan, and thanks for the patches.

> Here are a pair of patches that should fix this issue.
>
I must admit I dont' like very much the idea of having the stamp file created
in the $(srcdir) ...  but I see that the .c files generated by Vala are already
being placed in the $(srcdir) -- so you are just following the existing trend,
and you changes are a definite improvement over the existing broken situation.
So I think they are definitely good to apply.

I've edited your patches a bit to fix a couple of minor blunders and to
improve conformance to the GNU Coding Standards; since I was at it, I've
thrown in (into the second patch) an additional fix for another pre-existing
VPATH-related bug.  I've also added a tiny new patch to fix an independent
testsuite weakness (missing requirement of GNU make in vala-vpath.test).

Attached is what I'll pushed to maint in 72 hours, if there is no objection.

Thanks again for tackling this issue!

Best regards,
  Stefano

[0001-tests-fix-some-bugs-in-the-vala-vpath-test.patch (text/x-diff, attachment)]

[0002-vala-fix-VPATH-builds.patch (text/x-diff, attachment)]

[0003-tests-require-GNU-make-in-vala-vapth.test.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.