GNU bug report logs - #8753
unable to build VALA project out-of-tree

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8753 in the body.
You can then email your comments to 8753 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zbigniew Jędrzejewski-Szmek <zbyszek <at> in.waw.pl>
To: bug-automake <at> gnu.org
Subject: unable to build VALA project out-of-tree
Date: Sat, 28 May 2011 01:08:30 +0300

Automake generates rules for VALA files which try to create C output
in the source directory. This is pretty strange, but anyway the
build doesn't succeed even if the source directory is writable.

quoting Andrey Borzenkov in http://lists.gnu.org/archive/html/automake/2010-11/msg00036.html:

-------------------------------------------------------------------
I'm trying to rebuild systemd
(http://www.freedesktop.org/wiki/Software/systemd) from GIT. It is
using several programs built using vala; in-tree build is OK,
out-of-tree build fails:

{pts/0}% LC_ALL=C make
make  all-am
make[1]: Entering directory `/home/bor/build/systemd'
make[1]: *** No rule to make target
`/home/bor/src/systemd/systemadm_vala.stamp', needed by
`/home/bor/src/systemd/src/systemadm.c'.  Stop.
make[1]: Leaving directory `/home/bor/build/systemd'
make: *** [all] Error 2

Looking at Makefile.in, generated by automake, I cannot understand how
it is supposed to work:

$(srcdir)/src/systemadm.c: $(srcdir)/systemadm_vala.stamp
        @if test -f $@; then :; else \
          rm -f $(srcdir)/systemadm_vala.stamp; \
          $(am__cd) $(srcdir) && $(MAKE) $(AM_MAKEFLAGS) systemadm_vala.stamp; \
        fi
systemadm_vala.stamp: $(systemadm_SOURCES)
        $(AM_V_VALAC)$(VALAC) $(systemadm_VALAFLAGS) $(VALAFLAGS) -C
$(systemadm_SOURCES)
        $(AM_V_at)touch $@

In out-of-tree build $(srcdir)/systemadm_vala.stamp is not the same as
systemadm_vala.stamp, nor can it be. VPATH search does not apply here,
because path does not yet exist; so when it is rebuilt, file name is
used verbatim.
-------------------------------------------------------------------

Andrey didn't get a definite reply, but the problem seems to be still present.

Zbyszek

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: bug-automake <at> gnu.org
Cc: Zbigniew Jędrzejewski-Szmek <zbyszek <at> in.waw.pl>,
	8753 <at> debbugs.gnu.org
Subject: Re: bug#8753: unable to build VALA project out-of-tree
Date: Thu, 1 Sep 2011 21:35:07 +0200

[Message part 1 (text/plain, inline)]

Hi Zbigniew, sorry for the shameful delay.

On Saturday 28 May 2011, Zbigniew Jędrzejewski-Szmek wrote:
> Automake generates rules for VALA files which try to create C output
> in the source directory. This is pretty strange, but anyway the
> build doesn't succeed even if the source directory is writable.
> 
> quoting Andrey Borzenkov in http://lists.gnu.org/archive/html/automake/2010-11/msg00036.html:
> 
> -------------------------------------------------------------------
> I'm trying to rebuild systemd
> (http://www.freedesktop.org/wiki/Software/systemd) from GIT. It is
> using several programs built using vala; in-tree build is OK,
> out-of-tree build fails:
> 
> {pts/0}% LC_ALL=C make
> make  all-am
> make[1]: Entering directory `/home/bor/build/systemd'
> make[1]: *** No rule to make target
> `/home/bor/src/systemd/systemadm_vala.stamp', needed by
> `/home/bor/src/systemd/src/systemadm.c'.  Stop.
> make[1]: Leaving directory `/home/bor/build/systemd'
> make: *** [all] Error 2
> 
> Looking at Makefile.in, generated by automake, I cannot understand how
> it is supposed to work:
> 
> $(srcdir)/src/systemadm.c: $(srcdir)/systemadm_vala.stamp
>         @if test -f $@; then :; else \
>           rm -f $(srcdir)/systemadm_vala.stamp; \
>           $(am__cd) $(srcdir) && $(MAKE) $(AM_MAKEFLAGS) systemadm_vala.stamp; \
>         fi
> systemadm_vala.stamp: $(systemadm_SOURCES)
>         $(AM_V_VALAC)$(VALAC) $(systemadm_VALAFLAGS) $(VALAFLAGS) -C
> $(systemadm_SOURCES)
>         $(AM_V_at)touch $@
> 
> In out-of-tree build $(srcdir)/systemadm_vala.stamp is not the same as
> systemadm_vala.stamp, nor can it be. VPATH search does not apply here,
> because path does not yet exist; so when it is rebuilt, file name is
> used verbatim.
> -------------------------------------------------------------------
> 
> Andrey didn't get a definite reply, but the problem seems to be still present.
> 
> Zbyszek
> 
> 
I'm quite ignorant about vala and also its support in automake, but I do
think that VPATH builds are not really supported for vala.

Anyway, it would be nice to at least expose the problem in the Automake
testsuite, even if only as an XFAIL; do you have a minimal use case
exposing the issue?

Regards,
  Stefano

[Message part 2 (text/html, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zbigniew Jędrzejewski-Szmek <zbyszek <at> in.waw.pl>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: bug-automake <at> gnu.org, 8753 <at> debbugs.gnu.org
Subject: Re: bug#8753: unable to build VALA project out-of-tree
Date: Fri, 02 Sep 2011 02:40:17 +0200

[Message part 1 (text/plain, inline)]

On 09/01/2011 09:35 PM, Stefano Lattarini wrote:
> Hi Zbigniew, sorry for the shameful delay.
No problem. Autotools are great anyway :)

> I'm quite ignorant about vala and also its support in automake,
I think that the support is in general adequate -- systemd uses vala and 
in general things get build like they are supposed too.

> but I do
> think that VPATH builds are not really supported for vala.
So it seems.

> Anyway, it would be nice to at least expose the problem in the Automake
> testsuite, even if only as an XFAIL; do you have a minimal use case
> exposing the issue?
I've taken the hello world example from vala tutorial and wrapped it with
Makefile.am and configure.ac.

It builds fine locally, and fails when build from an external directory:

/tmp/build % ~/src/vala_autotools_test/configure
...
/tmp/build % make
make: *** No rule to make target 
`/home/zbyszek/src/vala_autotools_test/hello_vala.stamp', needed by 
`/home/zbyszek/src/vala_autotools_test/src/hello.c'.  Stop.

The example is attached. Three files: configure.ac and Makefile.am go in 
the root directory of the source tree, hello.vala goes into src/.

Zbyszek

[configure.ac (text/plain, attachment)]

[Makefile.am (text/plain, attachment)]

[hello.vala (text/plain, attachment)]

Message #20 received at 8753 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: "Zbigniew Jędrzejewski-Szmek" <zbyszek <at> in.waw.pl>,
	8753 <at> debbugs.gnu.org
Cc: automake-patches <at> gnu.org
Subject: Re: bug#8753: unable to build VALA project out-of-tree
Date: Fri, 2 Sep 2011 10:03:22 +0200

[Message part 1 (text/plain, inline)]

On Friday 02 September 2011, Zbigniew Jędrzejewski wrote:
> On 09/01/2011 09:35 PM, Stefano Lattarini wrote:
> > Hi Zbigniew, sorry for the shameful delay.
> No problem. Autotools are great anyway :)
>
Glad to hear that :-)

> > I'm quite ignorant about vala and also its support in automake,
> I think that the support is in general adequate -- systemd uses vala and 
> in general things get build like they are supposed too.
>
Again, glad to hear that.

> > but I do
> > think that VPATH builds are not really supported for vala.
> So it seems.
>
I mean, they are supported for distributed tarball (and this is checked in
the automake testsuite), but not for from-scratch builds, like e.g. from a
fresh git checkout.

> > Anyway, it would be nice to at least expose the problem in the Automake
> > testsuite, even if only as an XFAIL; do you have a minimal use case
> > exposing the issue?
> I've taken the hello world example from vala tutorial and wrapped it with
> Makefile.am and configure.ac.
> 
> It builds fine locally, and fails when build from an external directory:
> 
> /tmp/build % ~/src/vala_autotools_test/configure
> ...
> /tmp/build % make
> make: *** No rule to make target 
> `/home/zbyszek/src/vala_autotools_test/hello_vala.stamp', needed by 
> `/home/zbyszek/src/vala_autotools_test/src/hello.c'.  Stop.
> 
> The example is attached. Three files: configure.ac and Makefile.am go in 
> the root directory of the source tree, hello.vala goes into src/.
>
Thanks; I can reproduce the error, and I've managed to reduce your minimal
test case even more.  I've applied the attached patch to the 'maint' branch
in the automake repository.  The bug report remains open though, since for
closing it we should either fix the limitation or at least document it.

> Zbyszek
> 

Thanks,
  Stefano

[Message part 2 (text/html, inline)]

[0001-coverage-vala-support-failing-for-VPATH-from-scratch.patch (text/x-patch, inline)]

From eb59c423d7addf124d33f50ac920789db1304adb Mon Sep 17 00:00:00 2001
Message-Id: <eb59c423d7addf124d33f50ac920789db1304adb.1314950422.git.stefano.lattarini <at> gmail.com>
From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Date: Fri, 2 Sep 2011 09:56:20 +0200
Subject: [PATCH] coverage: vala support failing for VPATH from-scratch builds
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* tests/vala-vpath.test: New test, xfailing.
* tests/Makefile.am (TESTS): Update.
* THANKS: Update.

From a report by Zbigniew Jędrzejewski-Szmek.

Related to automake bug#8753.
---
 ChangeLog             |    9 +++++++
 THANKS                |    1 +
 tests/Makefile.am     |    1 +
 tests/Makefile.in     |    1 +
 tests/vala-vpath.test |   58 +++++++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 70 insertions(+), 0 deletions(-)
 create mode 100755 tests/vala-vpath.test

diff --git a/ChangeLog b/ChangeLog
index 5d0eda1..f7514d1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2011-09-02 Stefano Lattarini  <stefano.lattarini <at> gmail.com>
+
+	coverage: vala support failing for VPATH from-scratch builds
+	* tests/vala-vpath.test: New test, xfailing.
+	* tests/Makefile.am (TESTS): Update.
+	* THANKS: Update.
+	From a report by Zbigniew Jędrzejewski-Szmek.
+	Related to automake bug#8753.
+
 2011-09-01  Stefano Lattarini  <stefano.lattarini <at> gmail.com>
 
 	docs: report few more automake parsing limitations
diff --git a/THANKS b/THANKS
index d91c5bb..f83e1fc 100644
--- a/THANKS
+++ b/THANKS
@@ -365,6 +365,7 @@ William S Fulton	wsf <at> fultondesigns.co.uk
 Yann Droneaud		ydroneaud <at> meuh.eu.org
 Younes Younes		younes <at> cs.tu-berlin.de
 Zack Weinberg		zack <at> codesourcery.com
+Zbigniew Jędrzejewski-Szmek zbyszek <at> in.waw.pl
 Zoltan Rado		z.rado <at> chello.hu
 
 ;; Local Variables:
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 6101460..4f8e0f6 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -836,6 +836,7 @@ vala2.test \
 vala3.test \
 vala4.test \
 vala5.test \
+vala-vpath.test \
 vars.test \
 vars3.test \
 vartar.test \
diff --git a/tests/Makefile.in b/tests/Makefile.in
index 108672d..32e3297 100644
--- a/tests/Makefile.in
+++ b/tests/Makefile.in
@@ -1114,6 +1114,7 @@ vala2.test \
 vala3.test \
 vala4.test \
 vala5.test \
+vala-vpath.test \
 vars.test \
 vars3.test \
 vartar.test \
diff --git a/tests/vala-vpath.test b/tests/vala-vpath.test
new file mode 100755
index 0000000..98e0f43
--- /dev/null
+++ b/tests/vala-vpath.test
@@ -0,0 +1,58 @@
+#! /bin/sh
+# Copyright (C) 2011 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Test to make sure vala support handles from-scratch VPATH builds.
+# See automake bug#8753.
+
+required="valac"
+. ./defs || Exit 1
+
+set -e
+
+mkdir src
+
+cat >> configure.in << 'END'
+AC_CONFIG_SRCDIR([hello.vala])
+AC_PROG_CC
+AM_PROG_VALAC([0.7])
+AC_OUTPUT
+END
+
+
+cat > Makefile.am <<'END'
+bin_PROGRAMS = foo
+foo_SOURCES = hello.vala
+END
+
+cat > hello.vala <<'END'
+void main ()
+{
+  stdout.printf ("foo\n");
+  return 0;
+}
+END
+
+$ACLOCAL  || framework_failure_ "aclocal error"
+$AUTOCONF || framework_failure_ "autoconf error"
+$AUTOMAKE || framework_failure_ "automake error"
+
+mkdir build
+cd build
+../configure || Exit 77
+$MAKE
+$MAKE distcheck
+
+:
-- 
1.7.2.3

Message #23 received at 8753 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: "Zbigniew Jędrzejewski-Szmek" <zbyszek <at> in.waw.pl>
Cc: 8753 <at> debbugs.gnu.org, automake-patches <at> gnu.org
Subject: Re: bug#8753: unable to build VALA project out-of-tree
Date: Sun, 4 Sep 2011 17:44:35 +0200

[Message part 1 (text/plain, inline)]

On Friday 02 September 2011, Stefano Lattarini wrote:
> On Friday 02 September 2011, Zbigniew Jędrzejewski wrote:
> > On 09/01/2011 09:35 PM, Stefano Lattarini wrote:
> > > Hi Zbigniew, sorry for the shameful delay.
> > No problem. Autotools are great anyway :)
> >
> Glad to hear that :-)
> 
> > > I'm quite ignorant about vala and also its support in automake,
> > I think that the support is in general adequate -- systemd uses vala and 
> > in general things get build like they are supposed too.
> >
> Again, glad to hear that.
> 
> > > but I do
> > > think that VPATH builds are not really supported for vala.
> > So it seems.
> >
> I mean, they are supported for distributed tarball (and this is checked in
> the automake testsuite), but not for from-scratch builds, like e.g. from a
> fresh git checkout.
> 
> > > Anyway, it would be nice to at least expose the problem in the Automake
> > > testsuite, even if only as an XFAIL; do you have a minimal use case
> > > exposing the issue?
> > I've taken the hello world example from vala tutorial and wrapped it with
> > Makefile.am and configure.ac.
> > 
> > It builds fine locally, and fails when build from an external directory:
> > 
> > /tmp/build % ~/src/vala_autotools_test/configure
> > ...
> > /tmp/build % make
> > make: *** No rule to make target 
> > `/home/zbyszek/src/vala_autotools_test/hello_vala.stamp', needed by 
> > `/home/zbyszek/src/vala_autotools_test/src/hello.c'.  Stop.
> > 
> > The example is attached. Three files: configure.ac and Makefile.am go in 
> > the root directory of the source tree, hello.vala goes into src/.
> >
> Thanks; I can reproduce the error, and I've managed to reduce your minimal
> test case even more.  I've applied the attached patch to the 'maint' branch
> in the automake repository.
>
But I forgot to list the new test in XFAIL_TESTS :-(

I've pushed the attached patch to remedy to this oversight.

Sorry for the noise,
  Stefano

[Message part 2 (text/html, inline)]

[0001-fix-list-test-vala-vpath.test-in-XFAIL_TESTS.patch (text/x-patch, inline)]

From 884694a8f84f97a584334fd58048be3de51b001a Mon Sep 17 00:00:00 2001
Message-Id: <884694a8f84f97a584334fd58048be3de51b001a.1315150154.git.stefano.lattarini <at> gmail.com>
From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Date: Sun, 4 Sep 2011 17:28:35 +0200
Subject: [PATCH] fix: list test 'vala-vpath.test' in XFAIL_TESTS

* tests/Makefile.am (XFAIL_TESTS): Update.
---
 ChangeLog         |    5 +++++
 tests/Makefile.am |    1 +
 tests/Makefile.in |    1 +
 3 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index f7514d1..3619719 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2011-09-04 Stefano Lattarini  <stefano.lattarini <at> gmail.com>
+
+	fix: list test 'vala-vpath.test' in XFAIL_TESTS
+	* tests/Makefile.am (XFAIL_TESTS): Update.
+
 2011-09-02 Stefano Lattarini  <stefano.lattarini <at> gmail.com>
 
 	coverage: vala support failing for VPATH from-scratch builds
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 4f8e0f6..38f2319 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -23,6 +23,7 @@ cond17.test \
 gcj6.test \
 pr8365-remake-timing.test \
 yacc-dist-nobuild-subdir.test \
+vala-vpath.test \
 txinfo5.test
 
 include $(srcdir)/parallel-tests.am
diff --git a/tests/Makefile.in b/tests/Makefile.in
index 32e3297..ffb2fe2 100644
--- a/tests/Makefile.in
+++ b/tests/Makefile.in
@@ -288,6 +288,7 @@ cond17.test \
 gcj6.test \
 pr8365-remake-timing.test \
 yacc-dist-nobuild-subdir.test \
+vala-vpath.test \
 txinfo5.test
 
 parallel_tests = \
-- 
1.7.2.3

Message #26 received at 8753 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Lortie <desrt <at> desrt.ca>
To: 8753 <at> debbugs.gnu.org
Cc: automake-patches <at> gnu.org
Subject: Re: bug#8753: unable to build VALA project out-of-tree
Date: Sat, 07 Jan 2012 01:21:52 -0500

[Message part 1 (text/plain, inline)]

hi,

Here are a pair of patches that should fix this issue.

Cheers

[0001-tests-fix-some-bugs-in-the-vala-vpath-test.patch (text/x-patch, attachment)]

[0002-automake-fix-VPATH-builds-for-Vala.patch (text/x-patch, attachment)]

Message #31 received at 8753 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Ryan Lortie <desrt <at> desrt.ca>
Cc: 8753 <at> debbugs.gnu.org, automake-patches <at> gnu.org
Subject: Re: bug#8753: unable to build VALA project out-of-tree
Date: Sun, 08 Jan 2012 12:54:58 +0100

[Message part 1 (text/plain, inline)]

On 01/07/2012 07:21 AM, Ryan Lortie wrote:
> hi,
>
Hi Ryan, and thanks for the patches.

> Here are a pair of patches that should fix this issue.
>
I must admit I dont' like very much the idea of having the stamp file created
in the $(srcdir) ...  but I see that the .c files generated by Vala are already
being placed in the $(srcdir) -- so you are just following the existing trend,
and you changes are a definite improvement over the existing broken situation.
So I think they are definitely good to apply.

I've edited your patches a bit to fix a couple of minor blunders and to
improve conformance to the GNU Coding Standards; since I was at it, I've
thrown in (into the second patch) an additional fix for another pre-existing
VPATH-related bug.  I've also added a tiny new patch to fix an independent
testsuite weakness (missing requirement of GNU make in vala-vpath.test).

Attached is what I'll pushed to maint in 72 hours, if there is no objection.

Thanks again for tackling this issue!

Best regards,
  Stefano

[0001-tests-fix-some-bugs-in-the-vala-vpath-test.patch (text/x-diff, attachment)]

[0002-vala-fix-VPATH-builds.patch (text/x-diff, attachment)]

[0003-tests-require-GNU-make-in-vala-vapth.test.patch (text/x-diff, attachment)]

Message #38 received at 8753-done <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Ryan Lortie <desrt <at> desrt.ca>
Cc: automake-patches <at> gnu.org, 8753-done <at> debbugs.gnu.org
Subject: Re: bug#8753: unable to build VALA project out-of-tree
Date: Wed, 11 Jan 2012 18:50:58 +0100

On 01/08/2012 12:54 PM, Stefano Lattarini wrote:
> 
> Attached is what I'll pushed to maint in 72 hours, if there is no objection.
> 
No objection has been advanced; I've thus pushed the patch and closed this
bug report.

Thanks,
  Stefano

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.