GNU bug report logs - #8453
enhancement to image mode

Previous Next

Package: emacs;

Reported by: Christian Wittern <cwittern <at> gmail.com>

Date: Sat, 9 Apr 2011 01:31:02 UTC

Severity: wishlist

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Chong Yidong <cyd <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#8453: closed (enhancement to image mode)
Date: Sat, 19 Jan 2013 15:25:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 19 Jan 2013 23:23:19 +0800
with message-id <87ip6t42oo.fsf <at> gnu.org>
and subject line Re: bug#8453: enhancement to image mode
has caused the debbugs.gnu.org bug report #8453,
regarding enhancement to image mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
8453: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8453
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Christian Wittern <cwittern <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: enhancement to image mode
Date: Sat, 09 Apr 2011 10:29:48 +0900
Hello, I am trying to send this through the send bug report function, I hope
it works.

With the help of Drew Adams on gnu.emacs.help, I added the following to
image-mode, which allows one to visit the following or previous image, which
is useful if images are in a series, such as in pages of books.  If this is
deemed useful, I would like to have this added to emacs.

(require 'image-mode)
(define-key image-mode-map "n" 'next-image)
(define-key image-mode-map "p" 'previous-image)

(defun next-image (arg)
  "when visitng an image, go to the next image in the same
directory of the same type. No argument or nil will move to the
following image in ascending order, t will move to the previous
one.  Thanks to Drew Adams for help with this on gnu.emacs.help"
  (interactive "P")
  (unless (and (buffer-file-name) (eq major-mode 'image-mode))
    (error "Not visiting a file in image mode"))
  (let* ((files   (directory-files
		   (file-name-directory (buffer-file-name)) nil
		   (file-name-extension (buffer-file-name)) ))
         (len     (length files))
         (this    (file-name-nondirectory (buffer-file-name)))
         (idx     0))
    (catch 'next-image
      (dolist (file  files)
        (when (string= this file) (throw 'next-image (1+ idx)))
        (setq idx  (1+ idx))))
    (setq idx  (+ idx (if arg -1 1)))
    (when (< idx 0) (setq idx (1- len)))
    (when (>= idx len) (setq idx 0))
    (find-file (elt files idx))))

(defun previous-image (arg)
  "when visitng an image, go to the next image in the same
directory of the same type. No argument or nil will move to the
following image in ascending order, t will move to the previous
one.  Thanks to Drew Adams for help with this on gnu.emacs.help"
  (interactive "P")
  (next-image t))


-- 
 Christian Wittern


[Message part 3 (message/rfc822, inline)]
From: Chong Yidong <cyd <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Christian Wittern <cwittern <at> gmail.com>, 8453-done <at> debbugs.gnu.org
Subject: Re: bug#8453: enhancement to image mode
Date: Sat, 19 Jan 2013 23:23:19 +0800
Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> With the help of Drew Adams on gnu.emacs.help, I added the following
>> to image-mode, which allows one to visit the following or previous
>> image, which is useful if images are in a series, such as in pages of
>> books.  If this is deemed useful, I would like to have this added to
>> emacs.
>
> This looks very handy, indeed.  I'd recommend to slightly change the
> code so it just looks for the first filename greater than the current
> name (so it also works in the odd case where the current file is not
> in the directory any more).

Done, with some substantial modifications.


This bug report was last modified 12 years and 183 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.