GNU bug report logs - #8443
Updated patches: Re: bug#8441: Patches making libtool-2.4-1 build under GNU/Hurd

Previous Next

To reply to this bug, email your comments to 8443 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Svante Signell <srs <at> kth.se>
To: Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de>, bug-libtool <at> gnu.org
Cc: 8441 <at> debbugs.gnu.org
Subject: Updated patches: Re: bug#8441: Patches making libtool-2.4-1 build
	under GNU/Hurd
Date: Fri, 08 Apr 2011 09:01:56 +0200

[Message part 1 (text/plain, inline)]

On Thu, 2011-04-07 at 20:24 +0200, Ralf Wildenhues wrote:
> * Svante Signell wrote on Thu, Apr 07, 2011 at 08:20:55PM CEST:
> > On Thu, 2011-04-07 at 20:06 +0200, Ralf Wildenhues wrote:
> > > > --- libtool-2.4/tests/cmdline_wrap.at.orig	2010-05-20 23:18:41.000000000 +0200
> > > > +++ libtool-2.4/tests/cmdline_wrap.at	2011-02-06 11:08:29.000000000 +0100
> > > > @@ -30,6 +30,9 @@
> 
> > > > +# Setting low max_cmd_len on "hurd-386" does not make sense"
> > > > +AT_CHECK([if test "$host_os" == "gnu" ; then exit 77; fi])
> > > 
> > > Please use = not ==, the former is Posix test, the latter bash-specific.
> > 
> > OK, do you want me to send an update?
>
> I can't speak for Kurt, I only help maintain upstream.  ;-)

Updated!

> > > Does this test actually fail on hurd-i386, or is this just because you
> > > consider it wasted time?  In the former case, please send the patch
> > > upstream but also show a cut-n-paste of the failing test log.
> > 
> > Yes, this test fails without the patch. I'll build an unpatched version
> > and submit the failing test log. BTW: Where is upstream, is
> > bug-libtool <at> gnu.org sufficient?
> 
> Sure, but you can just as well send a patch right to libtool-patches
> (first-post moderation, but subscribing is not required).

I tried libtool-patches, but I had to register to be able to submit
there. Comments are embedded in the patches.

The test fails without the patch, see below (partial info I found in the
tests/testsuite.log file on test 112):

(where to find the complete log if this test, in
tests/testsuite.dir/112/testsuite.lo or
tests/testsuite.dir/112/tests/testsuite.dir/testsuilt.log? Both files
are very large)

 112: cmdline_wrap.at:28 Run tests with low max_cmd_len
      recursive
112. cmdline_wrap.at:28: testing ...
./cmdline_wrap.at:43: $CONFIG_SHELL $abs_srcdir/testsuite -k libtool
$INNER_TESTSUITEFLAGS
stderr:
ERROR: 43 tests were run,
4 failed (3 expected failures).
10 tests were skipped.

[define_shlibpath_overrides_runpath4hurd.patch (text/x-patch, attachment)]

[disable_cmdline_wrap4hurd.patch (text/x-patch, attachment)]

[link_all_deplibs.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de>
To: Svante Signell <srs <at> kth.se>, libtool-patches <at> gnu.org
Cc: bug-libtool <at> gnu.org, 8441 <at> debbugs.gnu.org
Subject: Re: Updated patches: Re: bug#8441: Patches making libtool-2.4-1
	build under GNU/Hurd
Date: Sun, 10 Apr 2011 10:20:29 +0200

* Svante Signell wrote on Fri, Apr 08, 2011 at 09:01:56AM CEST:
> # shlibpath_overrides_runpath is set to 'unknown' in libtool.m4
> # and not defined under $host_os ="gnu"
> # This patch make the tests/*demo* run.
> --- libtool-2.4/libltdt/m4/libtool.m4.orig	2011-02-03 21:33:56.000000000 +0100
> +++ libtool-2.4/libltdl/m4/libtool.m4	2011-02-03 21:43:46.000000000 +0100
> @@ -2325,6 +2325,7 @@
>    library_names_spec='${libname}${release}${shared_ext}$versuffix ${libname}${release}${shared_ext}${major} ${libname}${shared_ext}'
>    soname_spec='${libname}${release}${shared_ext}$major'
>    shlibpath_var=LD_LIBRARY_PATH
> +  shlibpath_overrides_runpath=no
>    hardcode_into_libs=yes
>    ;;

Thank you.  This should let the low-cmdline test pass as well, so it
need not be disabled any more (except for non coffee drinking purposes
at least ;-)

I'm pushing the patch below in your name and adding you to THANKS.
The '(tiny change)' annotation is just to denote that you haven't
exchanged copyright papers with the FSF yet.

Cheers,
Ralf

2011-04-10  Svante Signell  <...>  (tiny change)

	Set shlibpath_overrides_runpath for the Hurd.
	* libltdl/m4/libtool.m4 (_LT_SYS_DYNAMIC_LINKER) [gnu]
	<shlibpath_overrides_runpath>: Set to no.
	* THANKS: Update.

diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4
index 5cc027b..2ed41b7 100644
--- a/libltdl/m4/libtool.m4
+++ b/libltdl/m4/libtool.m4
@@ -2519,6 +2519,7 @@ gnu*)
   library_names_spec='${libname}${release}${shared_ext}$versuffix ${libname}${release}${shared_ext}${major} ${libname}${shared_ext}'
   soname_spec='${libname}${release}${shared_ext}$major'
   shlibpath_var=LD_LIBRARY_PATH
+  shlibpath_overrides_runpath=no
   hardcode_into_libs=yes
   ;;
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.