GNU bug report logs - #8309
24.0.50; Remove leftover (require 'wid-edit)

Previous Next

Package: emacs;

Reported by: Leo <sdl.web <at> gmail.com>

Date: Mon, 21 Mar 2011 06:36:01 UTC

Severity: minor

Found in version 24.0.50

Fixed in version 24.1.

Done: Leo <sdl.web <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo <sdl.web <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#8309: closed (24.0.50; Remove leftover (require 'wid-edit))
Date: Mon, 21 Mar 2011 15:29:01 +0000

[Message part 1 (text/plain, inline)]
Your message dated Mon, 21 Mar 2011 23:28:15 +0800
with message-id <m1r5a01oj4.fsf <at> gmail.com>
and subject line Re: bug#8309: 24.0.50; Remove leftover (require 'wid-edit)
has caused the GNU bug report #8309,
regarding 24.0.50; Remove leftover (require 'wid-edit)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
8309: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8309
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; Remove leftover (require 'wid-edit)
Date: Mon, 21 Mar 2011 14:35:20 +0800

It looks to me since revno: 103251:

,----[ 103251 ]
| message:
|   Use simple buttons, instead of widget buttons, in vc-log.
|   
|   * lisp/vc/vc.el (vc-print-log-setup-buttons): Instead of using the
|   widget library for buttons, just use button.el.
|   
|   * lisp/vc/log-view.el (log-view-mode-map): Don't inherit from
|   widget-keymap.
`----

(require 'wid-edit) is no longer needed for log-view.el. Any objection
to this patch:

=== modified file 'lisp/vc/log-view.el'
--- lisp/vc/log-view.el	2011-02-14 01:49:24 +0000
+++ lisp/vc/log-view.el	2011-03-21 06:34:34 +0000
@@ -121,9 +121,6 @@
   :group 'pcl-cvs
   :prefix "log-view-")
 
-;; Needed because log-view-mode-map inherits from widget-keymap.  (Bug#5311)
-(require 'wid-edit)
-
 (easy-mmode-defmap log-view-mode-map
   '(
     ;; FIXME: (copy-keymap special-mode-map) instead



Leo



[Message part 3 (message/rfc822, inline)]
From: Leo <sdl.web <at> gmail.com>
To: 8309-done <at> debbugs.gnu.org
Subject: Re: bug#8309: 24.0.50; Remove leftover (require 'wid-edit)
Date: Mon, 21 Mar 2011 23:28:15 +0800

Version: 24.1.
This bug report was last modified 14 years and 126 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.