GNU bug report logs - #8309
24.0.50; Remove leftover (require 'wid-edit)

Previous Next

Package: emacs;

Reported by: Leo <sdl.web <at> gmail.com>

Date: Mon, 21 Mar 2011 06:36:01 UTC

Severity: minor

Found in version 24.0.50

Fixed in version 24.1.

Done: Leo <sdl.web <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8309 in the body.
You can then email your comments to 8309 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, cyd <at> stupidchicken.com, bug-gnu-emacs <at> gnu.org:
bug#8309; Package emacs. (Mon, 21 Mar 2011 06:36:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Leo <sdl.web <at> gmail.com>:
New bug report received and forwarded. Copy sent to cyd <at> stupidchicken.com, bug-gnu-emacs <at> gnu.org. (Mon, 21 Mar 2011 06:36:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; Remove leftover (require 'wid-edit)
Date: Mon, 21 Mar 2011 14:35:20 +0800

It looks to me since revno: 103251:

,----[ 103251 ]
| message:
|   Use simple buttons, instead of widget buttons, in vc-log.
|   
|   * lisp/vc/vc.el (vc-print-log-setup-buttons): Instead of using the
|   widget library for buttons, just use button.el.
|   
|   * lisp/vc/log-view.el (log-view-mode-map): Don't inherit from
|   widget-keymap.
`----

(require 'wid-edit) is no longer needed for log-view.el. Any objection
to this patch:

=== modified file 'lisp/vc/log-view.el'
--- lisp/vc/log-view.el	2011-02-14 01:49:24 +0000
+++ lisp/vc/log-view.el	2011-03-21 06:34:34 +0000
@@ -121,9 +121,6 @@
   :group 'pcl-cvs
   :prefix "log-view-")
 
-;; Needed because log-view-mode-map inherits from widget-keymap.  (Bug#5311)
-(require 'wid-edit)
-
 (easy-mmode-defmap log-view-mode-map
   '(
     ;; FIXME: (copy-keymap special-mode-map) instead



Leo
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#8309; Package emacs. (Mon, 21 Mar 2011 14:52:02 GMT) Full text and rfc822 format available.

Message #8 received at 8309 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Cc: Chong Yidong <cyd <at> stupidchicken.com>, 8309 <at> debbugs.gnu.org
Subject: Re: bug#8309: 24.0.50; Remove leftover (require 'wid-edit)
Date: Mon, 21 Mar 2011 10:51:13 -0400

> === modified file 'lisp/vc/log-view.el'
> --- lisp/vc/log-view.el	2011-02-14 01:49:24 +0000
> +++ lisp/vc/log-view.el	2011-03-21 06:34:34 +0000
> @@ -121,9 +121,6 @@
>    :group 'pcl-cvs
>    :prefix "log-view-")
 
> -;; Needed because log-view-mode-map inherits from widget-keymap.  (Bug#5311)
> -(require 'wid-edit)
> -
>  (easy-mmode-defmap log-view-mode-map
>    '(
>      ;; FIXME: (copy-keymap special-mode-map) instead

Please install, yes, thanks,


        Stefan
Reply sent to Leo <sdl.web <at> gmail.com>:
You have taken responsibility. (Mon, 21 Mar 2011 15:29:01 GMT) Full text and rfc822 format available.
Notification sent to Leo <sdl.web <at> gmail.com>:
bug acknowledged by developer. (Mon, 21 Mar 2011 15:29:02 GMT) Full text and rfc822 format available.

Message #13 received at 8309-done <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: 8309-done <at> debbugs.gnu.org
Subject: Re: bug#8309: 24.0.50; Remove leftover (require 'wid-edit)
Date: Mon, 21 Mar 2011 23:28:15 +0800

Version: 24.1.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 19 Apr 2011 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 14 years and 125 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.