GNU bug report logs - #8279
[PATCH] More fixes to prevent hide-show from being confused by commented-out braces

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8279 in the body.
You can then email your comments to 8279 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <dkogan <at> cds.caltech.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] More fixes to prevent hide-show from being confused by
	commented-out braces
Date: Fri, 18 Mar 2011 00:33:15 -0700

[Message part 1 (text/plain, inline)]

Earlier I submitted some fixes to hideshow.el to improve handling of
braces in comments (bug#8036). These fixes were incomplete and in one
case, incorrect. The attached patch improves hideshow.el further:

1. The previous patch made hs-find-block-beginning quit searching if a brace was
found inside a comment. This patch ignores that match and keeps searching.

2. There were some false positives of (looking-at hs-block-start-regexp) if the
point was at a commented-out brace. This patch wraps all instances of that in a
function to check for comments.

[0001-hideshow.el-corrected-improper-handling-of-braces-in.patch (text/x-patch, attachment)]

Message #8 received at 8279 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Dima Kogan <dkogan <at> cds.caltech.edu>
Cc: 8279 <at> debbugs.gnu.org
Subject: Re: bug#8279: [PATCH] More fixes to prevent hide-show from being
	confused by commented-out braces
Date: Sat, 28 May 2011 14:35:57 -0400

Dima Kogan <dkogan <at> cds.caltech.edu> writes:

> Earlier I submitted some fixes to hideshow.el to improve handling of
> braces in comments (bug#8036). These fixes were incomplete and in one
> case, incorrect. The attached patch improves hideshow.el further:

+  "Returns non-nil if the point is at the block start.
+A function is useful for this to cleanly disregard commented-out
+blocks"

This docstring should use the active voice, i.e. "Returns non-nil if the
point is at the block start."  And there's no need to justify the use of
a function.

Otherwise, the patch looks reasonable; I've commited it.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.