GNU bug report logs - #8165
24.0.50; cperl indentation

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#8165: closed (24.0.50; cperl indentation)
Date: Tue, 01 Sep 2020 17:13:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 1 Sep 2020 10:12:07 -0700
with message-id <CADwFkmk1fmrFPVefDmDm5oBM-bvU14UgD4V4sFv4UCx3JjzQ7A <at> mail.gmail.com>
and subject line Re: bug#8165: cperl-mode: The wanted indentation is available via customize
has caused the debbugs.gnu.org bug report #8165,
regarding 24.0.50; cperl indentation
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
8165: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8165
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Sam Steingold <sds <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; cperl indentation
Date: Thu, 03 Mar 2011 11:37:10 -0500

cperl-mode mis-indents _data_ (as opposed to _code_).
e.g.,

use Class::Struct Foo => [
    a => '$',
    b => '$',
    c => '$',
];

is indented as

use Class::Struct Foo => [
                          a => '$',
                          b => '$',
                          c => '$',
                         ];

which is much less readable.
the same goes for

my $foo = [
    "a",
    "b",
    ("c","d"),
];

I understand that this might be a matter of taste, but it would be nice
if my preferred indentation were also available.

PS. I am aware (and not fond) of the alternative

my $foo =
  [ .... ];


-- 
Sam Steingold (http://sds.podval.org/) on CentOS release 5.3 (Final) X
http://mideasttruth.com http://iris.org.il
http://ffii.org http://memri.org http://pmw.org.il http://www.memritv.org
The paperless office will become a reality soon after the paperless toilet.

[Message part 3 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Harald Jörg <haj <at> posteo.de>, 8165-done <at> debbugs.gnu.org
Subject: Re: bug#8165: cperl-mode: The wanted indentation is available via
 customize
Date: Tue, 1 Sep 2020 10:12:07 -0700

Harald Jörg <haj <at> posteo.de> writes:

> Therefore I suggest to close this bug.

Done.

You can just add -done to the bug number in the address if you would
like to do it yourself next time.  See the To-field of this message.

> These are also the recommended settings in the most influential book
> Perl Best Practices (PBP) by Damian Conway.  I guess I should add
> the PBP settings for indentation in a new value to cperl-style-alist,
> but that's probably beyond the scope of this bug report.

It sounds like a good idea to add such an option.

Just a thought: I seem to remember that the PBP recommendations is the
generally accepted style in the Perl community these days?  Does it make
sense to change that to be the default?  (It's been over 10 years since
I did any serious Perl programming...)

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.