GNU bug report logs - #8131
24.0.50; dired-do-redisplay applies unwanted mark to file/dir line

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8131 in the body.
You can then email your comments to 8131 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Peters <kennedywildwood <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Cc: jfp <at> practic.com
Subject: 24.0.50; dired-do-redisplay applies unwanted mark to file/dir line
Date: Sun, 27 Feb 2011 00:08:13 -0800 (PST)

Dear Friends:

Recent breakage in dired-do-redisplay, manifests in Fedora 13 and Mac OS
X. File or dir line acquires an unexpected mark which appears to be the name's first letter.

Failure recipe: (Fedora 13, Emacs bzr-103433) 

emacs -Q --eval='(progn (write-file (make-temp-file "FOO"))(require
(quote dired)) (dired-jump) (dired-do-redisplay))'

will apply "F" mark to the file line.

Cheers,

John Peters
kennedywildwood <at> yahoo.com

In GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.20.1)
 of 2011-02-26 on localhost.localdomain
Windowing system distributor `Fedora Project', version 11.0.10802000
configured using `configure  '--with-x' '--with-x-toolkit=gtk' '--without-selinux' '--without-compress-info''

Important settings:
  value of $LC_ALL: C
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default enable-multibyte-characters: t

Major mode: Dired by name

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x e m a c s - <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> r e p o r t - e 
m a c s b u g <backspace> <backspace> <backspace> - 
b u g <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Saving file /tmp/FOO265947zf...
Wrote /tmp/FOO265947zf
Redisplaying...done

Load-path shadows:
None found.

Features:
(shadow sort mail-extr message sendmail rfc822 mml mml-sec mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
mailabbrev mail-utils gmm-utils mailheader emacsbug url-util url-parse
auth-source eieio byte-opt bytecomp byte-compile assoc gnus-util
time-date password-cache url-vars mm-util mail-prsvr dired-aux dired-x
easymenu dired regexp-opt tooltip ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd tool-bar dnd fontset image fringe lisp-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button
minibuffer faces cus-face files text-properties overlay md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind dynamic-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

Message #8 received at 8131 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: jidanni <at> jidanni.org, kennedywildwood <at> yahoo.com
Cc: 8073 <at> debbugs.gnu.org, 8131 <at> debbugs.gnu.org
Subject: Re: bug#8073 and bug#8131
Date: Sun, 27 Feb 2011 20:53:22 +0100

On Fri, 18 Feb 2011 16:47:39 +0800 jidanni <at> jidanni.org wrote:

> M runs the command dired-do-chmod, which is an interactive compiled
> Lisp function in `dired-aux.el'.
>
> However, if you forget to give it a mode, and just type RET, before long
> your dired will look like
>
>   drwxr-xr-x  3 jidanni   4096 Feb 18 16:44 .
>   drwxr-xr-x 94 jidanni  12288 Feb 18 15:06 ..
>   -rwxr-xr-x  1 jidanni    635 Jan 21 20:01 Email_Addresses.pl
>   -rw-r--r--  1 jidanni   1287 Feb 18 16:39 Makefile
> b -rw-r--r--  1 jidanni   2750 Nov 27  2009 b3
>   drwxr-xr-x  2 jidanni   4096 Jul 22  2010 dropping
> j -rw-r--r--  1 jidanni   1190 Nov 27  2009 jj
>   -rw-r--r--  1 jidanni   5084 Nov 27  2009 nam
> u -rw-r--r--  1 jidanni   9540 Feb 18 16:44 u.htm
>
> with the first letter of the file appearing before the line.

On Sun, 27 Feb 2011 00:08:13 -0800 (PST) John Peters <kennedywildwood <at> yahoo.com> wrote:

> Dear Friends:
>
> Recent breakage in dired-do-redisplay, manifests in Fedora 13 and Mac OS
> X. File or dir line acquires an unexpected mark which appears to be the name's first letter.
>
> Failure recipe: (Fedora 13, Emacs bzr-103433) 
>
> emacs -Q --eval='(progn (write-file (make-temp-file "FOO"))(require
> (quote dired)) (dired-jump) (dired-do-redisplay))'
>
> will apply "F" mark to the file line.

I believe both of these bugs are due to this change:

2010-11-09  Glenn Morris  <rgm <at> gnu.org>

        [...]
	* dired-aux.el (dired-kill-line, dired-do-kill-lines)
	(dired-update-file-line, dired-add-entry, dired-remove-entry)
	(dired-relist-entry):
        [...]
	Replace yet more uses of end-of-line etc with line-end-position, etc.

Here is a fix:

*** /data/steve/bzr/emacs/trunk/lisp/dired-aux.el	2011-02-23 15:11:01.000000000 +0100
--- /data/steve/bzr/emacs/quickfixes/lisp/dired-aux.el	2011-02-27 20:45:45.000000000 +0100
***************
*** 1025,1033 ****
    ;; Keeps any marks that may be present in column one (doing this
    ;; here is faster than with dired-add-entry's optional arg).
    ;; Does not update other dired buffers.  Use dired-relist-entry for that.
!   (let ((char (following-char))
! 	(opoint (line-beginning-position))
! 	(buffer-read-only))
      (delete-region opoint (progn (forward-line 1) (point)))
      (if file
  	(progn
--- 1025,1033 ----
    ;; Keeps any marks that may be present in column one (doing this
    ;; here is faster than with dired-add-entry's optional arg).
    ;; Does not update other dired buffers.  Use dired-relist-entry for that.
!   (let* ((opoint (line-beginning-position))
! 	 (char (char-after opoint))
! 	 (buffer-read-only))
      (delete-region opoint (progn (forward-line 1) (point)))
      (if file
  	(progn

Steve Berman

Message #13 received at 8131-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 8131-done <at> debbugs.gnu.org
Subject: Re: bug#8131: dired-do-redisplay applies unwanted mark to file/dir
	line
Date: Sun, 27 Feb 2011 20:31:41 -0500

Stephen Berman wrote:

> Here is a fix:

Cheers; applied.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.