GNU bug report logs - #79367
31.0.50; magit-commit sometimes doesn't work if diff-hl-update-async is t

Previous Next

Full log

Message #86 received at 79367 <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: i <at> fuzy.me, 79367 <at> debbugs.gnu.org, dmitry <at> gutov.dev
Subject: Re: bug#79367: 31.0.50; magit-commit sometimes doesn't work if
 diff-hl-update-async is t
Date: Wed, 03 Sep 2025 12:03:42 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Spencer Baugh <sbaugh <at> janestreet.com>
>> Cc: Zhengyi Fu <i <at> fuzy.me>,  79367 <at> debbugs.gnu.org,  dmitry <at> gutov.dev
>> Date: Wed, 03 Sep 2025 11:00:19 -0400
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> >> From: Zhengyi Fu <i <at> fuzy.me>
>> >> Cc: sbaugh <at> janestreet.com,  dmitry <at> gutov.dev,  79367 <at> debbugs.gnu.org
>> >> Date: Wed, 03 Sep 2025 22:42:26 +0800
>> >> 
>> >> Eli Zaretskii <eliz <at> gnu.org> writes:
>> >> 
>> >> > Zhengyi Fu, can you please apply it to the current master, and see if
>> >> > it solves the original problem?
>> >> 
>> >> It does resolve my original problem.
>> >
>> > Thanks for testing.
>> >
>> >> But I think we need to call set_proc_thread when the server process
>> >> is not locked as well.  Otherwise the `thread' member of the
>> >> fd_callback_info may still be a dangling pointer.
>> >
>> > Oh, you mean the below?  I agree, it is safer.
>> 
>> We should not do that - if the thread member of fd_callback_info is a
>> dangling pointer, that indicates there's a bug elsewhere.
>
> So how about adding an assertion before we clear it?

Sure.  fd_callback_info.thread specifically should always be NULL at the
time we're using the fd_callback_info slot for some new fd, so we should
assert that.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.