GNU bug report logs - #79336
[PATCH] df: fix potential null pointer dereference

Previous Next

Full log

Message #34 received at 79336-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: yubiao hu <huyubiaox <at> gmail.com>
Cc: 79336-done <at> debbugs.gnu.org
Subject: Re: bug#79336: [PATCH] df: fix potential null pointer dereference
Date: Mon, 1 Sep 2025 10:07:21 -0700

[Message part 1 (text/plain, inline)]

On 2025-09-01 05:50, yubiao hu wrote:
> I have tested the patch, and it can pacify my static analyzer.

Thanks for checking. I installed the attached patch, which is the same 
except with a comment fixed.

It's typically better not to patch merely to pacify a false positive 
from static analysis, if the patch introduces makework code that 
complicates the work of humans (and of other static analyzers) and that 
slows down execution. But here the patch streamlines the code (and 
caused me to review and fix commentary errors) so it's a clear win. 
Thanks for reporting the issue.

Closing the bug report.

[0001-df-pacify-static-analysis.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.