GNU bug report logs - #79335
[PATCH] Make 'lua-prefix-key' option a 'key-sequence'

Previous Next

To reply to this bug, email your comments to 79335 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Make 'lua-prefix-key' option a 'key-sequence'
Date: Thu, 28 Aug 2025 18:53:23 -0500

Michael Albinus <michael.albinus <at> gmx.de> writes:

> This breaks test-custom-opts:
>
>    FAILED  check-for-wrong-custom-opts  ((should (null (cus-test-opts t))) :form (null ((lua-prefix-key :type-error 3 (string)))) :value nil)
>
>
> Likely, lua-prefix-key needs
>
>   :type '(choice (const nil) string)
>
> But I don't know whether this is intended.

The problem is that there are cases where it is being set to an
integer. I’ve change the defcustom to use the key-sequence type
now and fixed the test. Patch incoming.

Message #8 received at 79335 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: 79335 <at> debbugs.gnu.org
Cc: Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#79335: [PATCH] Make 'lua-prefix-key' option a 'key-sequence'
Date: Thu, 28 Aug 2025 19:29:26 -0500

[0001-Make-lua-prefix-key-option-a-key-sequence.patch (text/x-patch, attachment)]

[Message part 2 (text/plain, inline)]

john muhl <jm <at> pub.pink> writes:

> Michael Albinus <michael.albinus <at> gmx.de> writes:
>
>> This breaks test-custom-opts:
>>
>>    FAILED  check-for-wrong-custom-opts  ((should (null (cus-test-opts t))) :form (null ((lua-prefix-key :type-error 3 (string)))) :value nil)
>>
>>
>> Likely, lua-prefix-key needs
>>
>>   :type '(choice (const nil) string)
>>
>> But I don't know whether this is intended.
>
> The problem is that there are cases where it is being set to an
> integer. I’ve change the defcustom to use the key-sequence type
> now and fixed the test. Patch incoming.

Message #11 received at 79335 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: john muhl <jm <at> pub.pink>
Cc: 79335 <at> debbugs.gnu.org
Subject: Re: bug#79335: [PATCH] Make 'lua-prefix-key' option a 'key-sequence'
Date: Fri, 29 Aug 2025 09:51:01 +0200

john muhl <jm <at> pub.pink> writes:

Hi John,

> The problem is that there are cases where it is being set to an
> integer. I’ve change the defcustom to use the key-sequence type
> now and fixed the test. Patch incoming.

Thanks for the patch. I've checked it with both test-custom-opts and
lua-mode-tests; no problem. Pushed to master.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.