GNU bug report logs - #79129
[PATCH] build-system: emacs: Fix getting package dependencies.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#79129: closed ([PATCH] build-system: emacs: Fix getting
 package dependencies.)
Date: Thu, 31 Jul 2025 15:42:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 31 Jul 2025 17:41:04 +0200
with message-id <87v7n8id0v.fsf <at> ngraves.fr>
and subject line Re: [bug#79129] [PATCH] build-system: emacs: Fix getting package dependencies.
has caused the debbugs.gnu.org bug report #79129,
regarding [PATCH] build-system: emacs: Fix getting package dependencies.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
79129: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=79129
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ilya Chernyshov <ichernyshovvv <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] build-system: emacs: Fix getting package dependencies.
Date: Wed, 30 Jul 2025 15:30:23 +0000

[Message part 3 (text/plain, inline)]

Hi. `ensure-package-description' procedure from emacs-build-system.scm
contains an undefined elisp function `package--prepare-dependencies'. It
was replaced with `lm--prepare-package-dependencies' after 29.1 release.
You can see the changes here:
https://cgit.git.savannah.gnu.org/cgit/emacs.git/commit/?id=bb5399e3cd75450db6db9b3c5829f7bd87ca1308

[Message part 4 (text/html, inline)]

[0001-build-system-emacs-Fix-getting-package-dependencies.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Ilya Chernyshov <ichernyshovvv <at> gmail.com>, 79129-done <at> debbugs.gnu.org,
 Andreas Enge <andreas <at> enge.fr>, liliana.priker <at> gmail.com
Subject: Re: [bug#79129] [PATCH] build-system: emacs: Fix getting package
 dependencies.
Date: Thu, 31 Jul 2025 17:41:04 +0200

I think this is already fixed on the emacs-team branch:
https://codeberg.org/guix/guix/commit/b87a7905495d2d3fe88af76fa45bd18837f40524

The issue is that indeed we probably need to do something to get it
merged quicker, because it's fixes rather than updates.

@Enge could we for instance drop the reproducibility patch on
emacs-team (which I can build locally without issues, but CI doesn't
seem to like it too much), and take precedence over "update" branches.
I feel it's very bad for user experience to have those errors hanging,
and emacs packages are mostly light and not that numerous, so it
shouldn't be too high of a cost on CI.  I don't support selfishness of
one team, but we'll keep having these reports until we fix what's
broken.

Errors are : #603 ; #736 ; #1309 ; #997 ; 
And most likely too : #993 ; #836 ; #1035 ; 

@lilyp, WDYT?

Best regards,
Nicolas


On 2025-07-30 15:30, Ilya Chernyshov wrote:

> Hi. `ensure-package-description' procedure from emacs-build-system.scm
> contains an undefined elisp function `package--prepare-dependencies'. It
> was replaced with `lm--prepare-package-dependencies' after 29.1 release.
> You can see the changes here:
> https://cgit.git.savannah.gnu.org/cgit/emacs.git/commit/?id=bb5399e3cd75450db6db9b3c5829f7bd87ca1308
> From 91d5af8e8883a15601f2a6c1e7c21fba704d1cef Mon Sep 17 00:00:00 2001
> From: Ilya Chernyshov <ichernyshovvv <at> gmail.com>
> Date: Wed, 30 Jul 2025 19:45:32 +0500
> Subject: [PATCH] build-system: emacs: Fix getting package dependencies.
>
> * guix/build/emacs-build-system (ensure-package-description): Use
> lm-package-requires to get package dependencies.
> ---
>  guix/build/emacs-build-system.scm | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-system.scm
> index ffa6d3cbb0..b7f31c7fee 100644
> --- a/guix/build/emacs-build-system.scm
> +++ b/guix/build/emacs-build-system.scm
> @@ -193,11 +193,7 @@ (define %write-pkg-file-form
>                  (and (re-search-forward ,summary-regexp nil t)
>                       (match-string-no-properties 1)))
>                 package--default-summary)
> -           (let ((require-lines (lm-header-multiline "package-requires")))
> -             (and require-lines
> -                  (package--prepare-dependencies
> -                   (package-read-from-string
> -                    (mapconcat 'identity require-lines " ")))))
> +           (lm-package-requires)
>             :kind       'single
>             :url        (lm-homepage)
>             :keywords   (lm-keywords-list)

-- 
Best regards,
Nicolas Graves

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.