GNU bug report logs - #79129
[PATCH] build-system: emacs: Fix getting package dependencies.

Previous Next

To reply to this bug, email your comments to 79129 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ilya Chernyshov <ichernyshovvv <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] build-system: emacs: Fix getting package dependencies.
Date: Wed, 30 Jul 2025 15:30:23 +0000

[Message part 1 (text/plain, inline)]

Hi. `ensure-package-description' procedure from emacs-build-system.scm
contains an undefined elisp function `package--prepare-dependencies'. It
was replaced with `lm--prepare-package-dependencies' after 29.1 release.
You can see the changes here:
https://cgit.git.savannah.gnu.org/cgit/emacs.git/commit/?id=bb5399e3cd75450db6db9b3c5829f7bd87ca1308

[Message part 2 (text/html, inline)]

[0001-build-system-emacs-Fix-getting-package-dependencies.patch (text/x-patch, attachment)]

Message #10 received at 79129-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Ilya Chernyshov <ichernyshovvv <at> gmail.com>, 79129-done <at> debbugs.gnu.org,
 Andreas Enge <andreas <at> enge.fr>, liliana.priker <at> gmail.com
Subject: Re: [bug#79129] [PATCH] build-system: emacs: Fix getting package
 dependencies.
Date: Thu, 31 Jul 2025 17:41:04 +0200

I think this is already fixed on the emacs-team branch:
https://codeberg.org/guix/guix/commit/b87a7905495d2d3fe88af76fa45bd18837f40524

The issue is that indeed we probably need to do something to get it
merged quicker, because it's fixes rather than updates.

@Enge could we for instance drop the reproducibility patch on
emacs-team (which I can build locally without issues, but CI doesn't
seem to like it too much), and take precedence over "update" branches.
I feel it's very bad for user experience to have those errors hanging,
and emacs packages are mostly light and not that numerous, so it
shouldn't be too high of a cost on CI.  I don't support selfishness of
one team, but we'll keep having these reports until we fix what's
broken.

Errors are : #603 ; #736 ; #1309 ; #997 ; 
And most likely too : #993 ; #836 ; #1035 ; 

@lilyp, WDYT?

Best regards,
Nicolas


On 2025-07-30 15:30, Ilya Chernyshov wrote:

> Hi. `ensure-package-description' procedure from emacs-build-system.scm
> contains an undefined elisp function `package--prepare-dependencies'. It
> was replaced with `lm--prepare-package-dependencies' after 29.1 release.
> You can see the changes here:
> https://cgit.git.savannah.gnu.org/cgit/emacs.git/commit/?id=bb5399e3cd75450db6db9b3c5829f7bd87ca1308
> From 91d5af8e8883a15601f2a6c1e7c21fba704d1cef Mon Sep 17 00:00:00 2001
> From: Ilya Chernyshov <ichernyshovvv <at> gmail.com>
> Date: Wed, 30 Jul 2025 19:45:32 +0500
> Subject: [PATCH] build-system: emacs: Fix getting package dependencies.
>
> * guix/build/emacs-build-system (ensure-package-description): Use
> lm-package-requires to get package dependencies.
> ---
>  guix/build/emacs-build-system.scm | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-system.scm
> index ffa6d3cbb0..b7f31c7fee 100644
> --- a/guix/build/emacs-build-system.scm
> +++ b/guix/build/emacs-build-system.scm
> @@ -193,11 +193,7 @@ (define %write-pkg-file-form
>                  (and (re-search-forward ,summary-regexp nil t)
>                       (match-string-no-properties 1)))
>                 package--default-summary)
> -           (let ((require-lines (lm-header-multiline "package-requires")))
> -             (and require-lines
> -                  (package--prepare-dependencies
> -                   (package-read-from-string
> -                    (mapconcat 'identity require-lines " ")))))
> +           (lm-package-requires)
>             :kind       'single
>             :url        (lm-homepage)
>             :keywords   (lm-keywords-list)

-- 
Best regards,
Nicolas Graves

Message #13 received at 79129 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: liliana.priker <at> gmail.com, 79129 <at> debbugs.gnu.org,
 Ilya Chernyshov <ichernyshovvv <at> gmail.com>
Subject: Re: [bug#79129] [PATCH] build-system: emacs: Fix getting package
 dependencies.
Date: Fri, 1 Aug 2025 17:34:32 +0200

Hello,

Am Thu, Jul 31, 2025 at 05:41:04PM +0200 schrieb Nicolas Graves:
> @Enge could we for instance drop the reproducibility patch on
> emacs-team (which I can build locally without issues, but CI doesn't
> seem to like it too much), and take precedence over "update" branches.
> I feel it's very bad for user experience to have those errors hanging,
> and emacs packages are mostly light and not that numerous, so it
> shouldn't be too high of a cost on CI.

one solution would be to somehow extract fixes out of the emacs-team
branch and to apply them to master. I do not know whether this is
possible depending on the scope of the changes.

Andreas

Message #16 received at 79129 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Andreas Enge <andreas <at> enge.fr>
Cc: 79129 <at> debbugs.gnu.org, liliana.priker <at> gmail.com,
 Ilya Chernyshov <ichernyshovvv <at> gmail.com>
Subject: Re: [bug#79129] [PATCH] build-system: emacs: Fix getting package
 dependencies.
Date: Mon, 04 Aug 2025 08:34:26 +0200

On 2025-08-01 17:34, Andreas Enge wrote:

> Hello,
>
> Am Thu, Jul 31, 2025 at 05:41:04PM +0200 schrieb Nicolas Graves:
>> @Enge could we for instance drop the reproducibility patch on
>> emacs-team (which I can build locally without issues, but CI doesn't
>> seem to like it too much), and take precedence over "update" branches.
>> I feel it's very bad for user experience to have those errors hanging,
>> and emacs packages are mostly light and not that numerous, so it
>> shouldn't be too high of a cost on CI.
>
> one solution would be to somehow extract fixes out of the emacs-team
> branch and to apply them to master. I do not know whether this is
> possible depending on the scope of the changes.

There are very little patches, a couple of them only. The scope of
affected packages is: 1673 for emacs-minimal, 38 for emacs-no-x, 98 for
emacs.

The scope is big for a master push, but most of these packages are
light, it has nothing to do with pushing such changes with heavy C/C++
packages.

-- 
Best regards,
Nicolas Graves

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.