GNU bug report logs -
#78812
feature/igc: [PATCH] Make lface_id_to_name an exact root
Previous Next
Full log
Message #8 received at 78812 <at> debbugs.gnu.org (full text, mbox):
"Helmut Eller" <eller.helmut <at> gmail.com> writes:
> This is a proposal to make the variable lface_id_to_name an exact root.
Thank you!
I'll apply this as it is, but I'd suggest one change, which I'd like to
quickly run by you:
Some of the code in igc_xpalloc_lisp_objs_exact handles item_size !=
word_size, and some doesn't. Would you prefer to remove the parameter
or change the code to handle multi-word items, which might be useful for
arrays of arrays of Lisp_Object?
I think we should add label arguments to all igc*alloc* functions. With
your patch, we don't see the lface-id-to-name root until the first time
it's been resized, and it would make more sense to see it right away.
There's the general problem of memcpy atomicity, but I don't have a
solution for that; the complicated code in xpalloc_exact is still
insufficient, so we might as well remove it.
While the ordinary memcpy function in glibc will always copy large
chunks, some debug builds use byte-based replacements, and then we have
a potential problem. This is particularly annoying because
stress-testing such builds by triggering collections from a background
thread might see false positive segfaults. I haven't seen one in
practice, but I use such tools very rarely.
Thanks again
Pip
This bug report was last modified 20 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.