GNU bug report logs - #78465
[PATCH] * src/lread.c (load): Try reuse the fd if it was opened in binary mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78465: closed ([PATCH] * src/lread.c (load): Try reuse the fd
 if it was opened in binary mode)
Date: Sun, 18 May 2025 05:18:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 18 May 2025 08:17:31 +0300
with message-id <86zffats44.fsf <at> gnu.org>
and subject line Re: bug#78465: [PATCH] * src/lread.c (load): Try reuse the fd if it was opened in binary mode
has caused the debbugs.gnu.org bug report #78465,
regarding [PATCH] * src/lread.c (load): Try reuse the fd if it was opened in binary mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78465: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78465
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Lin Sun <sunlin7 <at> hotmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] * src/lread.c (load): Try reuse the fd if it was opened in
 binary mode
Date: Sat, 17 May 2025 07:09:06 +0000

[Message part 3 (text/plain, inline)]

This patch will let Emacs avoid always close the fd then open the file with desired fmode in the "Fload" function on windows. It will reduce the counts on calling the "CreateFile" api.

On my dev windows environment, Emacs startup time reduces from 4.551s to 4.378s with 352 packages. 

[0001-src-lread.c-load-Try-reuse-the-fd-if-it-was-open-on-.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7 <at> hotmail.com>
Cc: 78465-done <at> debbugs.gnu.org
Subject: Re: bug#78465: [PATCH] * src/lread.c (load): Try reuse the fd if it
 was opened in binary mode
Date: Sun, 18 May 2025 08:17:31 +0300

> From: Lin Sun <sunlin7 <at> hotmail.com>
> CC: "78465 <at> debbugs.gnu.org" <78465 <at> debbugs.gnu.org>
> Date: Sun, 18 May 2025 03:20:51 +0000
> 
> From: Eli Zaretskii <eliz <at> gnu.org>
> Sent: Saturday, May 17, 2025 07:48 AM
> > Thanks, but I don't think we should install this.  fdopen on Windows
> > has all kinds of subtleties and idiosyncrasies, which is the reason
> > why we don't use fdopen here.  This code has seen several changes in
> > the past due to those problems, and I don't want to risk reintroducing
> > them again, certainly not for the benefit of a mere 3.8% reduction in
> > load time.  It just isn't worth the risk.
> 
> Thanks for your comment, and got your point. 
> Please feel free to close this ticket. Thank you!

Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.