GNU bug report logs - #78465
[PATCH] * src/lread.c (load): Try reuse the fd if it was opened in binary mode

Previous Next

Package: emacs;

Reported by: Lin Sun <sunlin7 <at> hotmail.com>

Date: Sat, 17 May 2025 07:10:02 UTC

Severity: normal

Tags: patch, wontfix

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 78465 in the body.
You can then email your comments to 78465 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#78465; Package emacs. (Sat, 17 May 2025 07:10:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Lin Sun <sunlin7 <at> hotmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 17 May 2025 07:10:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lin Sun <sunlin7 <at> hotmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] * src/lread.c (load): Try reuse the fd if it was opened in
 binary mode
Date: Sat, 17 May 2025 07:09:06 +0000

[Message part 1 (text/plain, inline)]
This patch will let Emacs avoid always close the fd then open the file with desired fmode in the "Fload" function on windows. It will reduce the counts on calling the "CreateFile" api.

On my dev windows environment, Emacs startup time reduces from 4.551s to 4.378s with 352 packages. 

[0001-src-lread.c-load-Try-reuse-the-fd-if-it-was-open-on-.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#78465; Package emacs. (Sat, 17 May 2025 07:49:02 GMT) Full text and rfc822 format available.

Message #8 received at 78465 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7 <at> hotmail.com>
Cc: 78465 <at> debbugs.gnu.org
Subject: Re: bug#78465: [PATCH] * src/lread.c (load): Try reuse the fd if it
 was opened in binary mode
Date: Sat, 17 May 2025 10:48:15 +0300

tags 78465 wontfix
thanks

> From: Lin Sun <sunlin7 <at> hotmail.com>
> Date: Sat, 17 May 2025 07:09:06 +0000
> msip_labels: 
> 
> This patch will let Emacs avoid always close the fd then open the file with desired fmode in the "Fload" function on windows. It will reduce the counts on calling the "CreateFile" api.
> 
> On my dev windows environment, Emacs startup time reduces from 4.551s to 4.378s with 352 packages. 

Thanks, but I don't think we should install this.  fdopen on Windows
has all kinds of subtleties and idiosyncrasies, which is the reason
why we don't use fdopen here.  This code has seen several changes in
the past due to those problems, and I don't want to risk reintroducing
them again, certainly not for the benefit of a mere 3.8% reduction in
load time.  It just isn't worth the risk.

Sorry.
Added tag(s) wontfix. Request was from Eli Zaretskii <eliz <at> gnu.org> to control <at> debbugs.gnu.org. (Sat, 17 May 2025 07:49:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#78465; Package emacs. (Sun, 18 May 2025 03:22:01 GMT) Full text and rfc822 format available.

Message #13 received at 78465 <at> debbugs.gnu.org (full text, mbox):

From: Lin Sun <sunlin7 <at> hotmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "78465 <at> debbugs.gnu.org" <78465 <at> debbugs.gnu.org>
Subject: Re: bug#78465: [PATCH] * src/lread.c (load): Try reuse the fd if it
 was opened in binary mode
Date: Sun, 18 May 2025 03:20:51 +0000

From: Eli Zaretskii <eliz <at> gnu.org>
Sent: Saturday, May 17, 2025 07:48 AM
> Thanks, but I don't think we should install this.  fdopen on Windows
> has all kinds of subtleties and idiosyncrasies, which is the reason
> why we don't use fdopen here.  This code has seen several changes in
> the past due to those problems, and I don't want to risk reintroducing
> them again, certainly not for the benefit of a mere 3.8% reduction in
> load time.  It just isn't worth the risk.

Thanks for your comment, and got your point. 
Please feel free to close this ticket. Thank you!
Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Sun, 18 May 2025 05:18:02 GMT) Full text and rfc822 format available.
Notification sent to Lin Sun <sunlin7 <at> hotmail.com>:
bug acknowledged by developer. (Sun, 18 May 2025 05:18:02 GMT) Full text and rfc822 format available.

Message #18 received at 78465-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7 <at> hotmail.com>
Cc: 78465-done <at> debbugs.gnu.org
Subject: Re: bug#78465: [PATCH] * src/lread.c (load): Try reuse the fd if it
 was opened in binary mode
Date: Sun, 18 May 2025 08:17:31 +0300

> From: Lin Sun <sunlin7 <at> hotmail.com>
> CC: "78465 <at> debbugs.gnu.org" <78465 <at> debbugs.gnu.org>
> Date: Sun, 18 May 2025 03:20:51 +0000
> 
> From: Eli Zaretskii <eliz <at> gnu.org>
> Sent: Saturday, May 17, 2025 07:48 AM
> > Thanks, but I don't think we should install this.  fdopen on Windows
> > has all kinds of subtleties and idiosyncrasies, which is the reason
> > why we don't use fdopen here.  This code has seen several changes in
> > the past due to those problems, and I don't want to risk reintroducing
> > them again, certainly not for the benefit of a mere 3.8% reduction in
> > load time.  It just isn't worth the risk.
> 
> Thanks for your comment, and got your point. 
> Please feel free to close this ticket. Thank you!

Closing.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 15 Jun 2025 11:24:11 GMT) Full text and rfc822 format available.
This bug report was last modified today.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.