GNU bug report logs - #78465
[PATCH] * src/lread.c (load): Try reuse the fd if it was opened in binary mode

Previous Next

Package: emacs;

Reported by: Lin Sun <sunlin7 <at> hotmail.com>

Date: Sat, 17 May 2025 07:10:02 UTC

Severity: normal

Tags: patch, wontfix

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lin Sun <sunlin7 <at> hotmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "78465 <at> debbugs.gnu.org" <78465 <at> debbugs.gnu.org>
Subject: bug#78465: [PATCH] * src/lread.c (load): Try reuse the fd if it was opened in binary mode
Date: Sun, 18 May 2025 03:20:51 +0000

From: Eli Zaretskii <eliz <at> gnu.org>
Sent: Saturday, May 17, 2025 07:48 AM
> Thanks, but I don't think we should install this.  fdopen on Windows
> has all kinds of subtleties and idiosyncrasies, which is the reason
> why we don't use fdopen here.  This code has seen several changes in
> the past due to those problems, and I don't want to risk reintroducing
> them again, certainly not for the benefit of a mere 3.8% reduction in
> load time.  It just isn't worth the risk.

Thanks for your comment, and got your point. 
Please feel free to close this ticket. Thank you!
This bug report was last modified today.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.