GNU bug report logs - #78463
[PATCH 2/2] news: Add news entry for new 'guix refresh' partial version syntax.

Previous Next

Package: guix-patches;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Sat, 17 May 2025 05:41:02 UTC

Severity: normal

Tags: patch

Merged with 78462

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

To reply to this bug, email your comments to 78463 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to pelzflorian <at> pelzflorian.de, julien <at> lepiller.eu, guix-patches <at> gnu.org:
bug#78463; Package guix-patches. (Sat, 17 May 2025 05:41:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
New bug report received and forwarded. Copy sent to pelzflorian <at> pelzflorian.de, julien <at> lepiller.eu, guix-patches <at> gnu.org. (Sat, 17 May 2025 05:41:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [PATCH 2/2] news: Add news entry for new 'guix refresh' partial
 version syntax.
Date: Sat, 17 May 2025 14:40:20 +0900
* etc/news.scm (channels-news): New entry.

Change-Id: Ic3be1bd62b4dc36a45fcbb1ae87c8a9bf0b837e9
---
 etc/news.scm | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/etc/news.scm b/etc/news.scm
index c70234ece7b..31684e53019 100644
--- a/etc/news.scm
+++ b/etc/news.scm
@@ -38,6 +38,22 @@
 (channel-news
  (version 0)
 
+ (entry (commit "XXX")
+        (title
+         (en "@samp{guix refresh} can now target partial versions"))
+        (body
+         (en "While it had been possible for some time to use the
+@option{--target-version} to update to a partially defined version, this can
+now be more conveniently expressed via the package version specification
+directly, by prefixing it with the tilde (@samp{~}) character:
+
+@example
+$ guix refresh bash=~5.2
+gnu/packages/bash.scm:150:15: bash would be upgraded from 5.1.16 to 5.2.37
+@end example
+
+For more information, see (info \"(guix) Invoking guix refresh\").")))
+
  (entry (commit "6e8ffdf3c5afac265e540027c2332573b25461ae")
         (title
          (en "Linux-libre 6.13 removed from Guix")
-- 
2.49.0





Forcibly Merged 78462 78463. Request was from Maxim Cournoyer <maxim.cournoyer <at> gmail.com> to control <at> debbugs.gnu.org. (Sat, 17 May 2025 05:45:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#78463; Package guix-patches. (Sun, 18 May 2025 14:45:02 GMT) Full text and rfc822 format available.

Message #10 received at 78463 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 78463 <at> debbugs.gnu.org, Julien Lepiller <julien <at> lepiller.eu>
Subject: Re: [bug#78463] [PATCH 2/2] news: Add news entry for new 'guix
 refresh' partial version syntax.
Date: Sun, 18 May 2025 16:43:05 +0200
[Message part 1 (text/plain, inline)]
A good change (untested).

It is not appropriate to write XXX: in comments on your first
patch’s unit tests, as I understand the Wiktionary definition of XXX:

2. (computing) Used as a placeholder in source code to mark that some work
still has to be done.


Could you add this German translation?
Additionally, I surrounded the info command in @command{} markup in the
last line of the English news, too.

[german-news-guix-refresh.scm (text/plain, inline)]
        (title
         (en "@samp{guix refresh} can now target partial versions")
         (de "@samp{guix refresh} kann jetzt unvollständige Versionen als Ziel
nehmen"))
        (body
         (en "While it had been possible for some time to use the
@option{--target-version} to update to a partially defined version, this can
now be more conveniently expressed via the package version specification
directly, by prefixing it with the tilde (@samp{~}) character:

@example
$ guix refresh bash=~5.2
gnu/packages/bash.scm:150:15: bash would be upgraded from 5.1.16 to 5.2.37
@end example

For more information, see @command{info \"(guix) Invoking guix refresh\"}.")
                  (de "Es war schon einige Zeit möglich, unter Angabe von
@option{--target-version} auf eine unvollständig definierte Version zu
aktualisieren; das lässt sich jetzt angenehmer ausdrücken, direkt in der
Paketversionsangabe, wenn Sie ihr das Tildezeichen (@samp{~}) voranstellen:

@example
$ guix refresh bash=~5.2
gnu/packages/bash.scm:150:15: bash würde von 5.1.16 auf 5.2.37 aktualisiert
@end example

Für mehr Informationen siehe @command{info \"(guix.de)Aufruf von guix
refresh\"}.")))
[Message part 3 (text/plain, inline)]

Regards,
Florian

Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Mon, 19 May 2025 01:12:02 GMT) Full text and rfc822 format available.

Notification sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
bug acknowledged by developer. (Mon, 19 May 2025 01:12:02 GMT) Full text and rfc822 format available.

Message #15 received at 78463-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 78463-done <at> debbugs.gnu.org
Subject: Re: [bug#78463] [PATCH 2/2] news: Add news entry for new 'guix
 refresh' partial version syntax.
Date: Mon, 19 May 2025 10:10:52 +0900
Hi Florian,

"pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de> writes:

> A good change (untested).
>
> It is not appropriate to write XXX: in comments on your first
> patch’s unit tests, as I understand the Wiktionary definition of XXX:
>
> 2. (computing) Used as a placeholder in source code to mark that some work
> still has to be done.

That's close to the meaning I use it for: something inelegant or dirty,
that would better be rewritten if someone knows better.  In other words,
it's functional but not ideal/hacky.  To mark some work that would need
doing in the future, I'd use a TODO instead.

I'm not sure if that's the most correct definition, but that's at least
how I've always understood it to be used in the Guix code base, e.g. by
Ludovic.

> Could you add this German translation?

Done, thank you!

> Additionally, I surrounded the info command in @command{} markup in the
> last line of the English news, too.
>
>         (title
>          (en "@samp{guix refresh} can now target partial versions")
>          (de "@samp{guix refresh} kann jetzt unvollständige Versionen als Ziel
> nehmen"))
>         (body
>          (en "While it had been possible for some time to use the
> @option{--target-version} to update to a partially defined version, this can
> now be more conveniently expressed via the package version specification
> directly, by prefixing it with the tilde (@samp{~}) character:
>
> @example
> $ guix refresh bash=~5.2
> gnu/packages/bash.scm:150:15: bash would be upgraded from 5.1.16 to 5.2.37
> @end example
>
> For more information, see @command{info \"(guix) Invoking guix refresh\"}.")

It doesn't seem to be explained in the Texinfo manual, but @command is
really only supposed to be used with a single word/command, not a
command line.  For the later @samp should be used instead.  That's
explained in (info "(texinfo) @command").

In this case though, I meant it to be this way: I've recently discovered
that when visiting a Texinfo node in a manual in Emacs, you can copy the
reference to it with 'C-0 c', then paste it somewhere.  Emacs users can
then jump straight to it by evaluating it with C-x C-e (with the cursor
placed after the closing parens).  I recently found that trick, I think
it's neat!  I seem to recall that Gnus also had a means to linkify such
references directly in email.

Thanks for the review and translation, as well as to Ludovic's.

Pushed with commit 450a3615325.  Closing.

-- 
Thanks,
Maxim




Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Mon, 19 May 2025 01:12:03 GMT) Full text and rfc822 format available.

Notification sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
bug acknowledged by developer. (Mon, 19 May 2025 01:12:03 GMT) Full text and rfc822 format available.

This bug report was last modified 27 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.