GNU bug report logs - #78008
[PATCH] 31.0.50; csharp-ts-mode does not highlight string-interpolation expressions correctly

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Subject: bug#78008: closed (Re: bug#78008: [PATCH] 31.0.50; csharp-ts-mode
 does not highlight string-interpolation expressions correctly)
Date: Sat, 26 Apr 2025 13:28:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#78008: [PATCH] 31.0.50; csharp-ts-mode does not highlight string-interpolation expressions correctly

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 78008 <at> debbugs.gnu.org.

-- 
78008: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78008
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: 78008-done <at> debbugs.gnu.org
Subject: Re: bug#78008: [PATCH] 31.0.50;
 csharp-ts-mode does not highlight string-interpolation expressions
 correctly
Date: Sat, 26 Apr 2025 16:26:54 +0300

> From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
> Date: Wed, 23 Apr 2025 10:37:09 +0200
> 
> Using csharp-ts-mode, string-interpolation expressions correctly. Basically the entire string-interpolation expression is fontified as a continuous string.
> 
> This seems to be caused be a few selectors which are too wide, capturing non-string content, and a mix of missing selectors as well.
> 
> Attached is a patch which fixes this.

Thanks, now installed on the master branch, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 31.0.50; csharp-ts-mode does not highlight
 string-interpolation expressions correctly
Date: Wed, 23 Apr 2025 10:37:09 +0200

[Message part 4 (text/plain, inline)]

Hey everyone!

Using csharp-ts-mode, string-interpolation expressions correctly. Basically the entire string-interpolation expression is fontified as a continuous string.

This seems to be caused be a few selectors which are too wide, capturing non-string content, and a mix of missing selectors as well.

Attached is a patch which fixes this.

—
Kind Regards
Jostein Kjønigsen



[Message part 5 (text/html, inline)]

[0001-csharp-mode.el-Improve-fontification-of-string-inter.patch (application/octet-stream, attachment)]

[Message part 7 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.