GNU bug report logs - #78008
[PATCH] 31.0.50; csharp-ts-mode does not highlight string-interpolation expressions correctly

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 78008 in the body.
You can then email your comments to 78008 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 31.0.50; csharp-ts-mode does not highlight
 string-interpolation expressions correctly
Date: Wed, 23 Apr 2025 10:37:09 +0200

[Message part 1 (text/plain, inline)]

Hey everyone!

Using csharp-ts-mode, string-interpolation expressions correctly. Basically the entire string-interpolation expression is fontified as a continuous string.

This seems to be caused be a few selectors which are too wide, capturing non-string content, and a mix of missing selectors as well.

Attached is a patch which fixes this.

—
Kind Regards
Jostein Kjønigsen



[Message part 2 (text/html, inline)]

[0001-csharp-mode.el-Improve-fontification-of-string-inter.patch (application/octet-stream, attachment)]

[Message part 4 (text/html, inline)]

Message #10 received at 78008-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: 78008-done <at> debbugs.gnu.org
Subject: Re: bug#78008: [PATCH] 31.0.50;
 csharp-ts-mode does not highlight string-interpolation expressions
 correctly
Date: Sat, 26 Apr 2025 16:26:54 +0300

> From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
> Date: Wed, 23 Apr 2025 10:37:09 +0200
> 
> Using csharp-ts-mode, string-interpolation expressions correctly. Basically the entire string-interpolation expression is fontified as a continuous string.
> 
> This seems to be caused be a few selectors which are too wide, capturing non-string content, and a mix of missing selectors as well.
> 
> Attached is a patch which fixes this.

Thanks, now installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.