GNU bug report logs - #77967
[PATCH] Fallback `eww-switch-to-buffer' to `eww'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#77967: closed ([PATCH] Fallback `eww-switch-to-buffer' to `eww')
Date: Sat, 10 May 2025 09:48:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 10 May 2025 12:47:49 +0300
with message-id <86wmaoajay.fsf <at> gnu.org>
and subject line Re: bug#77967: [PATCH] Fallback `eww-switch-to-buffer' to `eww'
has caused the debbugs.gnu.org bug report #77967,
regarding [PATCH] Fallback `eww-switch-to-buffer' to `eww'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
77967: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77967
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fallback `eww-switch-to-buffer' to `eww'
Date: Mon, 21 Apr 2025 19:43:47 +0200

[Message part 3 (text/plain, inline)]

Tags: patch

Hi,

The following patch calls `eww' interactively from
`eww-switch-to-buffer' when there is no EWW buffers.  Then, one can set
a global shortcut on `eww-switch-to-buffer' and always be able to launch
EWW.

Thanks,


In GNU Emacs 31.0.50 (build 5, x86_64-unknown-openbsd7.7, X toolkit) of
 2025-04-20 built on computer
Repository revision: b38fd553eb3291f140801ca158f6ab245496fa69
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101016
System Description: OpenBSD computer 7.7 GENERIC.MP#625 amd64

Configured using:
 'configure CC=egcc CPPFLAGS=-I/usr/local/include
 LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=lucid
 --with-toolkit-scroll-bars=no --without-cairo
 --without-compress-install'

[0001-Fallback-eww-switch-to-buffer-to-eww.patch (text/patch, attachment)]

[Message part 5 (text/plain, inline)]

-- 
Manuel Giraud

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: larsi <at> gnus.org, 77967-done <at> debbugs.gnu.org
Subject: Re: bug#77967: [PATCH] Fallback `eww-switch-to-buffer' to `eww'
Date: Sat, 10 May 2025 12:47:49 +0300

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: 77967 <at> debbugs.gnu.org,  larsi <at> gnus.org
> Date: Sun, 27 Apr 2025 13:08:57 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
> >> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> >> Date: Mon, 21 Apr 2025 19:43:47 +0200
> >> 
> >> The following patch calls `eww' interactively from
> >> `eww-switch-to-buffer' when there is no EWW buffers.  Then, one can set
> >> a global shortcut on `eww-switch-to-buffer' and always be able to launch
> >> EWW.
> >
> > Thanks.
> >
> >>  (defun eww-switch-to-buffer ()
> >> -  "Prompt for an EWW buffer to display in the selected window."
> >> +  "Prompt for an EWW buffer to display in the selected window.  If no such
> >> +buffer exist, fallback to calling `eww'."
> >
> > The first line of a doc string should be a single complete sentence.
> >
> > Doesn't this change warrant a NEWS entry, and a suitable change to the
> > EWW manual?
> 
> Thanks.  Here is a new patch.  While here, I also modified
> `eww-list-buffers' to not pop to *eww-buffers* when there is no such
> buffer.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.