GNU bug report logs - #77967
[PATCH] Fallback `eww-switch-to-buffer' to `eww'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77967 in the body.
You can then email your comments to 77967 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fallback `eww-switch-to-buffer' to `eww'
Date: Mon, 21 Apr 2025 19:43:47 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

Hi,

The following patch calls `eww' interactively from
`eww-switch-to-buffer' when there is no EWW buffers.  Then, one can set
a global shortcut on `eww-switch-to-buffer' and always be able to launch
EWW.

Thanks,


In GNU Emacs 31.0.50 (build 5, x86_64-unknown-openbsd7.7, X toolkit) of
 2025-04-20 built on computer
Repository revision: b38fd553eb3291f140801ca158f6ab245496fa69
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101016
System Description: OpenBSD computer 7.7 GENERIC.MP#625 amd64

Configured using:
 'configure CC=egcc CPPFLAGS=-I/usr/local/include
 LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=lucid
 --with-toolkit-scroll-bars=no --without-cairo
 --without-compress-install'

[0001-Fallback-eww-switch-to-buffer-to-eww.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Message #8 received at 77967 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 77967 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#77967: [PATCH] Fallback `eww-switch-to-buffer' to `eww'
Date: Sat, 26 Apr 2025 16:02:08 +0300

> Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Date: Mon, 21 Apr 2025 19:43:47 +0200
> 
> The following patch calls `eww' interactively from
> `eww-switch-to-buffer' when there is no EWW buffers.  Then, one can set
> a global shortcut on `eww-switch-to-buffer' and always be able to launch
> EWW.

Thanks.

>  (defun eww-switch-to-buffer ()
> -  "Prompt for an EWW buffer to display in the selected window."
> +  "Prompt for an EWW buffer to display in the selected window.  If no such
> +buffer exist, fallback to calling `eww'."

The first line of a doc string should be a single complete sentence.

Doesn't this change warrant a NEWS entry, and a suitable change to the
EWW manual?

Message #11 received at 77967 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 77967 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#77967: [PATCH] Fallback `eww-switch-to-buffer' to `eww'
Date: Sun, 27 Apr 2025 13:08:57 +0200

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
>> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
>> Date: Mon, 21 Apr 2025 19:43:47 +0200
>> 
>> The following patch calls `eww' interactively from
>> `eww-switch-to-buffer' when there is no EWW buffers.  Then, one can set
>> a global shortcut on `eww-switch-to-buffer' and always be able to launch
>> EWW.
>
> Thanks.
>
>>  (defun eww-switch-to-buffer ()
>> -  "Prompt for an EWW buffer to display in the selected window."
>> +  "Prompt for an EWW buffer to display in the selected window.  If no such
>> +buffer exist, fallback to calling `eww'."
>
> The first line of a doc string should be a single complete sentence.
>
> Doesn't this change warrant a NEWS entry, and a suitable change to the
> EWW manual?

Thanks.  Here is a new patch.  While here, I also modified
`eww-list-buffers' to not pop to *eww-buffers* when there is no such
buffer.

[0001-Fallback-eww-switch-to-buffer-to-eww.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Message #16 received at 77967-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: larsi <at> gnus.org, 77967-done <at> debbugs.gnu.org
Subject: Re: bug#77967: [PATCH] Fallback `eww-switch-to-buffer' to `eww'
Date: Sat, 10 May 2025 12:47:49 +0300

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: 77967 <at> debbugs.gnu.org,  larsi <at> gnus.org
> Date: Sun, 27 Apr 2025 13:08:57 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
> >> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> >> Date: Mon, 21 Apr 2025 19:43:47 +0200
> >> 
> >> The following patch calls `eww' interactively from
> >> `eww-switch-to-buffer' when there is no EWW buffers.  Then, one can set
> >> a global shortcut on `eww-switch-to-buffer' and always be able to launch
> >> EWW.
> >
> > Thanks.
> >
> >>  (defun eww-switch-to-buffer ()
> >> -  "Prompt for an EWW buffer to display in the selected window."
> >> +  "Prompt for an EWW buffer to display in the selected window.  If no such
> >> +buffer exist, fallback to calling `eww'."
> >
> > The first line of a doc string should be a single complete sentence.
> >
> > Doesn't this change warrant a NEWS entry, and a suitable change to the
> > EWW manual?
> 
> Thanks.  Here is a new patch.  While here, I also modified
> `eww-list-buffers' to not pop to *eww-buffers* when there is no such
> buffer.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.