GNU bug report logs -
#77915
[PATCH 0/2] Add cpdf
Previous Next
Reported by: Jussi Timperi <jussi.timperi <at> iki.fi>
Date: Sat, 19 Apr 2025 05:38:03 UTC
Severity: normal
Tags: patch
Done: Andreas Enge <andreas <at> enge.fr>
Bug is archived. No further changes may be made.
Full log
Message #14 received at 77915 <at> debbugs.gnu.org (full text, mbox):
Hi Jussi,
sáb 19 abr 2025 às 08:43:15 (1745062995), jussi.timperi <at> iki.fi enviou:
> (...)
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "1cbqgwh62cqnsbax4k4iv9gb63k1v545izmbffxj8gj1q6sm0k34"))))
> + (build-system ocaml-build-system)
> + (arguments
> + (list
> + #:tests? #f ;no tests
> + #:make-flags
> + #~(list (string-append "CC=" #$(cc-for-target)))
These should be indented relative to the #:make-flags key, so that we can
see that they are arguments to it by just a glance to the code. Two spaces
should be enough.
> + #:phases
> + #~(modify-phases %standard-phases
Same as above.
> + (delete 'configure)
> + (add-after 'unpack 'patch-makefile-shell
> + (lambda _
> + (patch-makefile-SHELL "OCamlMakefile")))
> + (add-after 'install 'install-doc
> + (lambda _
> + (let ((doc (string-append #$output "/share/doc/"
> + #$name "-" #$version)))
> + (copy-recursively "doc/camlpdf/html"
> + (string-append doc "/html"))))))))
> + (home-page "https://github.com/johnwhitington/camlpdf")
> + (synopsis "OCaml library for PDF file manipulation")
> + (description
> + "CamlPDF is an OCaml library that provides functionality for reading,
> +writing, and modifying PDF files. It serves as the foundation for the
> +@command{cpdf} command-line tool and various API bindings.")
> + (license license:lgpl2.1+)))
> +
> (define-public ocaml-cudf
> (package
> (name "ocaml-cudf")
> --
> 2.49.0
On cpdf there are similar indentation issues. Other than that LGTM. I've
successfuly build and made minimal testing.
Could you send a v2 patch fixing the indentation?
Cheers!
This bug report was last modified 25 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.