GNU bug report logs - #77915
[PATCH 0/2] Add cpdf

Previous Next

To reply to this bug, email your comments to 77915 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jussi Timperi <jussi.timperi <at> iki.fi>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Add cpdf
Date: Sat, 19 Apr 2025 08:36:35 +0300

Jussi Timperi (2):
  gnu: Add ocaml-camlpdf.
  gnu: Add cpdf.

 gnu/packages/ocaml.scm | 40 ++++++++++++++++++++
 gnu/packages/pdf.scm   | 85 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 125 insertions(+)


base-commit: a4a7ff0319c622cd08aa7461cc88cc6608fe62cb
-- 
2.49.0

Message #8 received at 77915 <at> debbugs.gnu.org (full text, mbox):

From: Jussi Timperi <jussi.timperi <at> iki.fi>
To: 77915 <at> debbugs.gnu.org
Cc: Jussi Timperi <jussi.timperi <at> iki.fi>
Subject: [PATCH 1/2] gnu: Add ocaml-camlpdf.
Date: Sat, 19 Apr 2025 08:43:15 +0300

* gnu/packages/ocaml.scm (ocaml-camlpdf): New variable.

Change-Id: I097280bdd16eaf810f83fbca13f615a03e4d6702
---
 gnu/packages/ocaml.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index a5632c6ad1..b4813c5049 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -31,6 +31,7 @@
 ;;; Copyright © 2023, 2024 Foundation Devices, Inc. <hello <at> foundation.xyz>
 ;;; Copyright © 2023 Arnaud DABY-SEESARAM <ds-ac <at> nanein.fr>
 ;;; Copyright © 2024 Sören Tempel <soeren <at> soeren-tempel.net>
+;;; Copyright © 2025 Jussi Timperi <jussi.timperi <at> iki.fi>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -659,6 +660,45 @@ (define-public ocaml-extlib
     ;; With static-linking exception
     (license license:lgpl2.1+)))
 
+(define-public ocaml-camlpdf
+  (package
+    (name "ocaml-camlpdf")
+    (version "2.8.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/johnwhitington/camlpdf")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1cbqgwh62cqnsbax4k4iv9gb63k1v545izmbffxj8gj1q6sm0k34"))))
+    (build-system ocaml-build-system)
+    (arguments
+     (list
+      #:tests? #f ;no tests
+      #:make-flags
+      #~(list (string-append "CC=" #$(cc-for-target)))
+      #:phases
+      #~(modify-phases %standard-phases
+          (delete 'configure)
+          (add-after 'unpack 'patch-makefile-shell
+            (lambda _
+              (patch-makefile-SHELL "OCamlMakefile")))
+          (add-after 'install 'install-doc
+            (lambda _
+              (let ((doc (string-append #$output "/share/doc/"
+                                        #$name "-" #$version)))
+                (copy-recursively "doc/camlpdf/html"
+                                  (string-append doc "/html"))))))))
+    (home-page "https://github.com/johnwhitington/camlpdf")
+    (synopsis "OCaml library for PDF file manipulation")
+    (description
+     "CamlPDF is an OCaml library that provides functionality for reading,
+writing, and modifying PDF files.  It serves as the foundation for the
+@command{cpdf} command-line tool and various API bindings.")
+    (license license:lgpl2.1+)))
+
 (define-public ocaml-cudf
   (package
     (name "ocaml-cudf")
-- 
2.49.0

Message #11 received at 77915 <at> debbugs.gnu.org (full text, mbox):

From: Jussi Timperi <jussi.timperi <at> iki.fi>
To: 77915 <at> debbugs.gnu.org
Cc: Jussi Timperi <jussi.timperi <at> iki.fi>
Subject: [PATCH 2/2] gnu: Add cpdf.
Date: Sat, 19 Apr 2025 08:43:16 +0300

* gnu/packages/pdf.scm (cpdf): New variable.

Change-Id: I16fa4bf7251f5d38bdd14f472adeef513c34623c
---
 gnu/packages/pdf.scm | 85 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 85 insertions(+)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 6340f9b3bf..6de03e6e03 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2023 Benjamin Slade <slade <at> lambda-y.net>
 ;;; Copyright © 2024 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
 ;;; Copyright © 2024 Aaron Covrig <aaron.covrig.us <at> ieee.org>
+;;; Copyright © 2025 Jussi Timperi <jussi.timperi <at> iki.fi>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -56,6 +57,7 @@ (define-module (gnu packages pdf)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system meson)
+  #:use-module (guix build-system ocaml)
   #:use-module (guix build-system pyproject)
   #:use-module (guix build-system python)
   #:use-module (guix build-system qt)
@@ -95,6 +97,7 @@ (define-module (gnu packages pdf)
   #:use-module (gnu packages man)
   #:use-module (gnu packages markup)
   #:use-module (gnu packages nss)
+  #:use-module (gnu packages ocaml)
   #:use-module (gnu packages ocr)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages perl)
@@ -159,6 +162,88 @@ (define-public capypdf
 convert data in any way.")
     (license license:asl2.0)))
 
+(define-public cpdf
+  (package
+    (name "cpdf")
+    (version "2.8.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/johnwhitington/cpdf-source")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0dn4lxbnj7izrpxshil1wcvpc60yv9mwfy52dndpi9b66rm3rbih"))))
+    (build-system ocaml-build-system)
+    (arguments
+     (list
+      #:tests? #f ;no tests
+      #:phases
+      #~(modify-phases %standard-phases
+          (delete 'configure)
+          (add-after 'unpack 'patch-makefile-shell
+            (lambda _
+              (patch-makefile-SHELL "OCamlMakefile")))
+          (add-after 'install 'install-bin
+            (lambda _
+              (let ((bin (string-append #$output "/bin")))
+                (install-file "cpdf" bin))))
+          (add-after 'install-bin 'install-doc
+            (lambda _
+              (let ((doc (string-append #$output "/share/doc/"
+                                        #$name "-" #$version))
+                    (man1 (string-append #$output "/share/man/man1")))
+                (install-file "cpdf.1" man1)
+                (install-file "cpdfmanual.pdf" doc)
+                (copy-recursively "doc/cpdf/html"
+                                  (string-append doc "/html"))))))))
+    (propagated-inputs (list ocaml-camlpdf))
+    (home-page "https://www.coherentpdf.com")
+    (synopsis "Command-line tool for PDF manipulation")
+    (description
+     "Command-line tool and OCaml library designed for manipulating PDF
+documents.  Key Features include:
+
+@itemize @bullet
+@item
+Splitting and merging PDF files (including bookmark preservation and
+splitting on bookmarks).
+@item
+Encryption and decryption (supports AES 128 and AES 256).
+@item
+Page manipulation: scaling, rotation, cropping, and flipping; fitting
+pages to a specific size.
+@item
+Bookmark management: copying, removing, and adding bookmarks.
+@item
+Watermarking: stamping logos, page numbers, and multi-line text with
+transparency support.
+@item
+Text and font handling: embedding TrueType fonts, supporting Unicode
+UTF-8 input and output, and converting text to PDF.
+@item
+Presentation features: creating PDF-based presentations and arranging
+multiple pages on a single page.
+@item
+Annotation management: listing, copying, setting, and removing
+annotations.
+@item
+Metadata management: reading and setting document information and
+metadata.
+@item
+Attachment handling: adding and removing file attachments to documents
+or pages.
+@item
+Advanced features: thickening hairlines, blackening text,
+reconstructing malformed files, detecting missing fonts and
+low-resolution images, exporting/importing in JSON format, and
+building table of contents.
+@item
+Drawing: Adding graphics and text directly onto PDF files.
+@end itemize")
+    (license license:agpl3+)))
+
 (define-public a4pdf
   (deprecated-package "a4pdf" capypdf))
 
-- 
2.49.0

Message #14 received at 77915 <at> debbugs.gnu.org (full text, mbox):

From: André Batista <nandre <at> riseup.net>
To: Jussi Timperi <jussi.timperi <at> iki.fi>
Cc: pukkamustard <pukkamustard <at> posteo.net>,
 Julien Lepiller <julien <at> lepiller.eu>, 77915 <at> debbugs.gnu.org
Subject: Re: [bug#77915] [PATCH 1/2] gnu: Add ocaml-camlpdf.
Date: Fri, 16 May 2025 17:09:05 -0300

Hi Jussi,

sáb 19 abr 2025 às 08:43:15 (1745062995), jussi.timperi <at> iki.fi enviou:
> (...)
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "1cbqgwh62cqnsbax4k4iv9gb63k1v545izmbffxj8gj1q6sm0k34"))))
> +    (build-system ocaml-build-system)
> +    (arguments
> +     (list
> +      #:tests? #f ;no tests
> +      #:make-flags
> +      #~(list (string-append "CC=" #$(cc-for-target)))

These should be indented relative to the #:make-flags key, so that we can
see that they are arguments to it by just a glance to the code.  Two spaces
should be enough.

> +      #:phases
> +      #~(modify-phases %standard-phases

Same as above.

> +          (delete 'configure)
> +          (add-after 'unpack 'patch-makefile-shell
> +            (lambda _
> +              (patch-makefile-SHELL "OCamlMakefile")))
> +          (add-after 'install 'install-doc
> +            (lambda _
> +              (let ((doc (string-append #$output "/share/doc/"
> +                                        #$name "-" #$version)))
> +                (copy-recursively "doc/camlpdf/html"
> +                                  (string-append doc "/html"))))))))
> +    (home-page "https://github.com/johnwhitington/camlpdf")
> +    (synopsis "OCaml library for PDF file manipulation")
> +    (description
> +     "CamlPDF is an OCaml library that provides functionality for reading,
> +writing, and modifying PDF files.  It serves as the foundation for the
> +@command{cpdf} command-line tool and various API bindings.")
> +    (license license:lgpl2.1+)))
> +
>  (define-public ocaml-cudf
>    (package
>      (name "ocaml-cudf")
> -- 
> 2.49.0

On cpdf there are similar indentation issues.  Other than that LGTM.  I've
successfuly build and made minimal testing.

Could you send a v2 patch fixing the indentation?

Cheers!

Message #17 received at 77915 <at> debbugs.gnu.org (full text, mbox):

From: Jussi Timperi <jussi.timperi <at> iki.fi>
To: André Batista <nandre <at> riseup.net>
Cc: pukkamustard <pukkamustard <at> posteo.net>,
 Julien Lepiller <julien <at> lepiller.eu>, 77915 <at> debbugs.gnu.org
Subject: Re: [bug#77915] [PATCH 1/2] gnu: Add ocaml-camlpdf.
Date: Tue, 27 May 2025 14:49:48 +0300

Hi André,

On 16 May 2025 17:09, André Batista <nandre <at> riseup.net> wrote:

> Could you send a v2 patch fixing the indentation?

Thanks for the review. I'll send the v2 with the fixed indentation.

Best,
--
Jussi

Message #20 received at 77915 <at> debbugs.gnu.org (full text, mbox):

From: Jussi Timperi <jussi.timperi <at> iki.fi>
To: 77915 <at> debbugs.gnu.org
Cc: Jussi Timperi <jussi.timperi <at> iki.fi>
Subject: [PATCH v2 1/2] gnu: Add ocaml-camlpdf.
Date: Tue, 27 May 2025 14:56:43 +0300

* gnu/packages/ocaml.scm (ocaml-camlpdf): New variable.

Change-Id: I097280bdd16eaf810f83fbca13f615a03e4d6702
---
 gnu/packages/ocaml.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 01aef23b2a..f6178ffbff 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -31,6 +31,7 @@
 ;;; Copyright © 2023, 2024 Foundation Devices, Inc. <hello <at> foundation.xyz>
 ;;; Copyright © 2023 Arnaud DABY-SEESARAM <ds-ac <at> nanein.fr>
 ;;; Copyright © 2024 Sören Tempel <soeren <at> soeren-tempel.net>
+;;; Copyright © 2025 Jussi Timperi <jussi.timperi <at> iki.fi>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -659,6 +660,45 @@ (define-public ocaml-extlib
     ;; With static-linking exception
     (license license:lgpl2.1+)))
 
+(define-public ocaml-camlpdf
+  (package
+    (name "ocaml-camlpdf")
+    (version "2.8.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/johnwhitington/camlpdf")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1cbqgwh62cqnsbax4k4iv9gb63k1v545izmbffxj8gj1q6sm0k34"))))
+    (build-system ocaml-build-system)
+    (arguments
+     (list
+      #:tests? #f ;no tests
+      #:make-flags
+        #~(list (string-append "CC=" #$(cc-for-target)))
+      #:phases
+        #~(modify-phases %standard-phases
+            (delete 'configure)
+            (add-after 'unpack 'patch-makefile-shell
+              (lambda _
+                (patch-makefile-SHELL "OCamlMakefile")))
+            (add-after 'install 'install-doc
+              (lambda _
+                (let ((doc (string-append #$output "/share/doc/"
+                                          #$name "-" #$version)))
+                  (copy-recursively "doc/camlpdf/html"
+                                    (string-append doc "/html"))))))))
+    (home-page "https://github.com/johnwhitington/camlpdf")
+    (synopsis "OCaml library for PDF file manipulation")
+    (description
+     "CamlPDF is an OCaml library that provides functionality for reading,
+writing, and modifying PDF files.  It serves as the foundation for the
+@command{cpdf} command-line tool and various API bindings.")
+    (license license:lgpl2.1+)))
+
 (define-public ocaml-cudf
   (package
     (name "ocaml-cudf")

base-commit: da5d2b382e8db08fd8a99c4d14f2c8c2ef0150da
-- 
2.49.0

Message #23 received at 77915 <at> debbugs.gnu.org (full text, mbox):

From: Jussi Timperi <jussi.timperi <at> iki.fi>
To: 77915 <at> debbugs.gnu.org
Cc: Jussi Timperi <jussi.timperi <at> iki.fi>
Subject: [PATCH v2 2/2] gnu: Add cpdf.
Date: Tue, 27 May 2025 14:56:44 +0300

* gnu/packages/pdf.scm (cpdf): New variable.

Change-Id: I16fa4bf7251f5d38bdd14f472adeef513c34623c
---
 gnu/packages/pdf.scm | 85 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 85 insertions(+)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 3e43b2c0fe..929901e55d 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2023 Benjamin Slade <slade <at> lambda-y.net>
 ;;; Copyright © 2024 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
 ;;; Copyright © 2024 Aaron Covrig <aaron.covrig.us <at> ieee.org>
+;;; Copyright © 2025 Jussi Timperi <jussi.timperi <at> iki.fi>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -56,6 +57,7 @@ (define-module (gnu packages pdf)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system meson)
+  #:use-module (guix build-system ocaml)
   #:use-module (guix build-system pyproject)
   #:use-module (guix build-system python)
   #:use-module (guix build-system qt)
@@ -95,6 +97,7 @@ (define-module (gnu packages pdf)
   #:use-module (gnu packages man)
   #:use-module (gnu packages markup)
   #:use-module (gnu packages nss)
+  #:use-module (gnu packages ocaml)
   #:use-module (gnu packages ocr)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages perl)
@@ -159,6 +162,88 @@ (define-public capypdf
 convert data in any way.")
     (license license:asl2.0)))
 
+(define-public cpdf
+  (package
+    (name "cpdf")
+    (version "2.8.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/johnwhitington/cpdf-source")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0dn4lxbnj7izrpxshil1wcvpc60yv9mwfy52dndpi9b66rm3rbih"))))
+    (build-system ocaml-build-system)
+    (arguments
+     (list
+      #:tests? #f ;no tests
+      #:phases
+        #~(modify-phases %standard-phases
+            (delete 'configure)
+            (add-after 'unpack 'patch-makefile-shell
+              (lambda _
+                (patch-makefile-SHELL "OCamlMakefile")))
+            (add-after 'install 'install-bin
+              (lambda _
+                (let ((bin (string-append #$output "/bin")))
+                  (install-file "cpdf" bin))))
+            (add-after 'install-bin 'install-doc
+              (lambda _
+                (let ((doc (string-append #$output "/share/doc/"
+                                          #$name "-" #$version))
+                      (man1 (string-append #$output "/share/man/man1")))
+                  (install-file "cpdf.1" man1)
+                  (install-file "cpdfmanual.pdf" doc)
+                  (copy-recursively "doc/cpdf/html"
+                                    (string-append doc "/html"))))))))
+    (propagated-inputs (list ocaml-camlpdf))
+    (home-page "https://www.coherentpdf.com")
+    (synopsis "Command-line tool for PDF manipulation")
+    (description
+     "Command-line tool and OCaml library designed for manipulating PDF
+documents.  Key Features include:
+
+@itemize @bullet
+@item
+Splitting and merging PDF files (including bookmark preservation and
+splitting on bookmarks).
+@item
+Encryption and decryption (supports AES 128 and AES 256).
+@item
+Page manipulation: scaling, rotation, cropping, and flipping; fitting
+pages to a specific size.
+@item
+Bookmark management: copying, removing, and adding bookmarks.
+@item
+Watermarking: stamping logos, page numbers, and multi-line text with
+transparency support.
+@item
+Text and font handling: embedding TrueType fonts, supporting Unicode
+UTF-8 input and output, and converting text to PDF.
+@item
+Presentation features: creating PDF-based presentations and arranging
+multiple pages on a single page.
+@item
+Annotation management: listing, copying, setting, and removing
+annotations.
+@item
+Metadata management: reading and setting document information and
+metadata.
+@item
+Attachment handling: adding and removing file attachments to documents
+or pages.
+@item
+Advanced features: thickening hairlines, blackening text,
+reconstructing malformed files, detecting missing fonts and
+low-resolution images, exporting/importing in JSON format, and
+building table of contents.
+@item
+Drawing: Adding graphics and text directly onto PDF files.
+@end itemize")
+    (license license:agpl3+)))
+
 (define-public a4pdf
   (deprecated-package "a4pdf" capypdf))
 
-- 
2.49.0

Message #26 received at 77915 <at> debbugs.gnu.org (full text, mbox):

From: André Batista <nandre <at> riseup.net>
To: Jussi Timperi <jussi.timperi <at> iki.fi>
Cc: pukkamustard <pukkamustard <at> posteo.net>,
 Julien Lepiller <julien <at> lepiller.eu>, control <at> debbugs.gnu.org,
 77915 <at> debbugs.gnu.org
Subject: Re: [bug#77915] [PATCH 1/2] gnu: Add ocaml-camlpdf.
Date: Tue, 27 May 2025 12:20:26 -0300

usertag 77915 reviewed-looks-good
quit

Hi Jussi,

ter 27 mai 2025 às 14:49:48 (1748368188), jussi.timperi <at> iki.fi enviou:
> Hi André,
> 
> On 16 May 2025 17:09, André Batista <nandre <at> riseup.net> wrote:
> 
> > Could you send a v2 patch fixing the indentation?
> 
> Thanks for the review. I'll send the v2 with the fixed indentation.
> 

After sending that review, I saw others indenting like you did and
indeed I've found out that that seems to be correct by guix standards.

Sorry for the noise, I've mixed my personal preference with what guix
actually do.  So you can disregard that.

I've tagged this patch as reviewed and you don't need to send a v2.

Thanks!

Message #31 received at 77915-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Jussi Timperi <jussi.timperi <at> iki.fi>
Cc: 77915-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2 1/2] gnu: Add ocaml-camlpdf.
Date: Mon, 2 Jun 2025 16:12:15 +0200

Pushed, thanks!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.