GNU bug report logs - #77823
31.0.50; M-j regression since commit 4c6b1712a4d

Previous Next

Package: emacs;

Reported by: Sean Whitton <spwhitton <at> spwhitton.name>

Date: Tue, 15 Apr 2025 11:29:02 UTC

Severity: normal

Found in version 31.0.50

Done: Sean Whitton <spwhitton <at> spwhitton.name>

Bug is archived. No further changes may be made.

Full log


Message #21 received at 77823 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: eliz <at> gnu.org, 77823 <at> debbugs.gnu.org,
 Elijah Gabe Pérez <eg642616 <at> gmail.com>
Subject: Re: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d
Date: Wed, 16 Apr 2025 09:49:42 +0800
Hello,

On Tue 15 Apr 2025 at 06:55pm -06, Elijah Gabe Pérez wrote:

> I found the issue, `comment-indent' was using both block-comment
> variables first than `comment-start' and `comment-end', this must fix it.
>
> diff --git a/lisp/newcomment.el b/lisp/newcomment.el
> index eb36f91104d..3e20da816b9 100644
> --- a/lisp/newcomment.el
> +++ b/lisp/newcomment.el
> @@ -722,9 +722,9 @@ comment-indent
>    (let* ((empty (save-excursion (beginning-of-line)
>  				(looking-at "[ \t]*$")))
>  	 (starter (or (and continue comment-continue)
> -		      (and empty block-comment-start) comment-start))
> +		      comment-start (and empty block-comment-start)))
>  	 (ender (or (and continue comment-continue "")
> -		    (and empty block-comment-end) comment-end)))
> +		    comment-end (and empty block-comment-end))))
>      (unless starter (error "No comment syntax defined"))
>      (beginning-of-line)
>      (let* ((eolpos (line-end-position))

Thanks!  I don't know the comment code well; Stefan, would you mind
giving this a quick look?

-- 
Sean Whitton




This bug report was last modified 23 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.