GNU bug report logs - #77822
[PATCH emacs-team] gnu: emacs-denote-menu: Update to 1.4.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77822 in the body.
You can then email your comments to 77822 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH emacs-team] gnu: emacs-denote-menu: Update to 1.4.0.
Date: Tue, 15 Apr 2025 12:10:33 +0200

* gnu/packages/emacs-xyz.scm (emacs-denote-menu): Update to 1.4.0.

Change-Id: Ifcd738018549d82769710ef761bdfc8b8a5d767b
---

[source]: Switch to git-fetch.
[arguments]<#:tests>: Disable.

 gnu/packages/emacs-xyz.scm | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 82831f0595..0973e9bcfd 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19803,15 +19803,18 @@ (define-public emacs-denote
 (define-public emacs-denote-menu
   (package
     (name "emacs-denote-menu")
-    (version "1.3.0")
+    (version "1.4.0")
     (source
      (origin
-       (method url-fetch)
-       (uri (string-append "https://elpa.gnu.org/packages/"
-                           "denote-menu-" version ".tar"))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/namilus/denote-menu")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
        (sha256
-        (base32 "0flkb3f1zpp3sbjx6h7qb6fnjgg44s53zkv3q3fj6cl7c0f11n02"))))
+        (base32 "15kaf45ndyg4xvgnpn8qwapkgcswasykcqfpkr0mny35a3jhdgrq"))))
     (build-system emacs-build-system)
+    (arguments (list #:tests? #f))    ; no tests
     (propagated-inputs (list emacs-denote))
     (home-page "https://www.scss.tcd.ie/~sulimanm/posts/denote-menu.html")
     (synopsis "View and filter Denote files in a tabulated list")

base-commit: 373545dc9efbae6589f502773aa49e26e42c585e
--
2.49.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lee Thompson <lee.p.thomp <at> gmail.com>
To: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Cc: Cayetano Santos <csantosb <at> inventati.org>, Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 77822 <at> debbugs.gnu.org,
 Andrew Tropin <andrew <at> trop.in>, Hilton Chain <hako <at> ultrarare.space>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#77822] [PATCH emacs-team] gnu: emacs-denote-menu: Update
 to 1.4.0.
Date: Fri, 18 Apr 2025 17:00:21 +0100

I've had a look at this and after some tweaking the updated package is
installed correctly and calling `M-x list-denotes' in a Denote directory
works fine, I'm not sure what other testing is appropriate to verify a
correct build.

I think this patch needs updating —I couldn't apply it.  In fact even
running `mumi am' tells me 'No patches found', though I may just be a
mumi noob and something else is set wrong.

I'll send over a v2 so it applies properly.

Message #14 received at 77822 <at> debbugs.gnu.org (full text, mbox):

From: Lee Thompson <lee.p.thomp <at> gmail.com>
To: 77822 <at> debbugs.gnu.org
Cc: Lee Thompson <lee.p.thomp <at> gmail.com>
Subject: [PATCH] gnu: emacs-denote-menu: Update to 1.4.0.
Date: Fri, 18 Apr 2025 17:10:48 +0100

From: Cayetano Santos <csantosb <at> inventati.org>

* gnu/packages/emacs-xyz.scm (emacs-denote-menu): Update to 1.4.0.

Change-Id: Ia016629bb672bfff7fd46fd67569712529e1886d
---
 gnu/packages/emacs-xyz.scm | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 08bd88fd08..60da5c9d72 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19789,15 +19789,18 @@ (define-public emacs-denote
 (define-public emacs-denote-menu
   (package
     (name "emacs-denote-menu")
-    (version "1.3.0")
+    (version "1.4.0")
     (source
      (origin
-       (method url-fetch)
-       (uri (string-append "https://elpa.gnu.org/packages/"
-                           "denote-menu-" version ".tar"))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/namilus/denote-menu")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
        (sha256
-        (base32 "0flkb3f1zpp3sbjx6h7qb6fnjgg44s53zkv3q3fj6cl7c0f11n02"))))
+        (base32 "15kaf45ndyg4xvgnpn8qwapkgcswasykcqfpkr0mny35a3jhdgrq"))))
     (build-system emacs-build-system)
+    (arguments (list #:tests? #f))    ; no tests
     (propagated-inputs (list emacs-denote))
     (home-page "https://www.scss.tcd.ie/~sulimanm/posts/denote-menu.html")
     (synopsis "View and filter Denote files in a tabulated list")
-- 
2.48.1

Message #17 received at 77822 <at> debbugs.gnu.org (full text, mbox):

From: Lee Thompson <lee.p.thomp <at> gmail.com>
To: 77822 <at> debbugs.gnu.org
Cc: Lee Thompson <lee.p.thomp <at> gmail.com>
Subject: [PATCH] gnu: emacs-denote-menu: Update to 1.4.0.
Date: Fri, 18 Apr 2025 17:14:51 +0100

From: Cayetano Santos <csantosb <at> inventati.org>

* gnu/packages/emacs-xyz.scm (emacs-denote-menu): Update to 1.4.0.

[source]: Switch to git-fetch.
[arguments]<#:tests>: Disable.

Change-Id: Ia016629bb672bfff7fd46fd67569712529e1886d
---
 gnu/packages/emacs-xyz.scm | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 08bd88fd08..60da5c9d72 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19789,15 +19789,18 @@ (define-public emacs-denote
 (define-public emacs-denote-menu
   (package
     (name "emacs-denote-menu")
-    (version "1.3.0")
+    (version "1.4.0")
     (source
      (origin
-       (method url-fetch)
-       (uri (string-append "https://elpa.gnu.org/packages/"
-                           "denote-menu-" version ".tar"))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/namilus/denote-menu")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
        (sha256
-        (base32 "0flkb3f1zpp3sbjx6h7qb6fnjgg44s53zkv3q3fj6cl7c0f11n02"))))
+        (base32 "15kaf45ndyg4xvgnpn8qwapkgcswasykcqfpkr0mny35a3jhdgrq"))))
     (build-system emacs-build-system)
+    (arguments (list #:tests? #f))    ; no tests
     (propagated-inputs (list emacs-denote))
     (home-page "https://www.scss.tcd.ie/~sulimanm/posts/denote-menu.html")
     (synopsis "View and filter Denote files in a tabulated list")
-- 
2.48.1

Message #20 received at 77822 <at> debbugs.gnu.org (full text, mbox):

From: Lee Thompson <lee.p.thomp <at> gmail.com>
To: 77822 <at> debbugs.gnu.org
Cc: Lee Thompson <lee.p.thomp <at> gmail.com>
Subject: [PATCH v2] gnu: emacs-denote-menu: Update to 1.4.0.
Date: Fri, 18 Apr 2025 17:20:49 +0100

From: Cayetano Santos <csantosb <at> inventati.org>

* gnu/packages/emacs-xyz.scm (emacs-denote-menu): Update to 1.4.0.

[source]: Switch to git-fetch.
[arguments]<#:tests>: Disable.

Change-Id: Ia016629bb672bfff7fd46fd67569712529e1886d
---
 gnu/packages/emacs-xyz.scm | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 08bd88fd08..60da5c9d72 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19789,15 +19789,18 @@ (define-public emacs-denote
 (define-public emacs-denote-menu
   (package
     (name "emacs-denote-menu")
-    (version "1.3.0")
+    (version "1.4.0")
     (source
      (origin
-       (method url-fetch)
-       (uri (string-append "https://elpa.gnu.org/packages/"
-                           "denote-menu-" version ".tar"))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/namilus/denote-menu")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
        (sha256
-        (base32 "0flkb3f1zpp3sbjx6h7qb6fnjgg44s53zkv3q3fj6cl7c0f11n02"))))
+        (base32 "15kaf45ndyg4xvgnpn8qwapkgcswasykcqfpkr0mny35a3jhdgrq"))))
     (build-system emacs-build-system)
+    (arguments (list #:tests? #f))    ; no tests
     (propagated-inputs (list emacs-denote))
     (home-page "https://www.scss.tcd.ie/~sulimanm/posts/denote-menu.html")
     (synopsis "View and filter Denote files in a tabulated list")
-- 
2.48.1

Message #23 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lee Thompson <lee.p.thomp <at> gmail.com>
To: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Cc: Cayetano Santos <csantosb <at> inventati.org>, Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 77822 <at> debbugs.gnu.org,
 Andrew Tropin <andrew <at> trop.in>, Hilton Chain <hako <at> ultrarare.space>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#77822] [PATCH emacs-team] gnu: emacs-denote-menu: Update
 to 1.4.0.
Date: Fri, 18 Apr 2025 17:24:52 +0100

So sorry guys made a mess of this trying to get my head around using
mumi, this v2 patch applies cleanly and I think includes the necessary
references to original submitter.

Message #29 received at 77822 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Lee Thompson <lee.p.thomp <at> gmail.com>
Cc: csantosb <at> inventati.org, cox.katherine.e+guix <at> gmail.com,
 77822 <at> debbugs.gnu.org, andrew <at> trop.in, hako <at> ultrarare.space,
 divya <at> subvertising.org, liliana.prikler <at> gmail.com
Subject: Re: [bug#77822] [PATCH emacs-team] gnu: emacs-denote-menu: Update
 to 1.4.0.
Date: Sat, 26 Apr 2025 09:07:40 -0700

Hi Lee,

Lee Thompson <lee.p.thomp <at> gmail.com> writes:

> I've had a look at this and after some tweaking the updated 
> package is
> installed correctly and calling `M-x list-denotes' in a Denote 
> directory
> works fine, I'm not sure what other testing is appropriate to 
> verify a
> correct build.
>
> I think this patch needs updating —I couldn't apply it.  In fact 
> even
> running `mumi am' tells me 'No patches found', though I may just 
> be a
> mumi noob and something else is set wrong.

This happens to me often, and usually has nothing to do with the 
patch, but is a symptom of mumi (the back-end server the `mumi' 
CLI talks to) being unreliable.

 -- Ian

Message #32 received at 77822 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 77822 <at> debbugs.gnu.org,
 Hilton Chain <hako <at> ultrarare.space>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#77822] [PATCH emacs-team] gnu: emacs-denote-menu: Update
 to 1.4.0.
Date: Sat, 26 Apr 2025 17:40:36 -0700

Hi Cayetano, Lee,

Pushed as a3c1a5f9db.

Thanks,
 -- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.