GNU bug report logs - #77656
[PATCH] Don't escape "." in `prin1' unless followed by "?" or nothing

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Spencer Baugh <sbaugh <at> janestreet.com>
Subject: bug#77656: closed (Re: bug#77656: [PATCH] Don't escape "." in
 `prin1' unless followed by "?" or nothing)
Date: Mon, 28 Apr 2025 17:48:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#77656: [PATCH] Don't escape "." in `prin1' unless followed by "?" or nothing

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 77656 <at> debbugs.gnu.org.

-- 
77656: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77656
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: larsi <at> gnus.org, Andrea Corallo <acorallo <at> gnu.org>,
 Eli Zaretskii <eliz <at> gnu.org>, 77656-done <at> debbugs.gnu.org,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#77656: [PATCH] Don't escape "." in `prin1' unless followed
 by "?" or nothing
Date: Mon, 28 Apr 2025 13:47:32 -0400

> That sounds reasonable to me, done in the attached patch.

Thanks, pushed to `master`, closing,


        Stefan

[Message part 3 (message/rfc822, inline)]

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Don't escape "." in `prin1' unless followed by "?" or nothing
Date: Tue, 08 Apr 2025 17:41:56 -0400

[Message part 4 (text/plain, inline)]

Tags: patch


This is a followup to 637dde4aba921435f78d0de769ad74c4f3230aa6, which
removed some unnecessary escaping of "." and "?" when printing symbols
in prin1.

This change removes more unnecessary escaping of "."; "." only
needs to be escaped when it's the entire symbol or if it's
followed by a "?".

(Actually, if we always escaped "?" (which was the case before
637dde4aba92) then "." only ever needs to be escaped when
string_to_number returns non-nil.  So 637dde4aba92 could have
just dropped the escaping of "." with no other changes, if it
didn't also remove escaping of "?")

In GNU Emacs 30.1.50 (build 4, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2025-04-08 built on
 igm-qws-u22796a
Repository revision: 66de38ffb76fbd3ecb1cea52e655189b1b173fa1
Repository branch: emacs-30
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Rocky Linux 8.10 (Green Obsidian)

Configured using:
 'configure --config-cache --with-x-toolkit=lucid --without-gpm
 --without-gconf --without-selinux --without-imagemagick --with-modules
 --with-gif=no --with-cairo --with-rsvg --without-compress-install
 --with-tree-sitter --with-native-compilation=aot'

[0001-Don-t-escape-.-in-prin1-unless-followed-by-or-nothin.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.