GNU bug report logs - #77580
[PATCH] New command ediff-undo

Previous Next

Full log

View this message in rfc822 format

From: "Paul D. Nelson" <ultrono <at> gmail.com>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 77580 <at> debbugs.gnu.org, spwhitton <at> spwhitton.name
Subject: bug#77580: [PATCH] New command ediff-undo
Date: Tue, 22 Apr 2025 15:20:27 +0200

Hi Michael, thanks for your feedback.

>  - Consider to handle an active region similar to how you handle
>  narrowing: undo is able to restrict undoing to the region.

I think feature is already there in my patch -- if the region is active,
then it previews undoing in the region, just like undo.  Would be happy
to hear if I missed something.

>  - There is a potential problem with the target buffers of
>  `undo-to-buffer': they share the `buffer-file-name' with the original
>  buffer.  If they are modified, Emacs will potentially save the contents
>  of these buffers to that file, resulting in a mess.

I tested it just now with ediff-undo, and it seems on my end that
buffer-file-name is new in the target buffer.  If I try saving, then I'm
prompted for a file name.  Again, happy to hear if I missed something.

>
>  - Since you mentioned reverting as a use case: doesn't the undo history
>  get lost when a buffer is reverted?  I remember that this is the case
>  at least sometimes.

I'm not familiar with how reverting affects undo history.  I see it as a
mostly orthogonal issue (since the idea is to use previewed undo in a
region as a region-specific way to preview reverting, rather than to use
existing reverting functions), but I'll keep this in mind.  Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.