GNU bug report logs - #77579
[PATCH] gnu: efivar: Update to 39.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77579 in the body.
You can then email your comments to 77579 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <z572 <at> z572.online>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: efivar: Update to 39.
Date: Sun,  6 Apr 2025 23:09:54 +0800

* gnu/packages/linux.scm (efivar): Update to 39.

Change-Id: Iaf9a94cd3f851d442b70b30b85d8e8e90ba4460c
---
 gnu/packages/linux.scm | 82 ++++++++++++++++++++----------------------
 1 file changed, 39 insertions(+), 43 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index a6bffa2bb9d..4b1c7b398d2 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -8197,50 +8197,46 @@ (define-public radeontop
     (license license:gpl3)))
 
 (define-public efivar
-  ;; XXX: 15622b7e5761f3dde3f0e42081380b2b41639a48 fixes compilation on i686.
-  ;; ca48d3964d26f5e3b38d73655f19b1836b16bd2d fixes cross-compilation.
-  (let ((commit "ca48d3964d26f5e3b38d73655f19b1836b16bd2d")
-        (revision "0"))
-    (package
-      (name "efivar")
-      (version (git-version "38" revision commit))
-      (source (origin
-                (method git-fetch)
-                (uri (git-reference
-                      (url "https://github.com/rhboot/efivar")
-                      (commit commit)))
-                (file-name (git-file-name name version))
-                (sha256
-                 (base32
-                  "0zsab3hcv1v53cxwkvsk09ifnwhs48a6xa3kxlwvs87yxswspvi8"))))
-      (build-system gnu-build-system)
-      (arguments
-       (list
-        ;; Tests require a UEFI system and is not detected in the chroot.
-        #:tests? #f
-        #:make-flags #~(list (string-append "prefix="
-                                            #$output)
-                             (string-append "libdir="
-                                            #$output "/lib")
-                             (string-append "CC="
-                                            #$(cc-for-target)) "HOSTCC=gcc"
-                             (string-append "LDFLAGS=-Wl,-rpath="
-                                            #$output "/lib"))
-        #:phases #~(modify-phases %standard-phases
-                     (add-after 'unpack 'build-deterministically
-                       (lambda _
-                         (substitute* "src/include/defaults.mk"
-                           ;; Don't use -march=native.
-                           (("-march=native")
-                            ""))))
-                     (delete 'configure))))
-      (native-inputs (list mandoc pkg-config))
-      (inputs (list popt))
-      (home-page "https://github.com/rhboot/efivar")
-      (synopsis "Tool and library to manipulate EFI variables")
-      (description "This package provides a library and a command line
+  (package
+    (name "efivar")
+    (version "39")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/rhboot/efivar")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1zd9dghg1z2rrsazv3d9rj7nik6kdqz42jiak65pipz7mpjn9zdk"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      ;; Tests require a UEFI system and is not detected in the chroot.
+      #:tests? #f
+      #:make-flags #~(list (string-append "prefix="
+                                          #$output)
+                           (string-append "libdir="
+                                          #$output "/lib")
+                           (string-append "CC="
+                                          #$(cc-for-target)) "HOSTCC=gcc"
+                                          (string-append "LDFLAGS=-Wl,-rpath="
+                                                         #$output "/lib"))
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'unpack 'build-deterministically
+                     (lambda _
+                       (substitute* "src/include/defaults.mk"
+                         ;; Don't use -march=native.
+                         (("-march=native")
+                          ""))))
+                   (delete 'configure))))
+    (native-inputs (list mandoc pkg-config))
+    (inputs (list popt))
+    (home-page "https://github.com/rhboot/efivar")
+    (synopsis "Tool and library to manipulate EFI variables")
+    (description "This package provides a library and a command line
 interface to the variable facility of UEFI boot firmware.")
-      (license license:lgpl2.1+))))
+    (license license:lgpl2.1+)))
 
 (define-public efibootmgr
   (package

base-commit: 90279af10615cd74e4c52851f7fec797d4d0f682
prerequisite-patch-id: f6807c214a9924fb57a2a054dceba1802ba4536c
prerequisite-patch-id: b60437563c004733af4ad531ed0ca89b049e748f
prerequisite-patch-id: f923e612422f9021d997ea3824d4b97b1f022c65
-- 
2.49.0

Message #8 received at 77579 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Zheng Junjie <z572 <at> z572.online>
Cc: Wilko Meyer <w <at> wmeyer.eu>, 77579 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#77579] [PATCH] gnu: efivar: Update to 39.
Date: Tue, 08 Apr 2025 17:08:14 +0200

Zheng Junjie <z572 <at> z572.online> skribis:

> * gnu/packages/linux.scm (efivar): Update to 39.
>
> Change-Id: Iaf9a94cd3f851d442b70b30b85d8e8e90ba4460c

LGTM!

Message #11 received at 77579 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Zheng Junjie <z572 <at> z572.online>
Cc: Wilko Meyer <w <at> wmeyer.eu>, 77579 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#77579] [PATCH] gnu: efivar: Update to 39.
Date: Thu, 17 Apr 2025 22:44:10 +0200

Ludovic Courtès <ludo <at> gnu.org> writes:

> Zheng Junjie <z572 <at> z572.online> skribis:
>
>> * gnu/packages/linux.scm (efivar): Update to 39.
>>
>> Change-Id: Iaf9a94cd3f851d442b70b30b85d8e8e90ba4460c
>
> LGTM!

But apparently this fails on 32-bit platforms:

  https://qa.guix.gnu.org/issue/77579

Could you take a look?

Ludo’.

Message #14 received at 77579 <at> debbugs.gnu.org (full text, mbox):

From: Rowan Fraser <rowanfr <at> gmail.com>
To: 77579 <at> debbugs.gnu.org
Subject: efivar compilation issues
Date: Wed, 28 May 2025 01:05:00 -0500

[Message part 1 (text/plain, inline)]

The efivar has compilation issues for 32-bit architecture and RISC-V.
For 32 bit architecture I'd assume that it has to do with the issue
mentioned here: https://github.com/rhboot/efivar/issues/270
For RISC-V architecture it errors out due to the `-Werror` flag
and conflicting types as detailed in:
https://github.com/rhboot/efivar/issues/280

The repo for efivar hasn't been updated in over a year so it might need to
be forked if you want a source code solution or we can alter the make flags
to be more permissive.

[Message part 2 (text/html, inline)]

Message #19 received at 77579-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Rowan Fraser <rowanfr <at> gmail.com>
Cc: 77579-done <at> debbugs.gnu.org
Subject: Re: [bug#77579] efivar compilation issues
Date: Mon, 16 Jun 2025 12:13:20 +0300

[Message part 1 (text/plain, inline)]

On Wed, May 28, 2025 at 01:05:00AM -0500, Rowan Fraser wrote:
> The efivar has compilation issues for 32-bit architecture and RISC-V.
> For 32 bit architecture I'd assume that it has to do with the issue
> mentioned here: https://github.com/rhboot/efivar/issues/270
> For RISC-V architecture it errors out due to the `-Werror` flag
> and conflicting types as detailed in:
> https://github.com/rhboot/efivar/issues/280
> 
> The repo for efivar hasn't been updated in over a year so it might need to
> be forked if you want a source code solution or we can alter the make flags
> to be more permissive.

I followed this patch up with a patch fixing compiling on 32-bit
systems.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.