GNU bug report logs - #77528
[PATCH v4 6/6] guix-install.sh: Set up extra environment variables for Guix Home.

Previous Next

To reply to this bug, email your comments to 77528 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: guix-patches <at> gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH v4 6/6] guix-install.sh: Set up extra environment variables
 for Guix Home.
Date: Fri,  4 Apr 2025 11:23:03 +0800

* etc/guix-install.sh (sys_create_init_profile): Set up extra environment
variables for Guix Home.

Change-Id: If0508bf7c87947d89982ad17cabfbf1024a209d0
---
 etc/guix-install.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index f0d37bc384..aabfb4dda4 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -795,8 +795,10 @@ do
   esac
 done
 
-# NOTE: Guix Home handles its own profile initialization in ~/.profile. See
-# info '(guix) Configuring the Shell'.
+# Set up extra environment variables for Guix Home.
+HOME_ENVIRONMENT=$HOME/.guix-home
+[ -f "$HOME_ENVIRONMENT/setup-environment" ] && . "$HOME_ENVIRONMENT/setup-environment"
+unset HOME_ENVIRONMENT
 EOF
 }
 
-- 
2.49.0

Message #10 received at 77528 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: iyzsong <at> gmail.com, 77525 <at> debbugs.gnu.org,
 宋文武 <iyzsong <at> envs.net>, 77528 <at> debbugs.gnu.org
Subject: Re: [bug#77525] [PATCH v4 2/6] system: /etc/profile: Rearrange to
 avoid search path duplication.
Date: Mon, 14 Apr 2025 17:12:12 +0200

Hi Hilton,

(Cc: 宋文武.)

Hilton Chain <hako <at> ultrarare.space> writes:

> * gnu/system.scm (operating-system-etc-service)[profile]: Set umask first.
> Group environment variables setup with profile sourcing to avoid duplication.
> Export $GUILE_LOAD_PATH and $GUILE_LOAD_COMPILED_PATH for ‘guix pull’ profile.
> * gnu/system/shadow.scm (%default-bash-profile): Remove duplicated exports.

The last item does not say the whole story:

> +++ b/gnu/system/shadow.scm
> @@ -179,16 +179,6 @@ (define %default-bash-profile
>  
>  # Honor per-interactive-shell startup file
>  if [ -f ~/.bashrc ]; then . ~/.bashrc; fi
> -
> -# Merge search-paths from multiple profiles, the order matters.
> -eval \"$(guix package --search-paths \\
> --p $HOME/.config/guix/current \\
> --p $HOME/.guix-home/profile \\
> --p $HOME/.guix-profile \\
> --p /run/current-system/profile)\"
> -
> -# Prepend setuid programs.
> -export PATH=/run/setuid-programs:$PATH
>  "))

I am the one who suggested to not invoke ‘guix package’ from shell
startup files:

  https://issues.guix.gnu.org/77035#8-lineno17

However, I hadn’t realized that this had previously been introduced by
宋文武 in commit 40310efde9b4a4f2cf98081d6cd10f843685ebb6.

Since this patch essentially reverts this commit, could you share your
thoughts on this, 宋文武?

Thanks,
Ludo’.

Message #13 received at 77528 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Hilton Chain <hako <at> ultrarare.space>, 77525 <at> debbugs.gnu.org,
 77528 <at> debbugs.gnu.org, iyzsong <at> gmail.com
Subject: Re: [bug#77525] [PATCH v4 2/6] system: /etc/profile: Rearrange to
 avoid search path duplication.
Date: Tue, 15 Apr 2025 22:05:06 +0800

Ludovic Courtès <ludo <at> gnu.org> writes:

> [...]
>
> The last item does not say the whole story:
>
>> +++ b/gnu/system/shadow.scm
>> @@ -179,16 +179,6 @@ (define %default-bash-profile
>>  
>>  # Honor per-interactive-shell startup file
>>  if [ -f ~/.bashrc ]; then . ~/.bashrc; fi
>> -
>> -# Merge search-paths from multiple profiles, the order matters.
>> -eval \"$(guix package --search-paths \\
>> --p $HOME/.config/guix/current \\
>> --p $HOME/.guix-home/profile \\
>> --p $HOME/.guix-profile \\
>> --p /run/current-system/profile)\"
>> -
>> -# Prepend setuid programs.
>> -export PATH=/run/setuid-programs:$PATH
>>  "))
>
> I am the one who suggested to not invoke ‘guix package’ from shell
> startup files:
>
>   https://issues.guix.gnu.org/77035#8-lineno17
>
> However, I hadn’t realized that this had previously been introduced by
> 宋文武 in commit 40310efde9b4a4f2cf98081d6cd10f843685ebb6.
>
> Since this patch essentially reverts this commit, could you share your
> thoughts on this, 宋文武?

Hi, Sorry for that, it seems I had leave it partly commited in, without
a news entry and documentation.  The change about
/etc/skel/.bash_profile in commit 40310e is to provide a sensible
default to merge multiple profiles, which will fix
<https://issues.guix.gnu.org/20255>.  Users can easily change his own
~/.bash_profile to not invoke 'guix package', to avoid merge multiple
profiles.

Now I think it's better to remove it as the patch did, so we default to
not merge search paths from multiple profiles, and document how to
custom your ~/.bash_profile with 'guix package --search-paths` to merge
them.  Also mention the drawback when you choose to merge profiles for
search paths, mainly ABI incompatible problems from plugins (GIO
modules, Qt, etc.).

Thanks.

Message #16 received at 77528 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: 宋文武 <iyzsong <at> envs.net>
Cc: Hilton Chain <hako <at> ultrarare.space>, 77525 <at> debbugs.gnu.org,
 77528 <at> debbugs.gnu.org, iyzsong <at> gmail.com
Subject: Re: [bug#77525] [PATCH v4 2/6] system: /etc/profile: Rearrange to
 avoid search path duplication.
Date: Tue, 15 Apr 2025 17:05:02 +0200

宋文武 <iyzsong <at> envs.net> writes:

> Hi, Sorry for that, it seems I had leave it partly commited in, without
> a news entry and documentation.  The change about
> /etc/skel/.bash_profile in commit 40310e is to provide a sensible
> default to merge multiple profiles, which will fix
> <https://issues.guix.gnu.org/20255>.  Users can easily change his own
> ~/.bash_profile to not invoke 'guix package', to avoid merge multiple
> profiles.
>
> Now I think it's better to remove it as the patch did, so we default to
> not merge search paths from multiple profiles,

OK, I see.

Any thoughts on the patch series Hilton submitted?

  https://issues.guix.gnu.org/77035

Thanks for your feedback,
Ludo’.

Message #19 received at 77528 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: 77528 <at> debbugs.gnu.org
Subject: Re: [bug#77528] [PATCH v4 6/6] guix-install.sh: Set up extra
 environment variables for Guix Home.
Date: Sat, 19 Apr 2025 10:47:11 +0800

Hilton Chain <hako <at> ultrarare.space> writes:

> * etc/guix-install.sh (sys_create_init_profile): Set up extra environment
> variables for Guix Home.

LGTM, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.