GNU bug report logs - #77527
[PATCH v4 5/6] guix-install.sh: Group profile sourcing.

Previous Next

Package: guix-patches;

Reported by: Hilton Chain <hako <at> ultrarare.space>

Date: Fri, 4 Apr 2025 03:24:07 UTC

Severity: normal

Tags: patch

Merged with 77035, 77522, 77523, 77524, 77525, 77526, 77528

Full log


Message #10 received at 77527 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: 77527 <at> debbugs.gnu.org
Subject: Re: [bug#77527] [PATCH v4 5/6] guix-install.sh: Group profile
 sourcing.
Date: Sat, 19 Apr 2025 10:45:22 +0800
Hilton Chain <hako <at> ultrarare.space> writes:

> [...]
> +  if [ \"$GUIX_PROFILE\" = \"$HOME/.config/guix/current\" ]; then
> +    # Expose the latest Guix modules to Guile so guix shell and repls spawned by
> +    # e.g. Geiser work out of the box.
> +    case $GUILE_LOAD_PATH in
> +      *$GUIX_PROFILE/share/guile/site/3.0*) ;;
> +      *) export GUILE_LOAD_PATH=\"$GUIX_PROFILE/share/guile/site/3.0${GUILE_LOAD_PATH:+:}$GUILE_LOAD_PATH\" ;;
> +    esac
> +    case $GUILE_LOAD_COMPILED_PATH in
> +      *$GUIX_PROFILE/lib/guile/3.0/site-ccache*) ;;
> +      *) export
> GUILE_LOAD_COMPILED_PATH=\"$GUIX_PROFILE/lib/guile/3.0/site-ccache${GUILE_LOAD_COMPILED_PATH:+:}$GUILE_LOAD_COMPILED_PATH\"
> ;;
Maybe not needed, since 'guix repl' handle this.

> [...]
> -# Clean up after ourselves.
> -unset GUIX_PROFILE

I think it's still needed, since after the for loop the variable is
still visible.

Otherwise look good to me, thanks!




This bug report was last modified 56 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.