GNU bug report logs - #77391
[PATCH 0/2] gnu: emacs-ellama: Update to 1.7.2.

Previous Next

Full log

Message #86 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: Suhail Singh <suhailsingh247 <at> gmail.com>
To: Cayetano Santos <cayetano.santos <at> inventati.org>
Cc: 77391 <at> debbugs.gnu.org, Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Cayetano Santos <csantosb <at> inventati.org>, Andrew Tropin <andrew <at> trop.in>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>,
 Suhail Singh <suhailsingh247 <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#77391] [PATCH v4 4/4] gnu: emacs-ellama: Enable tests.
Date: Thu, 03 Apr 2025 09:07:47 -0400

Cayetano Santos <cayetano.santos <at> inventati.org> writes:

>> +                     (("\\(ert-deftest test-ellama-context-element-extract-info-node .*" all)
>
> This line 5798 is way too long (93 characters), as for the linter.

Indeed.  Even with the "all)" on the subsequent line it'd be too long.
An option may be to split the string into multiple and concatenate it,
but I believe it would hurt readability for little gain.

I'll be happy with whatever decision someone with commit rights makes in
this regard.  In the meanwhile, it seems 1.8.1 is out so I'll send v5.

-- 
Suhail

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.