GNU bug report logs - #77391
[PATCH 0/2] gnu: emacs-ellama: Update to 1.7.2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77391 in the body.
You can then email your comments to 77391 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] gnu: emacs-ellama: Update to 1.7.2.
Date: Sun, 30 Mar 2025 16:39:25 -0400

Hello Guix,

This series updates emacs-ellama, and its dependency emacs-llm.

Suhail (2):
  gnu: emacs-llm: Update to 0.24.1.
  gnu: emacs-ellama: Update to 1.7.2.

 gnu/packages/emacs-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


base-commit: 77d5eb4c16984e430b377e0b5f1551fbda171ec6

Message #8 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: emacs-llm: Update to 0.24.1.
Date: Sun, 30 Mar 2025 12:38:25 -0400

* gnu/packages/emacs-xyz.scm (emacs-llm): Update to 0.24.1.

Change-Id: I6b11acfb53deee417a4f1727fa2e36f179823a1e
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b5dc07acbb..b7cce7be70 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1876,7 +1876,7 @@ (define-public emacs-llama
 (define-public emacs-llm
   (package
     (name "emacs-llm")
-    (version "0.23.0")
+    (version "0.24.1")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -1885,7 +1885,7 @@ (define-public emacs-llm
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "18dl1a6npx0vlqd4mdrqj7ja7cjdfw366qml1pspy92q4l65pyh6"))))
+                "0mj5s03a87sk45k71vvxxz4jv1x603c8icr71r6cvhms45k9gbgk"))))
     (build-system emacs-build-system)
     (propagated-inputs (list emacs-plz
                              emacs-plz-event-source

Message #11 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: emacs-ellama: Update to 1.7.2.
Date: Sun, 30 Mar 2025 12:42:34 -0400

* gnu/packages/emacs-xyz.scm (emacs-ellama): Update to 1.7.2.

Change-Id: I516f99587b0381b8635d1161c56bda5d7db35920
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b7cce7be70..61db0bb319 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -5776,7 +5776,7 @@ (define-public emacs-elf-mode
 (define-public emacs-ellama
   (package
     (name "emacs-ellama")
-    (version "1.4.5")
+    (version "1.7.2")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -5784,7 +5784,7 @@ (define-public emacs-ellama
                     (commit version)))
               (file-name (git-file-name name version))
               (sha256 (base32
-                       "1d2z7hc2h583g11rr1labmlvfs27336qxgp9q9nv2fh0f9l1qnv4"))))
+                       "15dxcgsad4wna5v3483ixvfm2zxff12cmi8szxy0m6k4b10gwa0b"))))
     (build-system emacs-build-system)
     (propagated-inputs (list emacs-compat emacs-dash emacs-llm emacs-spinner))
     (home-page "https://github.com/s-kostyaev/ellama")

Message #14 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: suhailsingh247 <at> gmail.com
Cc: 77391 <at> debbugs.gnu.org, ian <at> retrospec.tv, cox.katherine.e+guix <at> gmail.com,
 csantosb <at> inventati.org, andrew <at> trop.in, divya <at> subvertising.org,
 liliana.prikler <at> gmail.com
Subject: Re: [bug#77391] [PATCH 2/2] gnu: emacs-ellama: Update to 1.7.2.
Date: Wed, 02 Apr 2025 11:10:39 +0200

[Message part 1 (text/plain, inline)]

Hi Suhail, thanks for the patch ! A couple of remarks:

- emacs-dash is not a dependency anymore
- we need to provide package tests, as the upstream project includes
  them (or disable them explicitly and put a comment with the reason)

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: suhailsingh247 <at> gmail.com
Cc: 77391 <at> debbugs.gnu.org, ian <at> retrospec.tv, cox.katherine.e+guix <at> gmail.com,
 csantosb <at> inventati.org, andrew <at> trop.in, divya <at> subvertising.org,
 liliana.prikler <at> gmail.com
Subject: Re: [bug#77391] [PATCH 1/2] gnu: emacs-llm: Update to 0.24.1.
Date: Wed, 02 Apr 2025 11:15:10 +0200

[Message part 1 (text/plain, inline)]

- 0.24.2 is already available, could you please update ?
- we need to explicitly disable tests here, with a comment on its non existence

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: Suhail Singh <suhailsingh247 <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 77391 <at> debbugs.gnu.org, ian <at> retrospec.tv, cox.katherine.e+guix <at> gmail.com,
 liliana.prikler <at> gmail.com, andrew <at> trop.in, divya <at> subvertising.org,
 suhailsingh247 <at> gmail.com
Subject: Re: [bug#77391] [PATCH 2/2] gnu: emacs-ellama: Update to 1.7.2.
Date: Wed, 02 Apr 2025 09:27:26 -0400

Cayetano Santos <csantosb <at> inventati.org> writes:

> - emacs-dash is not a dependency anymore

Good catch, thanks!  Will remove in v2.

> - we need to provide package tests, as the upstream project includes
>   them (or disable them explicitly and put a comment with the reason)

Could you please explain what you mean by "provide package tests"?  As
in, set "#:tests?" to #t ?  Or something else?

-- 
Suhail

Message #23 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Suhail Singh <suhailsingh247 <at> gmail.com>
Cc: 77391 <at> debbugs.gnu.org, ian <at> retrospec.tv, cox.katherine.e+guix <at> gmail.com,
 liliana.prikler <at> gmail.com, andrew <at> trop.in, divya <at> subvertising.org
Subject: Re: [bug#77391] [PATCH 2/2] gnu: emacs-ellama: Update to 1.7.2.
Date: Wed, 02 Apr 2025 15:36:49 +0200

[Message part 1 (text/plain, inline)]

>Wed 02 Apr 2025 at 09:27, Suhail Singh <suhailsingh247 <at> gmail.com> wrote:

> Could you please explain what you mean by "provide package tests"?  As
> in, set "#:tests?" to #t ?  Or something else?

Yes, exactly, tests are active by default, and need to be explicitly
deactivated otherwise, with a little comment about why. In this case,
there is a "tests" folder in the upstream repository.

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v2 0/4] gnu: emacs-ellama: Update to 1.8.0
Date: Wed, 2 Apr 2025 10:50:33 -0400

Updated patch series with comments addressed.

Suhail (4):
  gnu: emacs-llm: Update to 0.24.2.
  gnu: emacs-llm: Fix style.
  gnu: emacs-ellama: Update to 1.8.0.
  gnu: emacs-ellama: Enable tests; install info manual.

 gnu/packages/emacs-xyz.scm | 50 ++++++++++++++++++++++++++------------
 1 file changed, 35 insertions(+), 15 deletions(-)


base-commit: 77d5eb4c16984e430b377e0b5f1551fbda171ec6

Message #29 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v2 1/4] gnu: emacs-llm: Update to 0.24.2.
Date: Sun, 30 Mar 2025 12:38:25 -0400

* gnu/packages/emacs-xyz.scm (emacs-llm): Update to 0.24.2.

Change-Id: I6b11acfb53deee417a4f1727fa2e36f179823a1e
---
 gnu/packages/emacs-xyz.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b5dc07acbb..6382652f39 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1876,7 +1876,7 @@ (define-public emacs-llama
 (define-public emacs-llm
   (package
     (name "emacs-llm")
-    (version "0.23.0")
+    (version "0.24.2")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -1885,10 +1885,14 @@ (define-public emacs-llm
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "18dl1a6npx0vlqd4mdrqj7ja7cjdfw366qml1pspy92q4l65pyh6"))))
+                "0kza3jzabp5ilapi3a0ycrc26gvj6s2nf3x1ly4c8d3si6fdlx61"))))
     (build-system emacs-build-system)
     (propagated-inputs (list emacs-plz
                              emacs-plz-event-source
+    (arguments
+     (list
+      ;; there are no tests
+      #:tests? #f))
                              emacs-plz-media-type))
     (home-page "https://github.com/ahyatt/llm")
     (synopsis "Emacs library abstracting Large Language Model capabilities")

Message #32 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v2 2/4] gnu: emacs-llm: Fix style.
Date: Wed, 2 Apr 2025 09:52:23 -0400

* gnu/packages/emacs-xyz.scm (emacs-llm): Fix style.

Change-Id: Ia6638963bf19b916ac40a64e967bbe10c9eccf06
---
 gnu/packages/emacs-xyz.scm | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6382652f39..6acab6b8ef 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1877,22 +1877,21 @@ (define-public emacs-llm
   (package
     (name "emacs-llm")
     (version "0.24.2")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/ahyatt/llm")
-                    (commit version)))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "0kza3jzabp5ilapi3a0ycrc26gvj6s2nf3x1ly4c8d3si6fdlx61"))))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ahyatt/llm")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0kza3jzabp5ilapi3a0ycrc26gvj6s2nf3x1ly4c8d3si6fdlx61"))))
     (build-system emacs-build-system)
-    (propagated-inputs (list emacs-plz
-                             emacs-plz-event-source
     (arguments
      (list
       ;; there are no tests
       #:tests? #f))
+    (propagated-inputs (list emacs-plz emacs-plz-event-source
                              emacs-plz-media-type))
     (home-page "https://github.com/ahyatt/llm")
     (synopsis "Emacs library abstracting Large Language Model capabilities")

Message #35 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v2 3/4] gnu: emacs-ellama: Update to 1.8.0.
Date: Sun, 30 Mar 2025 12:42:34 -0400

* gnu/packages/emacs-xyz.scm (emacs-ellama): Update to 1.8.0.

Change-Id: I516f99587b0381b8635d1161c56bda5d7db35920
---
 gnu/packages/emacs-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6acab6b8ef..5189ddd5d1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -5779,7 +5779,7 @@ (define-public emacs-elf-mode
 (define-public emacs-ellama
   (package
     (name "emacs-ellama")
-    (version "1.4.5")
+    (version "1.8.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -5787,9 +5787,9 @@ (define-public emacs-ellama
                     (commit version)))
               (file-name (git-file-name name version))
               (sha256 (base32
-                       "1d2z7hc2h583g11rr1labmlvfs27336qxgp9q9nv2fh0f9l1qnv4"))))
+                       "075bxdy2jzaq4nw2vpzlmxlq3mlvr0dklva5hbpzqm6pvwa2xz1k"))))
     (build-system emacs-build-system)
-    (propagated-inputs (list emacs-compat emacs-dash emacs-llm emacs-spinner))
+    (propagated-inputs (list emacs-compat emacs-llm emacs-plz emacs-transient))
     (home-page "https://github.com/s-kostyaev/ellama")
     (synopsis "Tool for interacting with LLMs")
     (description

Message #38 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v2 4/4] gnu: emacs-ellama: Enable tests; install info manual.
Date: Wed, 2 Apr 2025 10:42:12 -0400

* gnu/packages/emacs-xyz.scm (emacs-ellama)[arguments]: Enable tests; skip
failing; install included pre-generated info manual.

Change-Id: I1b468c7b30ad35ae553d354ef63da2d4d1c056a7
---
 gnu/packages/emacs-xyz.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5189ddd5d1..2c1e5801eb 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -5789,6 +5789,23 @@ (define-public emacs-ellama
               (sha256 (base32
                        "075bxdy2jzaq4nw2vpzlmxlq3mlvr0dklva5hbpzqm6pvwa2xz1k"))))
     (build-system emacs-build-system)
+    (arguments
+     (list #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'disable-failing-tests
+                 (lambda _
+                   (substitute* (find-files "tests/" "\\.el$")
+                     (("\\(ert-deftest test-ellama-context-element-extract-info-node .*" all)
+                      (string-append all "(skip-unless nil)\n")))))
+               (add-after 'install 'install-info
+                 (lambda _
+                   (install-file "ellama.info"
+                                 (string-append #$output "/share/info")))))
+           #:tests? #t
+           #:test-command #~(list "emacs" "-Q" "--batch"
+                                  "-l" "ellama.el"
+                                  "-l" "tests/test-ellama.el"
+                                  "-f" "ert-run-tests-batch-and-exit")))
     (propagated-inputs (list emacs-compat emacs-llm emacs-plz emacs-transient))
     (home-page "https://github.com/s-kostyaev/ellama")
     (synopsis "Tool for interacting with LLMs")

Message #41 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v3 0/4] gnu: emacs-ellama: Update to 1.8.0.
Date: Wed, 2 Apr 2025 11:01:49 -0400

Fix borked patch in v2.

Suhail (4):
  gnu: emacs-llm: Update to 0.24.2.
  gnu: emacs-llm: Fix style.
  gnu: emacs-ellama: Update to 1.8.0.
  gnu: emacs-ellama: Enable tests; install info manual.

 gnu/packages/emacs-xyz.scm | 50 ++++++++++++++++++++++++++------------
 1 file changed, 35 insertions(+), 15 deletions(-)


base-commit: 77d5eb4c16984e430b377e0b5f1551fbda171ec6

Message #44 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v3 1/4] gnu: emacs-llm: Update to 0.24.2.
Date: Sun, 30 Mar 2025 12:38:25 -0400

* gnu/packages/emacs-xyz.scm (emacs-llm): Update to 0.24.2.

Change-Id: I6b11acfb53deee417a4f1727fa2e36f179823a1e
---
 gnu/packages/emacs-xyz.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b5dc07acbb..ce36e78c9b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1876,7 +1876,7 @@ (define-public emacs-llama
 (define-public emacs-llm
   (package
     (name "emacs-llm")
-    (version "0.23.0")
+    (version "0.24.2")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -1885,8 +1885,12 @@ (define-public emacs-llm
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "18dl1a6npx0vlqd4mdrqj7ja7cjdfw366qml1pspy92q4l65pyh6"))))
+                "0kza3jzabp5ilapi3a0ycrc26gvj6s2nf3x1ly4c8d3si6fdlx61"))))
     (build-system emacs-build-system)
+    (arguments
+     (list
+      ;; there are no tests
+      #:tests? #f))
     (propagated-inputs (list emacs-plz
                              emacs-plz-event-source
                              emacs-plz-media-type))

Message #47 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v3 2/4] gnu: emacs-llm: Fix style.
Date: Wed, 2 Apr 2025 09:52:23 -0400

* gnu/packages/emacs-xyz.scm (emacs-llm): Fix style.

Change-Id: Ia6638963bf19b916ac40a64e967bbe10c9eccf06
---
 gnu/packages/emacs-xyz.scm | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ce36e78c9b..6acab6b8ef 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1877,22 +1877,21 @@ (define-public emacs-llm
   (package
     (name "emacs-llm")
     (version "0.24.2")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/ahyatt/llm")
-                    (commit version)))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "0kza3jzabp5ilapi3a0ycrc26gvj6s2nf3x1ly4c8d3si6fdlx61"))))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ahyatt/llm")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0kza3jzabp5ilapi3a0ycrc26gvj6s2nf3x1ly4c8d3si6fdlx61"))))
     (build-system emacs-build-system)
     (arguments
      (list
       ;; there are no tests
       #:tests? #f))
-    (propagated-inputs (list emacs-plz
-                             emacs-plz-event-source
+    (propagated-inputs (list emacs-plz emacs-plz-event-source
                              emacs-plz-media-type))
     (home-page "https://github.com/ahyatt/llm")
     (synopsis "Emacs library abstracting Large Language Model capabilities")

Message #50 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v3 3/4] gnu: emacs-ellama: Update to 1.8.0.
Date: Sun, 30 Mar 2025 12:42:34 -0400

* gnu/packages/emacs-xyz.scm (emacs-ellama): Update to 1.8.0.

Change-Id: I516f99587b0381b8635d1161c56bda5d7db35920
---
 gnu/packages/emacs-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6acab6b8ef..5189ddd5d1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -5779,7 +5779,7 @@ (define-public emacs-elf-mode
 (define-public emacs-ellama
   (package
     (name "emacs-ellama")
-    (version "1.4.5")
+    (version "1.8.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -5787,9 +5787,9 @@ (define-public emacs-ellama
                     (commit version)))
               (file-name (git-file-name name version))
               (sha256 (base32
-                       "1d2z7hc2h583g11rr1labmlvfs27336qxgp9q9nv2fh0f9l1qnv4"))))
+                       "075bxdy2jzaq4nw2vpzlmxlq3mlvr0dklva5hbpzqm6pvwa2xz1k"))))
     (build-system emacs-build-system)
-    (propagated-inputs (list emacs-compat emacs-dash emacs-llm emacs-spinner))
+    (propagated-inputs (list emacs-compat emacs-llm emacs-plz emacs-transient))
     (home-page "https://github.com/s-kostyaev/ellama")
     (synopsis "Tool for interacting with LLMs")
     (description

Message #53 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v3 4/4] gnu: emacs-ellama: Enable tests; install info manual.
Date: Wed, 2 Apr 2025 10:42:12 -0400

* gnu/packages/emacs-xyz.scm (emacs-ellama)[arguments]: Enable tests; skip
failing; install included pre-generated info manual.

Change-Id: I1b468c7b30ad35ae553d354ef63da2d4d1c056a7
---
 gnu/packages/emacs-xyz.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5189ddd5d1..2c1e5801eb 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -5789,6 +5789,23 @@ (define-public emacs-ellama
               (sha256 (base32
                        "075bxdy2jzaq4nw2vpzlmxlq3mlvr0dklva5hbpzqm6pvwa2xz1k"))))
     (build-system emacs-build-system)
+    (arguments
+     (list #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'disable-failing-tests
+                 (lambda _
+                   (substitute* (find-files "tests/" "\\.el$")
+                     (("\\(ert-deftest test-ellama-context-element-extract-info-node .*" all)
+                      (string-append all "(skip-unless nil)\n")))))
+               (add-after 'install 'install-info
+                 (lambda _
+                   (install-file "ellama.info"
+                                 (string-append #$output "/share/info")))))
+           #:tests? #t
+           #:test-command #~(list "emacs" "-Q" "--batch"
+                                  "-l" "ellama.el"
+                                  "-l" "tests/test-ellama.el"
+                                  "-f" "ert-run-tests-batch-and-exit")))
     (propagated-inputs (list emacs-compat emacs-llm emacs-plz emacs-transient))
     (home-page "https://github.com/s-kostyaev/ellama")
     (synopsis "Tool for interacting with LLMs")

Message #56 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Suhail Singh <suhailsingh247 <at> gmail.com>, 77391 <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Ian Eure <ian <at> retrospec.tv>, Cayetano Santos <csantosb <at> inventati.org>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#77391] [PATCH v3 0/4] gnu: emacs-ellama: Update to 1.8.0.
Date: Wed, 02 Apr 2025 17:37:37 +0200

Am Mittwoch, dem 02.04.2025 um 11:01 -0400 schrieb Suhail Singh:
> Fix borked patch in v2.
> 
> Suhail (4):
>   gnu: emacs-llm: Update to 0.24.2.
>   gnu: emacs-llm: Fix style.
>   gnu: emacs-ellama: Update to 1.8.0.
>   gnu: emacs-ellama: Enable tests; install info manual.
Using a semicolon in the commit title is a sign that you're doing too
much in a single commit ;)

Cheers

Message #59 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: "Suhail Singh" <suhailsingh247 <at> gmail.com>
Cc: 77391 <at> debbugs.gnu.org, Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>
Subject: Re: [bug#77391] [PATCH v3 4/4] gnu: emacs-ellama: Enable tests;
 install info manual.
Date: Wed, 02 Apr 2025 17:41:52 +0200

[Message part 1 (text/plain, inline)]

>Wed 02 Apr 2025 at 10:42, "Suhail Singh" <suhailsingh247 <at> gmail.com> wrote:

> +               (add-after 'install 'install-info
> +                 (lambda _
> +                   (install-file "ellama.info"
> +                                 (string-append #$output "/share/info")))))

Correct me if I’m wrong, but there is no need to install the info file,
the emacs builder takes care of this.

[signature.asc (application/pgp-signature, inline)]

Message #62 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: Suhail Singh <suhailsingh247 <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 77391 <at> debbugs.gnu.org, Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Cayetano Santos <csantosb <at> inventati.org>, Andrew Tropin <andrew <at> trop.in>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>,
 Suhail Singh <suhailsingh247 <at> gmail.com>
Subject: Re: [bug#77391] [PATCH v3 0/4] gnu: emacs-ellama: Update to 1.8.0.
Date: Wed, 02 Apr 2025 17:57:48 -0400

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

>>   gnu: emacs-ellama: Enable tests; install info manual.
> Using a semicolon in the commit title is a sign that you're doing too
> much in a single commit ;)

And seemingly, in this case, unnecessarily.  Thanks for the feedback.

-- 
Suhail

Message #65 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: Suhail Singh <suhailsingh247 <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 77391 <at> debbugs.gnu.org, Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>,
 Suhail Singh <suhailsingh247 <at> gmail.com>
Subject: Re: [bug#77391] [PATCH v3 4/4] gnu: emacs-ellama: Enable tests;
 install info manual.
Date: Wed, 02 Apr 2025 18:00:52 -0400

Cayetano Santos <csantosb <at> inventati.org> writes:

> there is no need to install the info file, the emacs builder takes
> care of this.

Seems so, based on the code of the 'move-doc phase.  Thanks!

-- 
Suhail

Message #68 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v4 0/4] gnu: emacs-ellama: Update to 1.8.0.
Date: Wed, 2 Apr 2025 18:14:35 -0400

Removed superfluous phase from v3.

Suhail (4):
  gnu: emacs-llm: Update to 0.24.2.
  gnu: emacs-llm: Fix style.
  gnu: emacs-ellama: Update to 1.8.0.
  gnu: emacs-ellama: Enable tests.

 gnu/packages/emacs-xyz.scm | 46 +++++++++++++++++++++++++-------------
 1 file changed, 31 insertions(+), 15 deletions(-)


base-commit: 77d5eb4c16984e430b377e0b5f1551fbda171ec6

Message #71 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v4 1/4] gnu: emacs-llm: Update to 0.24.2.
Date: Sun, 30 Mar 2025 12:38:25 -0400

* gnu/packages/emacs-xyz.scm (emacs-llm): Update to 0.24.2.

Change-Id: I6b11acfb53deee417a4f1727fa2e36f179823a1e
---
 gnu/packages/emacs-xyz.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b5dc07acbb..ce36e78c9b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1876,7 +1876,7 @@ (define-public emacs-llama
 (define-public emacs-llm
   (package
     (name "emacs-llm")
-    (version "0.23.0")
+    (version "0.24.2")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -1885,8 +1885,12 @@ (define-public emacs-llm
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "18dl1a6npx0vlqd4mdrqj7ja7cjdfw366qml1pspy92q4l65pyh6"))))
+                "0kza3jzabp5ilapi3a0ycrc26gvj6s2nf3x1ly4c8d3si6fdlx61"))))
     (build-system emacs-build-system)
+    (arguments
+     (list
+      ;; there are no tests
+      #:tests? #f))
     (propagated-inputs (list emacs-plz
                              emacs-plz-event-source
                              emacs-plz-media-type))

Message #74 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v4 2/4] gnu: emacs-llm: Fix style.
Date: Wed, 2 Apr 2025 09:52:23 -0400

* gnu/packages/emacs-xyz.scm (emacs-llm): Fix style.

Change-Id: Ia6638963bf19b916ac40a64e967bbe10c9eccf06
---
 gnu/packages/emacs-xyz.scm | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ce36e78c9b..6acab6b8ef 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1877,22 +1877,21 @@ (define-public emacs-llm
   (package
     (name "emacs-llm")
     (version "0.24.2")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/ahyatt/llm")
-                    (commit version)))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "0kza3jzabp5ilapi3a0ycrc26gvj6s2nf3x1ly4c8d3si6fdlx61"))))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ahyatt/llm")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0kza3jzabp5ilapi3a0ycrc26gvj6s2nf3x1ly4c8d3si6fdlx61"))))
     (build-system emacs-build-system)
     (arguments
      (list
       ;; there are no tests
       #:tests? #f))
-    (propagated-inputs (list emacs-plz
-                             emacs-plz-event-source
+    (propagated-inputs (list emacs-plz emacs-plz-event-source
                              emacs-plz-media-type))
     (home-page "https://github.com/ahyatt/llm")
     (synopsis "Emacs library abstracting Large Language Model capabilities")

Message #77 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v4 3/4] gnu: emacs-ellama: Update to 1.8.0.
Date: Sun, 30 Mar 2025 12:42:34 -0400

* gnu/packages/emacs-xyz.scm (emacs-ellama): Update to 1.8.0.

Change-Id: I516f99587b0381b8635d1161c56bda5d7db35920
---
 gnu/packages/emacs-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6acab6b8ef..5189ddd5d1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -5779,7 +5779,7 @@ (define-public emacs-elf-mode
 (define-public emacs-ellama
   (package
     (name "emacs-ellama")
-    (version "1.4.5")
+    (version "1.8.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -5787,9 +5787,9 @@ (define-public emacs-ellama
                     (commit version)))
               (file-name (git-file-name name version))
               (sha256 (base32
-                       "1d2z7hc2h583g11rr1labmlvfs27336qxgp9q9nv2fh0f9l1qnv4"))))
+                       "075bxdy2jzaq4nw2vpzlmxlq3mlvr0dklva5hbpzqm6pvwa2xz1k"))))
     (build-system emacs-build-system)
-    (propagated-inputs (list emacs-compat emacs-dash emacs-llm emacs-spinner))
+    (propagated-inputs (list emacs-compat emacs-llm emacs-plz emacs-transient))
     (home-page "https://github.com/s-kostyaev/ellama")
     (synopsis "Tool for interacting with LLMs")
     (description

Message #80 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v4 4/4] gnu: emacs-ellama: Enable tests.
Date: Wed, 2 Apr 2025 10:42:12 -0400

* gnu/packages/emacs-xyz.scm (emacs-ellama)[arguments]: Enable tests; skip
failing.

Change-Id: I1b468c7b30ad35ae553d354ef63da2d4d1c056a7
---
 gnu/packages/emacs-xyz.scm | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5189ddd5d1..f8324bf00d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -5789,6 +5789,19 @@ (define-public emacs-ellama
               (sha256 (base32
                        "075bxdy2jzaq4nw2vpzlmxlq3mlvr0dklva5hbpzqm6pvwa2xz1k"))))
     (build-system emacs-build-system)
+    (arguments
+     (list #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'disable-failing-tests
+                 (lambda _
+                   (substitute* (find-files "tests/" "\\.el$")
+                     (("\\(ert-deftest test-ellama-context-element-extract-info-node .*" all)
+                      (string-append all "(skip-unless nil)\n"))))))
+           #:tests? #t
+           #:test-command #~(list "emacs" "-Q" "--batch"
+                                  "-l" "ellama.el"
+                                  "-l" "tests/test-ellama.el"
+                                  "-f" "ert-run-tests-batch-and-exit")))
     (propagated-inputs (list emacs-compat emacs-llm emacs-plz emacs-transient))
     (home-page "https://github.com/s-kostyaev/ellama")
     (synopsis "Tool for interacting with LLMs")

Message #83 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <cayetano.santos <at> inventati.org>
To: "Suhail Singh" <suhailsingh247 <at> gmail.com>
Cc: 77391 <at> debbugs.gnu.org, Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Cayetano Santos <csantosb <at> inventati.org>, Andrew Tropin <andrew <at> trop.in>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#77391] [PATCH v4 4/4] gnu: emacs-ellama: Enable tests.
Date: Thu, 03 Apr 2025 08:58:46 +0200

>Wed 02 Apr 2025 at 10:42, "Suhail Singh" <suhailsingh247 <at> gmail.com> wrote:

> * gnu/packages/emacs-xyz.scm (emacs-ellama)[arguments]: Enable tests; skip
> failing.

> +    (arguments
> +     (list #:phases
> +           #~(modify-phases %standard-phases
> +               (add-after 'unpack 'disable-failing-tests
> +                 (lambda _
> +                   (substitute* (find-files "tests/" "\\.el$")
> +                     (("\\(ert-deftest test-ellama-context-element-extract-info-node .*" all)

This line 5798 is way too long (93 characters), as for the linter.

Other than this, looks good to me.

Message #86 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: Suhail Singh <suhailsingh247 <at> gmail.com>
To: Cayetano Santos <cayetano.santos <at> inventati.org>
Cc: 77391 <at> debbugs.gnu.org, Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Cayetano Santos <csantosb <at> inventati.org>, Andrew Tropin <andrew <at> trop.in>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>,
 Suhail Singh <suhailsingh247 <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#77391] [PATCH v4 4/4] gnu: emacs-ellama: Enable tests.
Date: Thu, 03 Apr 2025 09:07:47 -0400

Cayetano Santos <cayetano.santos <at> inventati.org> writes:

>> +                     (("\\(ert-deftest test-ellama-context-element-extract-info-node .*" all)
>
> This line 5798 is way too long (93 characters), as for the linter.

Indeed.  Even with the "all)" on the subsequent line it'd be too long.
An option may be to split the string into multiple and concatenate it,
but I believe it would hurt readability for little gain.

I'll be happy with whatever decision someone with commit rights makes in
this regard.  In the meanwhile, it seems 1.8.1 is out so I'll send v5.

-- 
Suhail

Message #89 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v5 0/4] gnu: emacs-ellama: Update to 1.8.1.
Date: Thu, 3 Apr 2025 09:10:58 -0400

FYI, there's a linter warning regarding a long line in the emacs-ellama
package.  It's unclear (to me) what the best course of action is.  I'm
happy leaving it to the discretion of the person who'll be merging this
changeset.

Suhail (4):
  gnu: emacs-llm: Update to 0.24.2.
  gnu: emacs-llm: Fix style.
  gnu: emacs-ellama: Update to 1.8.1.
  gnu: emacs-ellama: Enable tests.

 gnu/packages/emacs-xyz.scm | 46 +++++++++++++++++++++++++-------------
 1 file changed, 31 insertions(+), 15 deletions(-)


base-commit: 77d5eb4c16984e430b377e0b5f1551fbda171ec6

Message #92 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v5 1/4] gnu: emacs-llm: Update to 0.24.2.
Date: Sun, 30 Mar 2025 12:38:25 -0400

* gnu/packages/emacs-xyz.scm (emacs-llm): Update to 0.24.2.

Change-Id: I6b11acfb53deee417a4f1727fa2e36f179823a1e
---
 gnu/packages/emacs-xyz.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b5dc07acbb..ce36e78c9b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1876,7 +1876,7 @@ (define-public emacs-llama
 (define-public emacs-llm
   (package
     (name "emacs-llm")
-    (version "0.23.0")
+    (version "0.24.2")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -1885,8 +1885,12 @@ (define-public emacs-llm
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "18dl1a6npx0vlqd4mdrqj7ja7cjdfw366qml1pspy92q4l65pyh6"))))
+                "0kza3jzabp5ilapi3a0ycrc26gvj6s2nf3x1ly4c8d3si6fdlx61"))))
     (build-system emacs-build-system)
+    (arguments
+     (list
+      ;; there are no tests
+      #:tests? #f))
     (propagated-inputs (list emacs-plz
                              emacs-plz-event-source
                              emacs-plz-media-type))

Message #95 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v5 2/4] gnu: emacs-llm: Fix style.
Date: Wed, 2 Apr 2025 09:52:23 -0400

* gnu/packages/emacs-xyz.scm (emacs-llm): Fix style.

Change-Id: Ia6638963bf19b916ac40a64e967bbe10c9eccf06
---
 gnu/packages/emacs-xyz.scm | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ce36e78c9b..6acab6b8ef 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1877,22 +1877,21 @@ (define-public emacs-llm
   (package
     (name "emacs-llm")
     (version "0.24.2")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/ahyatt/llm")
-                    (commit version)))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "0kza3jzabp5ilapi3a0ycrc26gvj6s2nf3x1ly4c8d3si6fdlx61"))))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ahyatt/llm")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0kza3jzabp5ilapi3a0ycrc26gvj6s2nf3x1ly4c8d3si6fdlx61"))))
     (build-system emacs-build-system)
     (arguments
      (list
       ;; there are no tests
       #:tests? #f))
-    (propagated-inputs (list emacs-plz
-                             emacs-plz-event-source
+    (propagated-inputs (list emacs-plz emacs-plz-event-source
                              emacs-plz-media-type))
     (home-page "https://github.com/ahyatt/llm")
     (synopsis "Emacs library abstracting Large Language Model capabilities")

Message #98 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v5 3/4] gnu: emacs-ellama: Update to 1.8.1.
Date: Sun, 30 Mar 2025 12:42:34 -0400

* gnu/packages/emacs-xyz.scm (emacs-ellama): Update to 1.8.1.

Change-Id: I516f99587b0381b8635d1161c56bda5d7db35920
---
 gnu/packages/emacs-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6acab6b8ef..7513bbf68e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -5779,7 +5779,7 @@ (define-public emacs-elf-mode
 (define-public emacs-ellama
   (package
     (name "emacs-ellama")
-    (version "1.4.5")
+    (version "1.8.1")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -5787,9 +5787,9 @@ (define-public emacs-ellama
                     (commit version)))
               (file-name (git-file-name name version))
               (sha256 (base32
-                       "1d2z7hc2h583g11rr1labmlvfs27336qxgp9q9nv2fh0f9l1qnv4"))))
+                       "1019vwrm95ck2gi29mvwd7sy753zgwa3addw2x0qbhvb3r53620v"))))
     (build-system emacs-build-system)
-    (propagated-inputs (list emacs-compat emacs-dash emacs-llm emacs-spinner))
+    (propagated-inputs (list emacs-compat emacs-llm emacs-plz emacs-transient))
     (home-page "https://github.com/s-kostyaev/ellama")
     (synopsis "Tool for interacting with LLMs")
     (description

Message #101 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 77391 <at> debbugs.gnu.org
Subject: [PATCH v5 4/4] gnu: emacs-ellama: Enable tests.
Date: Wed, 2 Apr 2025 10:42:12 -0400

* gnu/packages/emacs-xyz.scm (emacs-ellama)[arguments]: Enable tests; skip
failing.

Change-Id: I1b468c7b30ad35ae553d354ef63da2d4d1c056a7
---
 gnu/packages/emacs-xyz.scm | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7513bbf68e..ac5ae3002a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -5789,6 +5789,19 @@ (define-public emacs-ellama
               (sha256 (base32
                        "1019vwrm95ck2gi29mvwd7sy753zgwa3addw2x0qbhvb3r53620v"))))
     (build-system emacs-build-system)
+    (arguments
+     (list #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'disable-failing-tests
+                 (lambda _
+                   (substitute* (find-files "tests/" "\\.el$")
+                     (("\\(ert-deftest test-ellama-context-element-extract-info-node .*" all)
+                      (string-append all "(skip-unless nil)\n"))))))
+           #:tests? #t
+           #:test-command #~(list "emacs" "-Q" "--batch"
+                                  "-l" "ellama.el"
+                                  "-l" "tests/test-ellama.el"
+                                  "-f" "ert-run-tests-batch-and-exit")))
     (propagated-inputs (list emacs-compat emacs-llm emacs-plz emacs-transient))
     (home-page "https://github.com/s-kostyaev/ellama")
     (synopsis "Tool for interacting with LLMs")

Message #104 received at 77391 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: GNU bug tracker automated control server <control <at> debbugs.gnu.org>
Cc: 77391 <at> debbugs.gnu.org, Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>,
 Suhail Singh <suhailsingh247 <at> gmail.com>
Subject: QA review for bug #77391
Date: Thu, 03 Apr 2025 15:29:25 +0200

[Message part 1 (text/plain, inline)]

user guix
usertag 77391 + reviewed-looks-good
thanks

Items marked as checked:

- commit messages
- package builds
- lint warnings
- package style
- no dependent packages
- synopsis and descriptions
- package tests
- licenses

[signature.asc (application/pgp-signature, inline)]

Message #109 received at 77391-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>, 77391-done <at> debbugs.gnu.org,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>,
 Suhail Singh <suhailsingh247 <at> gmail.com>
Subject: Re: QA review for bug #77391
Date: Thu, 3 Apr 2025 19:58:58 +0200

Hello,

thanks for the patches and the reviews! I have pushed them
(with a slightly shorter, but still too long line; but I found it preferable
to remain above the 76 character limit for the sake of readability).

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.