GNU bug report logs - #77224
[PATCH] New minor mode 'cursor-indicators-mode'

Previous Next

Full log

Message #38 received at 77224 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 77224 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode'
Date: Wed, 26 Mar 2025 18:50:47 -0600

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Juri Linkov <juri <at> linkov.net>
>> Cc: Eli Zaretskii <eliz <at> gnu.org>,  77224 <at> debbugs.gnu.org
>> Date: Wed, 26 Mar 2025 09:58:06 +0200

>> > I've updated the patch following Juri suggestions.
>> > Now all the conditions are inside a single defcustom.

>> Thanks!  I tested that everything works nicely.
>> There is only one small problem for repeat-mode:

>> > +        (add-hook 'post-command-hook #'cursor-indicators--update-indications)

>> It would be better to use a large value DEPTH for add-hook
>> to add the hook to the end.  The problem is that repeat-mode
>> also uses the same hook 'post-command-hook'.  So the cursor
>> indication hook should be called afterwards as the last hook.

> Would it be better to use an idle timer instead?  post-command-hook
> tends to make Emacs sluggish.

Yeah, that is that what worried me when i decided to use that hook.

I've fixed the patch to use only idle-timer instead.

[Message part 2 (text/html, inline)]

[0001-New-minor-mode-cursor-indicators-mode.patch (text/x-patch, attachment)]

[Message part 4 (text/plain, inline)]

-- 
                                          - E.G via GNU Emacs and Org.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.