GNU bug report logs - #77223
[PATCH] gnu: Add emacs-migemo.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77223 in the body.
You can then email your comments to 77223 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "King, Spencer" <spencer.king <at> wustl.edu>
To: "King, Spencer via Guix-patches via" <guix-patches <at> gnu.org>
Cc: "ian <at> retrospec.tv" <ian <at> retrospec.tv>,
 "cox.katherine.e+guix <at> gmail.com" <cox.katherine.e+guix <at> gmail.com>,
 "liliana.prikler <at> gmail.com" <liliana.prikler <at> gmail.com>,
 "csantosb <at> inventati.org" <csantosb <at> inventati.org>,
 "divya <at> subvertising.org" <divya <at> subvertising.org>,
 "andrew <at> trop.in" <andrew <at> trop.in>
Subject: [PATCH] gnu: Add emacs-migemo.
Date: Sun, 23 Mar 2025 22:52:51 +0000

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-emacs-migemo.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: spencer.king <at> wustl.edu, 77223 <at> debbugs.gnu.org, ian <at> retrospec.tv,
 cox.katherine.e+guix <at> gmail.com, csantosb <at> inventati.org, andrew <at> trop.in,
 divya <at> subvertising.org, liliana.prikler <at> gmail.com
Subject: Re: [bug#77223] [PATCH] gnu: Add emacs-migemo.
Date: Tue, 25 Mar 2025 09:37:58 +0100

[Message part 1 (text/plain, inline)]

Thanks for the patch.

Note that 1.9.2 dates back from 6 years ago, maybe packaging latest
revision from last month is a better option.

Could you include the no tests flag to comply with upcoming changes in
emacs packages ?

(arguments
       ;; no tests
       (list #:tests? #false))

C.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 77223 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: spencer.king <at> wustl.edu, 77223 <at> debbugs.gnu.org,
 cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, andrew <at> trop.in,
 divya <at> subvertising.org
Subject: Re: [bug#77223] [PATCH] gnu: Add emacs-migemo.
Date: Sat, 29 Mar 2025 08:54:21 -0700

Hi Spencer, Cayetano,

Cayetano Santos <csantosb <at> inventati.org> writes:

> Thanks for the patch.
>
> Note that 1.9.2 dates back from 6 years ago, maybe packaging 
> latest
> revision from last month is a better option.
>
> Could you include the no tests flag to comply with upcoming 
> changes in
> emacs packages ?

I agree with these suggestions.  Also, please resend using `git 
send-email'.  See (guix)Contributing[1] for more on this.

[1]: 
https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html#Single-Patches-1

Message #17 received at 77223 <at> debbugs.gnu.org (full text, mbox):

From: "King, Spencer" <spencer.king <at> wustl.edu>
To: "77223 <at> debbugs.gnu.org" <77223 <at> debbugs.gnu.org>
Cc: Cayetano Santos <csantosb <at> inventati.org>,
 "ian <at> retrospec.tv" <ian <at> retrospec.tv>
Date: Sat, 29 Mar 2025 23:07:30 +0000

[Message part 1 (text/plain, inline)]

Hello,

Attached is an updated patch with the suggested changes. I have had issues using git send-email with my preferred email account due to required multi-factor authentication so I have always sent patches as attachments on plain text emails. This has been fine for other teams. Is there an option I could provide to git format-patch that would make these patches easier for you to work with?

Best,
Spencer

[0001-gnu-Add-emacs-migemo.patch (text/x-patch, attachment)]

Message #20 received at 77223 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: "King, Spencer" <spencer.king <at> wustl.edu>
Cc: Cayetano Santos <csantosb <at> inventati.org>,
 "77223 <at> debbugs.gnu.org" <77223 <at> debbugs.gnu.org>
Subject: Re: [bug#77223]
Date: Sat, 29 Mar 2025 19:59:57 -0700

Hi Spencer,

"King, Spencer" <spencer.king <at> wustl.edu> writes:

> Hello,
>
> Attached is an updated patch with the suggested changes. I have 
> had
> issues using git send-email with my preferred email account due 
> to
> required multi-factor authentication so I have always sent 
> patches as
> attachments on plain text emails. This has been fine for other
> teams. Is there an option I could provide to git format-patch 
> that
> would make these patches easier for you to work with?

Different maintainers use differend tooling.  For whatever reason, 
`mumi am' couldn’t locate your first patch, but did find the 
second one.

It looks like the #:tests? suggestion Cayetano made didn’t make it 
into this patch.  The default will be changing to run tests very 
soon, so it’s important to set that if the package has none.

Thanks,

 -- Ian

Message #23 received at 77223 <at> debbugs.gnu.org (full text, mbox):

From: "King, Spencer" <spencer.king <at> wustl.edu>
To: "77223 <at> debbugs.gnu.org" <77223 <at> debbugs.gnu.org>
Cc: "ian <at> retrospec.tv" <ian <at> retrospec.tv>
Date: Tue, 1 Apr 2025 06:38:01 +0000

[Message part 1 (text/plain, inline)]

Hi Ian,

I do see the #:tests? suggestion in that patch. Regardless, I've attached an updated patch that fixes a small typo in a comment I had initially overlooked.

Best,
Spencer

[0001-gnu-Add-emacs-migemo.patch (text/x-patch, attachment)]

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: spencer.king <at> wustl.edu, 77223 <at> debbugs.gnu.org, ian <at> retrospec.tv
Subject: Re: [bug#77223]
Date: Tue, 01 Apr 2025 10:58:58 +0200

[Message part 1 (text/plain, inline)]

You need to fix also the version field, as this is a non release package.

  (version (git-version "XXX" revision commit))

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 77223 <at> debbugs.gnu.org (full text, mbox):

From: "King, Spencer" <spencer.king <at> wustl.edu>
To: "77223 <at> debbugs.gnu.org" <77223 <at> debbugs.gnu.org>
Cc: Cayetano Santos <csantosb <at> inventati.org>
Date: Wed, 2 Apr 2025 00:16:07 +0000

[Message part 1 (text/plain, inline)]

Sorry about that, here is an updated patch.

Best,
Spencer

[0001-gnu-Add-emacs-migemo.patch (text/x-patch, attachment)]

Message #35 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: spencer.king <at> wustl.edu, csantosb <at> inventati.org, 77223 <at> debbugs.gnu.org
Subject: Re: [bug#77223]
Date: Wed, 02 Apr 2025 09:23:54 +0200

[Message part 1 (text/plain, inline)]

I would include a comment on why the tests are disabled (this package
provides testing), as cmigemo is not available in guix repos (correct me
if I’m wrong).

Other than this, seems ok to me.

[signature.asc (application/pgp-signature, inline)]

Message #41 received at 77223 <at> debbugs.gnu.org (full text, mbox):

From: "King, Spencer" <spencer.king <at> wustl.edu>
To: "77223 <at> debbugs.gnu.org" <77223 <at> debbugs.gnu.org>
Cc: Cayetano Santos <csantosb <at> inventati.org>
Date: Thu, 3 Apr 2025 01:59:09 +0000

[Message part 1 (text/plain, inline)]

I've added a comment noting that cmigemo is not yet packaged in guix. 

[0001-gnu-Add-emacs-migemo.patch (text/x-patch, attachment)]

Message #44 received at 77223 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: GNU bug tracker automated control server <control <at> debbugs.gnu.org>
Cc: "King, Spencer" <spencer.king <at> wustl.edu>,
 "77223 <at> debbugs.gnu.org" <77223 <at> debbugs.gnu.org>
Subject: QA review for 77223
Date: Thu, 03 Apr 2025 10:09:44 +0200

[Message part 1 (text/plain, inline)]

user guix
usertag 77223 + reviewed-looks-good
thanks

Items marked as checked:

- commit messages

  tried to apply with:

   + mumi current 77223 && mumi am @9
   + b4 shazam CH3PR02MB9746D9C944908D3926E748CD90AE2 <at> CH3PR02MB9746.namprd02.prod.outlook.com
   + git am --3way maildir_with_patch

  In all cases the message is wrong.

- package builds
- lint warnings
- package style
- no dependent packages
- synopsis and descriptions
- package tests disabled and explained
- license

[signature.asc (application/pgp-signature, inline)]

Message #49 received at 77223-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: "King, Spencer" <spencer.king <at> wustl.edu>
Cc: Cayetano Santos <csantosb <at> inventati.org>, 77223-done <at> debbugs.gnu.org,
 Ian Eure <ian <at> retrospec.tv>
Subject: Re:
Date: Thu, 3 Apr 2025 13:51:52 +0200

Pushed, thanks!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.