GNU bug report logs - #77224
[PATCH] New minor mode 'cursor-indicators-mode'

Previous Next

Full log

Message #101 received at 77224 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: mail <at> daniel-mendler.de, juri <at> linkov.net, 77224 <at> debbugs.gnu.org
Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode'
Date: Thu, 27 Mar 2025 21:25:22 +0200

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Cc: Daniel Mendler <mail <at> daniel-mendler.de>,  77224 <at> debbugs.gnu.org,
>   juri <at> linkov.net
> Date: Thu, 27 Mar 2025 12:27:22 -0600
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
>  Anyway, I think making the cursor change from a mode hook is a better
>  solution.
> 
>  As has been mentioned, the problem is that not every scenario is covered
>  by hooks, while the PCH is a potentially universal solution which can
>  check arbitrary conditions. But if hooks work sufficiently well for most
>  scenarios, then why not.
> 
>  If there are cases that this indication supports but there's no mode
>  hook for them, let's discuss those cases one by one and see how to
>  solve them. I see overwrite-mode, read-only-mode, and input-method
>  activation, all of which have hooks, AFAIR.
> 
> But the problem with using hooks is that modes sometimes defines a
> specific name for hook or use different hooks for that, for example
> overwrite-mode only defines overwrite-mode-hook, however input-method
> defines input-method-activate-hook and input-method-deactivate-hook or
> mark/region have activate-mark-hook and deactivate-mark-hook.

If there's a single hook, it is called both when turning the mode on
and when turning it off, so I'm not sure I see the problem.

Anyway, I think I'm done arguing.  I'm quite sure you all understand
my opinions and suggestions; if you want to disregard them and use the
post-command-hook anyway, feel free, but don't be surprised if someone
then complains that Emacs became a tad slower: it's because of all
these features that take the easy way out and use post-command-hook,
and by that add yet another one of those small slowdowns, which add up
and up...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.