GNU bug report logs -
#7717
24.0.50; "games" user is hardcoded in build system
Previous Next
Reported by: Ulrich Mueller <ulm <at> gentoo.org>
Date: Thu, 23 Dec 2010 08:31:01 UTC
Severity: normal
Tags: patch
Found in version 24.0.50
Done: Chong Yidong <cyd <at> stupidchicken.com>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Your bug report
#7717: 24.0.50; "games" user is hardcoded in build system
which was filed against the emacs package, has been closed.
The explanation is attached below, along with your original report.
If you require more details, please reply to 7717 <at> debbugs.gnu.org.
--
7717: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7717
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
Ulrich Mueller <ulm <at> gentoo.org> writes:
> The build system of Emacs currently hardcodes the "games" user that is
> used for shared score files in ${localstatedir}. While usage of that
> account name may be widespread, it is not universal. For example, in
> Gentoo the name is configurable.
>
> Since a variable "gameuser" and the autoconf plumbing for it already
> exist, the only missing piece is a configure option. See attached
> patch.
Looks reasonable. Committed to trunk; thanks.
[Message part 3 (message/rfc822, inline)]
[Message part 4 (text/plain, inline)]
Tags: patch
The build system of Emacs currently hardcodes the "games" user that is
used for shared score files in ${localstatedir}. While usage of that
account name may be widespread, it is not universal. For example, in
Gentoo the name is configurable.
Since a variable "gameuser" and the autoconf plumbing for it already
exist, the only missing piece is a configure option. See attached
patch.
2010-12-22 Ulrich Mueller <ulm <at> gentoo.org>
* configure.in: Make gameuser configurable.
[emacs-gameuser.diff (text/plain, inline)]
--- emacs-orig/configure.in
+++ emacs/configure.in
@@ -45,8 +45,6 @@
docdir='${datadir}/emacs/${version}/etc'
gamedir='${localstatedir}/games/emacs'
-gameuser=games
-
dnl OPTION_DEFAULT_OFF(NAME, HELP-STRING)
dnl Create a new --with option that defaults to being disabled.
dnl NAME is the base name of the option. The shell variable with_NAME
@@ -203,6 +201,13 @@
The default is /usr/lib, or /usr/lib64 on some platforms.])])
CRT_DIR="${with_crt_dir}"
+AC_ARG_WITH(gameuser,
+[AS_HELP_STRING([--with-gameuser=USER],
+ [user for shared score files; default games])])
+test "X${with_gameuser}" != X && test "${with_gameuser}" != yes \
+ && gameuser="${with_gameuser}"
+test "X$gameuser" = X && gameuser=games
+
AC_ARG_WITH([gnustep-conf],dnl
[AS_HELP_STRING([--with-gnustep-conf=PATH],[path to GNUstep.conf; default $GNUSTEP_CONFIG_FILE, or /etc/GNUstep/GNUstep.conf])])
test "X${with_gnustep_conf}" != X && test "${with_gnustep_conf}" != yes && \
This bug report was last modified 14 years and 143 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.