GNU bug report logs - #7717
24.0.50; "games" user is hardcoded in build system

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7717 in the body.
You can then email your comments to 7717 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ulrich Mueller <ulm <at> gentoo.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; "games" user is hardcoded in build system
Date: Thu, 23 Dec 2010 09:36:42 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

The build system of Emacs currently hardcodes the "games" user that is
used for shared score files in ${localstatedir}. While usage of that
account name may be widespread, it is not universal. For example, in
Gentoo the name is configurable.

Since a variable "gameuser" and the autoconf plumbing for it already
exist, the only missing piece is a configure option. See attached
patch.


2010-12-22  Ulrich Mueller  <ulm <at> gentoo.org>

	* configure.in: Make gameuser configurable.

[emacs-gameuser.diff (text/plain, inline)]

--- emacs-orig/configure.in
+++ emacs/configure.in
@@ -45,8 +45,6 @@
 docdir='${datadir}/emacs/${version}/etc'
 gamedir='${localstatedir}/games/emacs'
 
-gameuser=games
-
 dnl OPTION_DEFAULT_OFF(NAME, HELP-STRING)
 dnl Create a new --with option that defaults to being disabled.
 dnl NAME is the base name of the option.  The shell variable with_NAME
@@ -203,6 +201,13 @@
 The default is /usr/lib, or /usr/lib64 on some platforms.])])
 CRT_DIR="${with_crt_dir}"
 
+AC_ARG_WITH(gameuser,
+[AS_HELP_STRING([--with-gameuser=USER],
+  [user for shared score files; default games])])
+test "X${with_gameuser}" != X && test "${with_gameuser}" != yes \
+  && gameuser="${with_gameuser}"
+test "X$gameuser" = X && gameuser=games
+
 AC_ARG_WITH([gnustep-conf],dnl
 [AS_HELP_STRING([--with-gnustep-conf=PATH],[path to GNUstep.conf; default $GNUSTEP_CONFIG_FILE, or /etc/GNUstep/GNUstep.conf])])
 test "X${with_gnustep_conf}" != X && test "${with_gnustep_conf}" != yes && \

Message #10 received at 7717-done <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Ulrich Mueller <ulm <at> gentoo.org>
Cc: 7717-done <at> debbugs.gnu.org
Subject: Re: bug#7717: 24.0.50; "games" user is hardcoded in build system
Date: Wed, 29 Dec 2010 19:14:07 +0800

Ulrich Mueller <ulm <at> gentoo.org> writes:

> The build system of Emacs currently hardcodes the "games" user that is
> used for shared score files in ${localstatedir}. While usage of that
> account name may be widespread, it is not universal. For example, in
> Gentoo the name is configurable.
>
> Since a variable "gameuser" and the autoconf plumbing for it already
> exist, the only missing piece is a configure option. See attached
> patch.

Looks reasonable.  Committed to trunk; thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.