GNU bug report logs - #76858
[PATCH] window-tool-bar: Use `static-if' from Compat 30

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76858: closed ([PATCH] window-tool-bar: Use `static-if' from
 Compat 30)
Date: Thu, 13 Mar 2025 06:00:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 12 Mar 2025 22:59:15 -0700
with message-id <CADwFkmnbNT3F2_icB50Zbd=nFJ0OPea8hS3MNSOsmn2hfOPFcw <at> mail.gmail.com>
and subject line Re: bug#76858: [PATCH] window-tool-bar: Use `static-if' from Compat 30
has caused the debbugs.gnu.org bug report #76858,
regarding [PATCH] window-tool-bar: Use `static-if' from Compat 30
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76858: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76858
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Cc: Jared Finder <jared <at> finder.org>
Subject: [PATCH] window-tool-bar: Use `static-if' from Compat 30
Date: Sat, 08 Mar 2025 09:26:57 +0100

[Message part 3 (text/plain, inline)]

Tags: patch

Compat 30 is available on ELPA and provides `static-if'.

[0001-window-tool-bar-Use-static-if-from-Compat-30.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Jared Finder <jared <at> finder.org>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, 76858-done <at> debbugs.gnu.org
Subject: Re: bug#76858: [PATCH] window-tool-bar: Use `static-if' from Compat 30
Date: Wed, 12 Mar 2025 22:59:15 -0700

Version: 31.1

Jared Finder <jared <at> finder.org> writes:

> On 2025-03-08 07:43, Daniel Mendler wrote:
>> Jared Finder <jared <at> finder.org> writes:
>>
>>> On 2025-03-08 00:26, Daniel Mendler wrote:
>>>> Tags: patch
>>>> Compat 30 is available on ELPA and provides `static-if'.
>>> I see this created Bug#76858. (apologies if a new bug is created here)
>>>
>>>> -;; Package-Requires: ((emacs "27.1") (compat "29.1"))
>>>> +;; Package-Requires: ((emacs "27.1") (compat "30"))
>>> I think this also needs (eval-when-compile (require 'compat)) since static-if
>>> is
>>> a macro. But I could be wrong here, I'm always a bit confused about Emacs
>>> Lisp's
>>> eval-when forms.
>> No, (require 'compat) is sufficient.
>
> Ok, I have no objections then.
>
>   -- MJF

Thanks, installed on master as [1: ae33aad7f58].

[1: ae33aad7f58] 2025-03-13
  window-tool-bar: Use `static-if' from Compat 30
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ae33aad7f582864a8dbb0fee10f891fd67abdbe3

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.