GNU bug report logs - #76858
[PATCH] window-tool-bar: Use `static-if' from Compat 30

Previous Next

Package: emacs;

Reported by: Daniel Mendler <mail <at> daniel-mendler.de>

Date: Sat, 8 Mar 2025 08:28:02 UTC

Severity: wishlist

Tags: patch

Fixed in version 31.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76858 in the body.
You can then email your comments to 76858 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#76858; Package emacs. (Sat, 08 Mar 2025 08:28:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Daniel Mendler <mail <at> daniel-mendler.de>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 08 Mar 2025 08:28:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Cc: Jared Finder <jared <at> finder.org>
Subject: [PATCH] window-tool-bar: Use `static-if' from Compat 30
Date: Sat, 08 Mar 2025 09:26:57 +0100

[Message part 1 (text/plain, inline)]
Tags: patch

Compat 30 is available on ELPA and provides `static-if'.


[0001-window-tool-bar-Use-static-if-from-Compat-30.patch (text/patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#76858; Package emacs. (Sat, 08 Mar 2025 15:38:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jared Finder <jared <at> finder.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: [PATCH] window-tool-bar: Use `static-if' from Compat 30
Date: Sat, 08 Mar 2025 07:36:47 -0800

On 2025-03-08 00:26, Daniel Mendler wrote:
> Tags: patch
> 
> Compat 30 is available on ELPA and provides `static-if'.

I see this created Bug#76858. (apologies if a new bug is created here)

> -;; Package-Requires: ((emacs "27.1") (compat "29.1"))
> +;; Package-Requires: ((emacs "27.1") (compat "30"))

I think this also needs (eval-when-compile (require 'compat)) since 
static-if is a macro. But I could be wrong here, I'm always a bit 
confused about Emacs Lisp's eval-when forms.

  -- MJF
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#76858; Package emacs. (Sat, 08 Mar 2025 15:44:01 GMT) Full text and rfc822 format available.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Jared Finder <jared <at> finder.org>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: [PATCH] window-tool-bar: Use `static-if' from Compat 30
Date: Sat, 08 Mar 2025 16:43:32 +0100

Jared Finder <jared <at> finder.org> writes:

> On 2025-03-08 00:26, Daniel Mendler wrote:
>> Tags: patch
>> Compat 30 is available on ELPA and provides `static-if'.
>
> I see this created Bug#76858. (apologies if a new bug is created here)
>
>> -;; Package-Requires: ((emacs "27.1") (compat "29.1"))
>> +;; Package-Requires: ((emacs "27.1") (compat "30"))
>
> I think this also needs (eval-when-compile (require 'compat)) since static-if is
> a macro. But I could be wrong here, I'm always a bit confused about Emacs Lisp's
> eval-when forms.

No, (require 'compat) is sufficient.

>   -- MJF
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#76858; Package emacs. (Sun, 09 Mar 2025 04:53:02 GMT) Full text and rfc822 format available.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jared Finder <jared <at> finder.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: [PATCH] window-tool-bar: Use `static-if' from Compat 30
Date: Sat, 08 Mar 2025 20:52:30 -0800

On 2025-03-08 07:43, Daniel Mendler wrote:
> Jared Finder <jared <at> finder.org> writes:
> 
>> On 2025-03-08 00:26, Daniel Mendler wrote:
>>> Tags: patch
>>> Compat 30 is available on ELPA and provides `static-if'.
>> 
>> I see this created Bug#76858. (apologies if a new bug is created here)
>> 
>>> -;; Package-Requires: ((emacs "27.1") (compat "29.1"))
>>> +;; Package-Requires: ((emacs "27.1") (compat "30"))
>> 
>> I think this also needs (eval-when-compile (require 'compat)) since 
>> static-if is
>> a macro. But I could be wrong here, I'm always a bit confused about 
>> Emacs Lisp's
>> eval-when forms.
> 
> No, (require 'compat) is sufficient.

Ok, I have no objections then.

  -- MJF
Severity set to 'wishlist' from 'normal' Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Mon, 10 Mar 2025 21:07:03 GMT) Full text and rfc822 format available.
Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Thu, 13 Mar 2025 06:00:02 GMT) Full text and rfc822 format available.
Notification sent to Daniel Mendler <mail <at> daniel-mendler.de>:
bug acknowledged by developer. (Thu, 13 Mar 2025 06:00:02 GMT) Full text and rfc822 format available.

Message #21 received at 76858-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Jared Finder <jared <at> finder.org>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, 76858-done <at> debbugs.gnu.org
Subject: Re: bug#76858: [PATCH] window-tool-bar: Use `static-if' from Compat 30
Date: Wed, 12 Mar 2025 22:59:15 -0700

Version: 31.1

Jared Finder <jared <at> finder.org> writes:

> On 2025-03-08 07:43, Daniel Mendler wrote:
>> Jared Finder <jared <at> finder.org> writes:
>>
>>> On 2025-03-08 00:26, Daniel Mendler wrote:
>>>> Tags: patch
>>>> Compat 30 is available on ELPA and provides `static-if'.
>>> I see this created Bug#76858. (apologies if a new bug is created here)
>>>
>>>> -;; Package-Requires: ((emacs "27.1") (compat "29.1"))
>>>> +;; Package-Requires: ((emacs "27.1") (compat "30"))
>>> I think this also needs (eval-when-compile (require 'compat)) since static-if
>>> is
>>> a macro. But I could be wrong here, I'm always a bit confused about Emacs
>>> Lisp's
>>> eval-when forms.
>> No, (require 'compat) is sufficient.
>
> Ok, I have no objections then.
>
>   -- MJF

Thanks, installed on master as [1: ae33aad7f58].

[1: ae33aad7f58] 2025-03-13
  window-tool-bar: Use `static-if' from Compat 30
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ae33aad7f582864a8dbb0fee10f891fd67abdbe3
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#76858; Package emacs. (Thu, 13 Mar 2025 06:00:03 GMT) Full text and rfc822 format available.

Message #24 received at 76858-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Jared Finder <jared <at> finder.org>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, 76858-done <at> debbugs.gnu.org
Subject: Re: bug#76858: [PATCH] window-tool-bar: Use `static-if' from Compat 30
Date: Wed, 12 Mar 2025 22:59:30 -0700

Version: 31.1

Jared Finder <jared <at> finder.org> writes:

> On 2025-03-08 07:43, Daniel Mendler wrote:
>> Jared Finder <jared <at> finder.org> writes:
>>
>>> On 2025-03-08 00:26, Daniel Mendler wrote:
>>>> Tags: patch
>>>> Compat 30 is available on ELPA and provides `static-if'.
>>> I see this created Bug#76858. (apologies if a new bug is created here)
>>>
>>>> -;; Package-Requires: ((emacs "27.1") (compat "29.1"))
>>>> +;; Package-Requires: ((emacs "27.1") (compat "30"))
>>> I think this also needs (eval-when-compile (require 'compat)) since static-if
>>> is
>>> a macro. But I could be wrong here, I'm always a bit confused about Emacs
>>> Lisp's
>>> eval-when forms.
>> No, (require 'compat) is sufficient.
>
> Ok, I have no objections then.
>
>   -- MJF

Thanks, installed on master as [1: ae33aad7f58].

[1: ae33aad7f58] 2025-03-13
  window-tool-bar: Use `static-if' from Compat 30
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ae33aad7f582864a8dbb0fee10f891fd67abdbe3
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 10 Apr 2025 11:24:12 GMT) Full text and rfc822 format available.
This bug report was last modified 68 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.