GNU bug report logs - #76858
[PATCH] window-tool-bar: Use `static-if' from Compat 30

Previous Next

Package: emacs;

Reported by: Daniel Mendler <mail <at> daniel-mendler.de>

Date: Sat, 8 Mar 2025 08:28:02 UTC

Severity: wishlist

Tags: patch

Fixed in version 31.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jared Finder <jared <at> finder.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: [PATCH] window-tool-bar: Use `static-if' from Compat 30
Date: Sat, 08 Mar 2025 20:52:30 -0800

On 2025-03-08 07:43, Daniel Mendler wrote:
> Jared Finder <jared <at> finder.org> writes:
> 
>> On 2025-03-08 00:26, Daniel Mendler wrote:
>>> Tags: patch
>>> Compat 30 is available on ELPA and provides `static-if'.
>> 
>> I see this created Bug#76858. (apologies if a new bug is created here)
>> 
>>> -;; Package-Requires: ((emacs "27.1") (compat "29.1"))
>>> +;; Package-Requires: ((emacs "27.1") (compat "30"))
>> 
>> I think this also needs (eval-when-compile (require 'compat)) since 
>> static-if is
>> a macro. But I could be wrong here, I'm always a bit confused about 
>> Emacs Lisp's
>> eval-when forms.
> 
> No, (require 'compat) is sufficient.

Ok, I have no objections then.

  -- MJF
This bug report was last modified 68 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.